RepoMirrors
/
ffmpeg
mirror of https://git.ffmpeg.org/ffmpeg.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

doc: git-howto: Leave reviewers time to react before pushing patches

This commit is contained in:
Diego Biurrun 2012-10-25 18:33:38 +02:00
parent a903f8f087
commit 97bf7c03b1
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/git-howto.texi
View File

@ -419,6 +419,13 @@ Also note that every single commit should pass the test suite, not just
the result of a series of patches. So if you have a series of commits the result of a series of patches. So if you have a series of commits
to push, run the test suite on every single commit. to push, run the test suite on every single commit.
Give other developers a reasonable amount of time to look at and review
patches before you push them. Not everybody is online 24/7, but may wish
to look at and comment on a patch nonetheless. The time you leave depends
on the urgency and complexity of the patch. Use your common sense to pick
a timeframe that allows everybody that you think may wish to comment
and/or should comment on the change an opportunity to see it.
Finally, after pushing, mark all patches as committed on Finally, after pushing, mark all patches as committed on
@url{http://patches.libav.org/,patchwork}. @url{http://patches.libav.org/,patchwork}.
Sometimes this is not automatically done when a patch has been Sometimes this is not automatically done when a patch has been