From 969e8d35b5b4c457b33df524ca95cd548a404599 Mon Sep 17 00:00:00 2001 From: Xi Wang Date: Sat, 9 Mar 2013 22:39:32 -0500 Subject: [PATCH] lavfi/pad: avoid buffer overflow in buffer_needs_copy() Replace & with short-circuit &&. Signed-off-by: Xi Wang Signed-off-by: Stefano Sabatini --- libavfilter/vf_pad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_pad.c b/libavfilter/vf_pad.c index 86fd683ce2..3f4a4f0dfa 100644 --- a/libavfilter/vf_pad.c +++ b/libavfilter/vf_pad.c @@ -300,7 +300,7 @@ static int buffer_needs_copy(PadContext *s, AVFrame *frame, AVBufferRef *buf) return 1; #define SIGN(x) ((x) > 0 ? 1 : -1) - for (j = 0; j < FF_ARRAY_ELEMS(planes) & planes[j] >= 0; j++) { + for (j = 0; j < FF_ARRAY_ELEMS(planes) && planes[j] >= 0; j++) { int hsub1 = s->draw.hsub[planes[j]]; uint8_t *start1 = frame->data[planes[j]]; uint8_t *end1 = start1 + (frame->height >> hsub1) *