RepoMirrors
/
ffmpeg
mirror of https://git.ffmpeg.org/ffmpeg.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

avcodec/alac: Fix integer overflow in lpc_prediction() with sign 

Fixes: signed integer overflow: -2147483648 * -1 cannot be represented in type 'int'
Fixes: 18643/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5672182449700864

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Michael Niedermayer 2019-11-08 20:40:46 +01:00
parent 589cb44498
commit 7686ba1f14
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libavcodec/alac.c
View File

@ -227,7 +227,7 @@ static void lpc_prediction(int32_t *error_buffer, uint32_t *buffer_out,
val = d - pred[j]; val = d - pred[j];
sign = sign_only(val) * error_sign; sign = sign_only(val) * error_sign;
lpc_coefs[j] -= sign; lpc_coefs[j] -= sign;
val *= sign; val *= (unsigned)sign;
error_val -= (val >> lpc_quant) * (j + 1); error_val -= (val >> lpc_quant) * (j + 1);
} }
} }