From 63eb630915b9ef92d21e521d610ed9d3ee2f358f Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 13 Sep 2023 20:36:43 +0200 Subject: [PATCH] avcodec/libvpxdec: Remove redundant unreferencing of AVFrame The AVFrame of a decoder with the ordinary decode callback is generically unreferenced on error. Reviewed-by: James Zern Signed-off-by: Andreas Rheinhardt --- libavcodec/libvpxdec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index 72ef5fa9a7..c6187fd5a1 100644 --- a/libavcodec/libvpxdec.c +++ b/libavcodec/libvpxdec.c @@ -317,10 +317,8 @@ static int vpx_decode(AVCodecContext *avctx, AVFrame *picture, return AVERROR(ENOMEM); if (ctx->has_alpha_channel) { picture->buf[1] = av_buffer_ref(img_alpha->fb_priv); - if (!picture->buf[1]) { - av_frame_unref(picture); + if (!picture->buf[1]) return AVERROR(ENOMEM); - } } for (int i = 0; i < 4; i++) { picture->data[i] = planes[i];