RepoMirrors
/
ffmpeg
mirror of https://git.ffmpeg.org/ffmpeg.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

checkasm: h264dsp: Avoid out of buffer writes when benchmarking 

The loop filters can write before the pointer given to them;
the actual test invocations correctly used an offset, while
the benchmark calls were lacking an offset. Therefore, when
running with benchmarking, these tests could have spurious
failures.

Signed-off-by: Martin Storsjö <martin@martin.st>
This commit is contained in:
Martin Storsjö 2024-05-21 14:03:07 +03:00
parent d43e123837
commit 6093367147
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/checkasm/h264dsp.c
View File

@ -362,7 +362,7 @@ static void check_loop_filter(void)
tc0[j][0], tc0[j][1], tc0[j][2], tc0[j][3]); \
fail(); \
} \
bench_new(dst1, 32, alphas[j], betas[j], tc0[j]); \
bench_new(dst1 + off, 32, alphas[j], betas[j], tc0[j]);\
} \
} \
} while (0)
@ -421,7 +421,7 @@ static void check_loop_filter_intra(void)
j, alphas[j], betas[j]); \
fail(); \
} \
bench_new(dst1, 32, alphas[j], betas[j]); \
bench_new(dst1 + off, 32, alphas[j], betas[j]); \
} \
} \
} while (0)