RepoMirrors
/
ffmpeg
mirror of https://git.ffmpeg.org/ffmpeg.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fftools: do not access out of bounds filtergraph 

The log message was logged for `filtergraphs[j]` which would cause a
heap buffer overflow in certain circumstances.

Correctly it should be logged for the current filtergraph, so just
use `fg` here.
This commit is contained in:
Marvin Scholz 2024-10-01 02:57:11 +02:00
parent ac092c6707
commit 5beeb3a1f9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fftools/ffmpeg_filter.c
View File

@ -1409,7 +1409,7 @@ int fg_finalise_bindings(void)
for (int j = 0; j < fg->nb_outputs; j++) { for (int j = 0; j < fg->nb_outputs; j++) {
OutputFilter *output = fg->outputs[j]; OutputFilter *output = fg->outputs[j];
if (!output->bound) { if (!output->bound) {
av_log(filtergraphs[j], AV_LOG_FATAL, av_log(fg, AV_LOG_FATAL,
"Filter %s has an unconnected output\n", output->name); "Filter %s has an unconnected output\n", output->name);
return AVERROR(EINVAL); return AVERROR(EINVAL);
} }