From bb7701684c7170dfd5f33a3c7d827265844619f2 Mon Sep 17 00:00:00 2001 From: Vittorio Giovara Date: Thu, 4 Dec 2014 19:09:40 +0000 Subject: [PATCH] lavf: Document the codec context initialization During remuxing avcodec_copy_context() is discouraged as certain fields (such as codec_tag) could reflect invalid values between input and output contextes. --- libavformat/avformat.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 0994c8075e..aa11cff2f3 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -198,6 +198,10 @@ * be set to the timebase that the caller desires to use for this stream (note * that the timebase actually used by the muxer can be different, as will be * described later). + * - It is advised to manually initialize only the relevant fields in + * AVCodecContext, rather than using @ref avcodec_copy_context() during + * remuxing: there is no guarantee that the codec context values remain valid + * for both input and output format contexts. * - The caller may fill in additional information, such as @ref * AVFormatContext.metadata "global" or @ref AVStream.metadata "per-stream" * metadata, @ref AVFormatContext.chapters "chapters", @ref