RepoMirrors/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2025-02-18 04:47:12 +00:00
Code Issues Projects Releases Wiki Activity

OpenCL: Avoid potential buffer overflow in cmdutils_opencl.c

Browse Source 
The opt_opencl_bench function copied the device name using strcpy without checking if the source string was larger.
This patch fixes this by replacing the strcpy with av_strlcpy, with the string copy size capped to the destination buffer size.

Signed-off-by: Maneesh Gupta <maneesh.gupta@amd.com>
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
(cherry picked from commit cf234552b8)

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
Maneesh Gupta 2015-04-28 13:08:31 +05:30 committed by Michael Niedermayer
parent 427cf443ab
commit 5260ba3e16
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmdutils_opencl.c
View File

@ -22,6 +22,7 @@
#include "libavutil/time.h" #include "libavutil/time.h"
#include "libavutil/log.h" #include "libavutil/log.h"
#include "libavutil/opencl.h" #include "libavutil/opencl.h"
#include "libavutil/avstring.h"
#include "cmdutils.h" #include "cmdutils.h"
typedef struct { typedef struct {
@ -238,7 +239,8 @@ int opt_opencl_bench(void *optctx, const char *opt, const char *arg)
devices[count].platform_idx = i; devices[count].platform_idx = i;
devices[count].device_idx = j; devices[count].device_idx = j;
devices[count].runtime = score; devices[count].runtime = score;
strcpy(devices[count].device_name, device_node->device_name); av_strlcpy(devices[count].device_name, device_node->device_name,
sizeof(devices[count].device_name));
count++; count++;
} }
} }