avfilter/pad: improve error check for w and h

Target dimensions have to cover entire input.
This commit is contained in:
Gyan Doshi 2020-01-15 21:09:38 +05:30
parent f8990c5f41
commit 4de2106fbf

View File

@ -178,14 +178,14 @@ static int config_input(AVFilterLink *inlink)
if (s->y < 0 || s->y + inlink->h > s->h)
s->y = var_values[VAR_Y] = (s->h - inlink->h) / 2;
s->w = ff_draw_round_to_sub(&s->draw, 0, -1, s->w);
s->h = ff_draw_round_to_sub(&s->draw, 1, -1, s->h);
/* sanity check params */
if (s->w < 0 || s->h < 0) {
av_log(ctx, AV_LOG_ERROR, "Negative values are not acceptable.\n");
if (s->w < inlink->w || s->h < inlink->h) {
av_log(ctx, AV_LOG_ERROR, "Padded dimensions cannot be smaller than input dimensions.\n");
return AVERROR(EINVAL);
}
s->w = ff_draw_round_to_sub(&s->draw, 0, -1, s->w);
s->h = ff_draw_round_to_sub(&s->draw, 1, -1, s->h);
s->x = ff_draw_round_to_sub(&s->draw, 0, -1, s->x);
s->y = ff_draw_round_to_sub(&s->draw, 1, -1, s->y);
s->in_w = ff_draw_round_to_sub(&s->draw, 0, -1, inlink->w);