RepoMirrors/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2024-12-23 15:53:08 +00:00
Code Issues Projects Releases Wiki Activity

avcodec/libopusenc: Fix warning when encoding ambisonics with channel mapping 2

Browse Source 
Also adds checks on the number of channels.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Felicia Lim 2018-07-30 12:59:44 -07:00 committed by Michael Niedermayer
parent 271a00043e
commit 4cd6f08d20
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
libavcodec/libopusenc.c
View File

@ -27,6 +27,7 @@
#include "bytestream.h"
#include "internal.h"
#include "libopus.h"
#include "mathops.h"
#include "vorbis.h"
#include "audio_frame_queue.h"
@ -200,6 +201,21 @@ static int libopus_check_vorbis_layout(AVCodecContext *avctx, int mapping_family
return 0;
}
static int libopus_check_ambisonics_channels(AVCodecContext *avctx) {
int channels = avctx->channels;
int ambisonic_order = ff_sqrt(channels) - 1;
if (channels != ((ambisonic_order + 1) * (ambisonic_order + 1)) &&
channels != ((ambisonic_order + 1) * (ambisonic_order + 1) + 2)) {
av_log(avctx, AV_LOG_ERROR,
"Ambisonics coding is only specified for channel counts"
" which can be written as (n + 1)^2 or (n + 1)^2 + 2"
" for nonnegative integer n\n");
return AVERROR_INVALIDDATA;
}
return 0;
}
static int libopus_validate_layout_and_get_channel_map(
AVCodecContext *avctx,
int mapping_family,
@ -231,6 +247,12 @@ static int libopus_validate_layout_and_get_channel_map(
channel_map = ff_vorbis_channel_layout_offsets[avctx->channels - 1];
}
break;
case 2:
ret = libopus_check_max_channels(avctx, 227);
if (ret == 0) {
ret = libopus_check_ambisonics_channels(avctx);
}
break;
case 255:
ret = libopus_check_max_channels(avctx, 254);
break;