RepoMirrors
/
ffmpeg
mirror of https://git.ffmpeg.org/ffmpeg.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Clarify comment block and rewrite in better English. 

Originally committed as revision 10837 to svn://svn.ffmpeg.org/ffmpeg/trunk
This commit is contained in:
Diego Biurrun 2007-10-22 15:13:10 +00:00
parent 8622613d9f
commit 3a994ca43b
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
libavcodec/mpegvideo.c
View File

@ -843,17 +843,17 @@ int ff_find_unused_picture(MpegEncContext *s, int shared){
} }
av_log(s->avctx, AV_LOG_FATAL, "Internal error, picture buffer overflow\n"); av_log(s->avctx, AV_LOG_FATAL, "Internal error, picture buffer overflow\n");
/*we could return -1 but the codec would crash anyway, trying to draw /* We could return -1, but the codec would crash trying to draw into a
into, a non existing frame, this is safer than waiting for a random crash * non-existing frame anyway. This is safer than waiting for a random crash.
also the return of this is never usefull, a encoder must only allocate * Also the return of this is never useful, an encoder must only allocate
as many as allowed in the spec which has no relation to how many lavc * as much as allowed in the specification. This has no relationship to how
could allocate (and MAX_PICTURE_COUNT is always large enough for such * much libavcodec could allocate (and MAX_PICTURE_COUNT is always large
valid streams) * enough for such valid streams).
and a decoder has to check stream validity and remove frames if too many * Plus, a decoder has to check stream validity and remove frames if too
reference frames are around. waiting for "OOM" is not correct at all, it * many reference frames are around. Waiting for "OOM" is not correct at
similarely has to replace missing reference frames by (interpolated/MC) * all. Similarly, missing reference frames have to be replaced by
frames anything else is a bug in the codec ... * interpolated/MC frames, anything else is a bug in the codec ...
*/ */
abort(); abort();
return -1; return -1;
} }