From 32d464121959389bd266abe232896da09bbf2bd5 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Mon, 29 Apr 2013 13:31:04 +0000 Subject: [PATCH] lavfi/showspectrum: fix crash in case of negative linesize Signed-off-by: Paul B Mahol --- libavfilter/avf_showspectrum.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index 058f22c919..7cd75dfe0d 100644 --- a/libavfilter/avf_showspectrum.c +++ b/libavfilter/avf_showspectrum.c @@ -211,9 +211,11 @@ static int config_output(AVFilterLink *outlink) if (!outpicref) return AVERROR(ENOMEM); outlink->sample_aspect_ratio = (AVRational){1,1}; - memset(outpicref->data[0], 0, outlink->h * outpicref->linesize[0]); - memset(outpicref->data[1], 128, outlink->h * outpicref->linesize[1]); - memset(outpicref->data[2], 128, outlink->h * outpicref->linesize[2]); + for (i = 0; i < outlink->h; i++) { + memset(outpicref->data[0] + i * outpicref->linesize[0], 0, outlink->w); + memset(outpicref->data[1] + i * outpicref->linesize[1], 128, outlink->w); + memset(outpicref->data[2] + i * outpicref->linesize[2], 128, outlink->w); + } } if (showspectrum->xpos >= outlink->w)