RepoMirrors/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2025-01-21 06:50:56 +00:00
Code Issues Projects Releases Wiki Activity

avformat/http: flushing tcp receive buffer when it is write only mode

Browse Source 
In write only mode, the TCP receive buffer's data keeps growing with
http response messages and the buffer eventually becomes full.
This results in zero tcp window size, which in turn causes unwanted
issues, like, terminated tcp connection. The issue is apparent when
http persistent connection is enabled in hls/dash live streaming use
cases. To overcome this issue, the logic here reads the buffer data
when a file transfer is completed, so that any accumulated data in
the recieve buffer gets flushed out.
This commit is contained in:
Vishwanath Dixit 2018-04-04 16:38:18 +05:30 committed by Karthick Jeyapal
parent 002e45b407
commit 30940be359
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libavformat/http.c
View File

@ -1623,6 +1623,18 @@ static int http_shutdown(URLContext *h, int flags)
((flags & AVIO_FLAG_READ) && s->chunked_post && s->listen)) {
ret = ffurl_write(s->hd, footer, sizeof(footer) - 1);
ret = ret > 0 ? 0 : ret;
/* flush the receive buffer when it is write only mode */
if (!(flags & AVIO_FLAG_READ)) {
char buf[1024];
int read_ret;
s->hd->flags |= AVIO_FLAG_NONBLOCK;
read_ret = ffurl_read(s->hd, buf, sizeof(buf));
s->hd->flags &= ~AVIO_FLAG_NONBLOCK;
if (read_ret < 0 && read_ret != AVERROR(EAGAIN)) {
av_log(h, AV_LOG_ERROR, "URL read error: %d\n", read_ret);
ret = read_ret;
}
}
s->end_chunked_post = 1;
}