avfilter/vf_deshake: use a void * comparator for consistency

For generality, qsort uses a comparator whose elements are void *. This
makes the comparator have such a form, and thus makes the void * cast of
the comparator pointer useless. Furthermore, this makes the code more
consistent with other usages of qsort across the codebase.

Reviewed-by: Henrik Gramner <henrik@gramner.com>
Reviewed-by: wm4 <nfxjfg@googlemail.com>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
This commit is contained in:
Ganesh Ajjanagadde 2015-10-24 17:49:57 -04:00
parent 38f4e973ef
commit 2ee51ef259
1 changed files with 4 additions and 3 deletions

View File

@ -91,9 +91,10 @@ static const AVOption deshake_options[] = {
AVFILTER_DEFINE_CLASS(deshake); AVFILTER_DEFINE_CLASS(deshake);
static int cmp(const double *a, const double *b) static int cmp(const void *a, const void *b)
{ {
return *a < *b ? -1 : ( *a > *b ? 1 : 0 ); const double va = *(const double *)a, vb = *(const double *)b;
return va < vb ? -1 : ( va > vb ? 1 : 0 );
} }
/** /**
@ -105,7 +106,7 @@ static double clean_mean(double *values, int count)
int cut = count / 5; int cut = count / 5;
int x; int x;
qsort(values, count, sizeof(double), (void*)cmp); qsort(values, count, sizeof(double), cmp);
for (x = cut; x < count - cut; x++) { for (x = cut; x < count - cut; x++) {
mean += values[x]; mean += values[x];