RepoMirrors/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2025-01-17 21:00:51 +00:00
Code Issues Projects Releases Wiki Activity

dnn/dnn_backend_native: Don't use asserts for checks

Browse Source 
asserts should not be used instead of ordinary input checks.
Yet the native DNN backend did it: get_input_native() asserted that
the first dimension was one, despite this value coming directly from
the input file without having been sanitized.

Reviewed-by: Guo, Yejun <yejun.guo@intel.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
This commit is contained in:
Andreas Rheinhardt 2021-03-10 14:00:26 +01:00
parent 0e078c6cfa
commit 1e47ef600d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libavfilter/dnn/dnn_backend_native.c
View File

@ -232,6 +232,8 @@ DNNModel *ff_dnn_load_model_native(const char *model_filename, DNNFunctionType f
oprd->dims[dim] = (int32_t)avio_rl32(model_file_context); oprd->dims[dim] = (int32_t)avio_rl32(model_file_context);
dnn_size += 4; dnn_size += 4;
} }
if (oprd->type == DOT_INPUT && oprd->dims[0] != 1)
goto fail;
oprd->isNHWC = 1; oprd->isNHWC = 1;
} }