From 10ad3cd7982e5a5d922cabd176c97571a7684c60 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 15 Sep 2021 05:13:11 +0200 Subject: [PATCH] avfilter/avfilter: Actually error out on init error Currently an error from init could be overwritten by successfully setting the enable expression. Reviewed-by: Nicolas George Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index c614eb0740..ce63b9762f 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -924,6 +924,8 @@ int avfilter_init_dict(AVFilterContext *ctx, AVDictionary **options) ret = ctx->filter->init(ctx); else if (ctx->filter->init_dict) ret = ctx->filter->init_dict(ctx, options); + if (ret < 0) + return ret; if (ctx->enable_str) { ret = set_enable_expr(ctx, ctx->enable_str); @@ -931,7 +933,7 @@ int avfilter_init_dict(AVFilterContext *ctx, AVDictionary **options) return ret; } - return ret; + return 0; } int avfilter_init_str(AVFilterContext *filter, const char *args)