From 0b7bfa8ad79e483fd81fc006b35c4ef86990d46f Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Sat, 1 Jun 2019 11:28:56 +0800 Subject: [PATCH] lavf/sr: Refine the coding style for init We perfer the coding style like: /* some stuff */ if (error) { /* error handling */ return -(errorcode); } /* normal actions */ do_something() Signed-off-by: Jun Zhao --- libavfilter/vf_sr.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_sr.c b/libavfilter/vf_sr.c index 0be572ff9d..0433246e26 100644 --- a/libavfilter/vf_sr.c +++ b/libavfilter/vf_sr.c @@ -72,17 +72,16 @@ static av_cold int init(AVFilterContext *context) av_log(context, AV_LOG_ERROR, "could not create DNN module for requested backend\n"); return AVERROR(ENOMEM); } + if (!sr_context->model_filename){ av_log(context, AV_LOG_ERROR, "model file for network was not specified\n"); return AVERROR(EIO); - } else { - if (!sr_context->dnn_module->load_model) { - av_log(context, AV_LOG_ERROR, "load_model for network was not specified\n"); - return AVERROR(EIO); - } else { - sr_context->model = (sr_context->dnn_module->load_model)(sr_context->model_filename); - } } + if (!sr_context->dnn_module->load_model) { + av_log(context, AV_LOG_ERROR, "load_model for network was not specified\n"); + return AVERROR(EIO); + } + sr_context->model = (sr_context->dnn_module->load_model)(sr_context->model_filename); if (!sr_context->model){ av_log(context, AV_LOG_ERROR, "could not load DNN model\n"); return AVERROR(EIO);