RepoMirrors/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2024-12-27 09:52:17 +00:00
Code Issues Projects Releases Wiki Activity

h274: remove optimization pragma

Browse Source 
This results in warnings on compilers which don't support it,
objections were raised during the review process about it but went unnoticed,
and the speed benefit is highly compiler and version specific, and
also not very critical.

We generally hand-write assembly to optimize loops like that, rather
than use compiler magic, and for 40% best case scenario, it's simply
not worth it.

Plus, tree vectorization is still problematic with GCC and disabled by default
for a good reason, so enabling it locally is sketchy.
This commit is contained in:
Lynne 2021-08-25 21:20:18 +02:00
parent 1da524121c
commit 033105a739
No known key found for this signature in database
GPG Key ID: A2FEA5F03F034464
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libavcodec/h274.c
View File

@ -30,10 +30,6 @@
#include "h274.h"
// The code in this file has a lot of loops that vectorize very well, this is
// about a 40% speedup for no obvious downside.
#pragma GCC optimize("tree-vectorize")
static const int8_t Gaussian_LUT[2048+256];
static const uint32_t Seed_LUT[256];
static const int8_t R64T[64][64];