RepoMirrors/crash
1
0
Fork 0
mirror of https://github.com/crash-utility/crash synced 2025-02-24 01:16:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for "kmem -[sS]" options for kernels configured with CONFIG_SLUB.

Browse Source 
Without the patch, if a freelist pointer is corrupt, the address of
the slab page being referenced may not be displayed by the error
message, showing something like: "kmem: kmalloc-32: slab: 0 invalid
freepointer: 6e652f323a302d74".
(hirofumi@mail.parknet.co.jp)
This commit is contained in:
Dave Anderson 2016-04-21 11:26:19 -04:00
parent f6918567d7
commit 7f324a4144
1 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
memory.c
View File

@ -17948,12 +17948,12 @@ slub_page_objects(struct meminfo *si, ulong page)
if (CRASHDEBUG(1) && (objects != si->objects))
error(NOTE, "%s: slab: %lx oo objects: %ld "
"slab objects: %d\n",
si->curname, si->slab,
si->curname, page,
si->objects, objects);
if (objects == (ushort)(-1)) {
error(INFO, "%s: slab: %lx invalid page.objects: -1\n",
si->curname, si->slab);
si->curname, page);
return 0;
}
} else
@ -18011,7 +18011,7 @@ get_kmem_cache_slub_data(long cmd, struct meminfo *si)
{
int i, n, node;
ulong total_objects, total_slabs, free_objects;
ulong cpu_slab_ptr, node_ptr, cpu_freelist;
ulong cpu_slab_ptr, node_ptr, cpu_freelist, orig_slab;
ulong node_nr_partial, node_nr_slabs, node_total_objects;
int full_slabs, objects, node_total_avail;
long p;
@ -18040,14 +18040,22 @@ get_kmem_cache_slub_data(long cmd, struct meminfo *si)
switch (cmd)
{
case GET_SLUB_OBJECTS:
case GET_SLUB_OBJECTS: {
/* For better error report, set cur slab to si->slab. */
orig_slab = si->slab;
si->slab = cpu_slab_ptr;
if (!readmem(cpu_slab_ptr + OFFSET(page_inuse),
KVADDR, &inuse, sizeof(short),
"page inuse", RETURN_ON_ERROR))
KVADDR, &inuse, sizeof(short),
"page inuse", RETURN_ON_ERROR)) {
si->slab = orig_slab;
return FALSE;
}
objects = slub_page_objects(si, cpu_slab_ptr);
if (!objects)
if (!objects) {
si->slab = orig_slab;
return FALSE;
}
free_objects += objects - inuse;
free_objects += count_free_objects(si, cpu_freelist);
@ -18056,6 +18064,9 @@ get_kmem_cache_slub_data(long cmd, struct meminfo *si)
if (!node_total_avail)
total_objects += inuse;
total_slabs++;
si->slab = orig_slab;
}
break;
case GET_SLUB_SLABS: