mirror of
https://github.com/ceph/ceph
synced 2024-12-28 06:23:08 +00:00
6c4f31eccf
CMAKE_THREAD_LIBS_INIT can be empty. On newer platforms, this leads to an error: CMake Error at cmake/modules/Buildpmem.cmake:47 (set_target_properties): set_target_properties called with incorrect number of arguments. This is because glibc 2.34 merged libpthread.so into libc.so. Fedora 35 and RHEL 9 have glibc 2.34. Fixes: https://tracker.ceph.com/issues/52353 Signed-off-by: Ken Dreyer <kdreyer@redhat.com> Co-authored-by: Kefu Chai <kchai@redhat.com>
61 lines
2.1 KiB
CMake
61 lines
2.1 KiB
CMake
function(build_pmem)
|
|
include(FindMake)
|
|
find_make("MAKE_EXECUTABLE" "make_cmd")
|
|
|
|
if(EXISTS "${PROJECT_SOURCE_DIR}/src/pmdk/Makefile")
|
|
set(source_dir_args
|
|
SOURCE_DIR "${PROJECT_SOURCE_DIR}/src/pmdk")
|
|
else()
|
|
set(source_dir_args
|
|
SOURCE_DIR ${CMAKE_BINARY_DIR}/src/pmdk
|
|
GIT_REPOSITORY https://github.com/ceph/pmdk.git
|
|
GIT_TAG "1.10"
|
|
GIT_SHALLOW TRUE
|
|
GIT_CONFIG advice.detachedHead=false)
|
|
endif()
|
|
|
|
# Use debug PMDK libs in debug lib/rbd builds
|
|
if(CMAKE_BUILD_TYPE STREQUAL Debug)
|
|
set(PMDK_LIB_DIR "debug")
|
|
else()
|
|
set(PMDK_LIB_DIR "nondebug")
|
|
endif()
|
|
|
|
include(ExternalProject)
|
|
ExternalProject_Add(pmdk_ext
|
|
${source_dir_args}
|
|
CONFIGURE_COMMAND ""
|
|
# Explicitly built w/o NDCTL, otherwise if ndtcl is present on the
|
|
# build system tests statically linking to librbd (which uses
|
|
# libpmemobj) will not link (because we don't build the ndctl
|
|
# static library here).
|
|
BUILD_COMMAND ${make_cmd} CC=${CMAKE_C_COMPILER} NDCTL_ENABLE=n BUILD_EXAMPLES=n BUILD_BENCHMARKS=n DOC=n
|
|
BUILD_IN_SOURCE 1
|
|
BUILD_BYPRODUCTS "<SOURCE_DIR>/src/${PMDK_LIB_DIR}/libpmem.a" "<SOURCE_DIR>/src/${PMDK_LIB_DIR}/libpmemobj.a"
|
|
INSTALL_COMMAND "")
|
|
unset(make_cmd)
|
|
|
|
ExternalProject_Get_Property(pmdk_ext source_dir)
|
|
set(PMDK_SRC "${source_dir}/src")
|
|
set(PMDK_INCLUDE "${source_dir}/src/include")
|
|
set(PMDK_LIB "${source_dir}/src/${PMDK_LIB_DIR}")
|
|
|
|
# libpmem
|
|
add_library(pmem::pmem STATIC IMPORTED GLOBAL)
|
|
add_dependencies(pmem::pmem pmdk_ext)
|
|
file(MAKE_DIRECTORY ${PMDK_INCLUDE})
|
|
find_package(Threads)
|
|
set_target_properties(pmem::pmem PROPERTIES
|
|
INTERFACE_INCLUDE_DIRECTORIES ${PMDK_INCLUDE}
|
|
IMPORTED_LOCATION "${PMDK_LIB}/libpmem.a"
|
|
INTERFACE_LINK_LIBRARIES Threads::Threads)
|
|
|
|
# libpmemobj
|
|
add_library(pmem::pmemobj STATIC IMPORTED GLOBAL)
|
|
add_dependencies(pmem::pmemobj pmdk_ext)
|
|
set_target_properties(pmem::pmemobj PROPERTIES
|
|
INTERFACE_INCLUDE_DIRECTORIES ${PMDK_INCLUDE}
|
|
IMPORTED_LOCATION "${PMDK_LIB}/libpmemobj.a"
|
|
INTERFACE_LINK_LIBRARIES "pmem::pmem;${CMAKE_THREAD_LIBS_INIT}")
|
|
endfunction()
|