Ilya Dryomov 7fb4fdbed0 mgr/rbd_support: always rescan image mirror snapshots on refresh ... Establishing a watch on rbd_mirroring object and skipping rescanning image mirror snapshots on periodic refresh unless rbd_mirroring object gets notified in the interim is flawed. rbd_mirroring object is notified when mirroring is enabled or disabled on some image (including when the image is removed), but it is not notified when images are promoted or demoted. However, load_pool_images() discards images that are not primary at the time of the scan. If the image is promoted later, no snapshots are created even if the schedule is in place. This happens regardless of whether the schedule is added before or after the promotion. This effectively reverts commit 69259c8d37 ("mgr/rbd_support: make mirror_snapshot_schedule rescan only updated pools"). An alternative fix could be to stop discarding non-primary images (i.e. drop if not info['primary']: continue check added in commit d39eb283c5 ("mgr/rbd_support: mirror snapshot schedule should skip non-primary images")), but that would clutter the queue and therefore "rbd mirror snapshot schedule status" output with bogus entries. Performing a rescan roughly every 60 seconds should be manageable: currently it amounts to a single mirror_image_status_list request, followed by mirror_image_get, get_snapcontext and snapshot_get requests for each snapshot-based mirroring enabled image and concluded by a single dir_list request. Among these, per-image get_snapcontext and snapshot_get requests are necessary for determining primaryness. Fixes: https://tracker.ceph.com/issues/53914 Signed-off-by: Ilya Dryomov <idryomov@gmail.com>		2022-06-21 12:46:49 +02:00
..
caps
ceph-tests
cephadm	Merge pull request #46506 from asm0deuz/mod_iscsi_systemd	2022-06-14 09:56:49 -04:00
cephtool	Merge pull request #45409 from NUABO/tancz	2022-05-24 07:59:36 -07:00
client
cls	qa/rgw: run ceph_test_cls_rgw_gc in rgw/verify suite	2021-12-09 11:07:03 -05:00
direct_io
erasure-code
fs	Merge pull request #45556 from mchangir/qa-add-subvolume-option-flavors	2022-06-13 12:29:43 +05:30
hadoop
libcephfs
mgr
mon	Merge pull request #45078 from kamoltat/wip-ksirivad-fix-target-size-ratio-bound	2022-03-15 09:22:58 -07:00
objectstore
osdc
rados	qa: add object-dedup test	2021-12-14 13:49:45 +09:00
rbd	mgr/rbd_support: always rescan image mirror snapshots on refresh	2022-06-21 12:46:49 +02:00
rename
rest	qa: Upgrade to mypy 0.901	2021-06-09 12:53:21 +02:00
restart
rgw	test/rgw: fix test case for empty-OLH-name cleanup	2022-05-31 17:29:18 -04:00
suites	qa: update the ffsb.sh to clone it from git://git.ceph.com/ffsb.git	2021-05-06 14:00:45 +08:00
windows	qa: add basic Ceph on Windows integration test	2022-04-19 17:21:52 +03:00
ceph-helpers-root.sh	qa: Add SoftIron Linux as valid debian-based distro in test scripts	2021-07-15 07:16:59 -04:00
false.sh
kernel_untar_build.sh
Makefile
post-file.sh
true.sh