mirror of
https://github.com/ceph/ceph
synced 2024-12-28 22:43:29 +00:00
82814ac49d
To run a command and get its return value, instead of typing something as long as "self.mds_cluster.mon_manager.raw_cluster_cmd_result" add a hepler method in CephFSTestCase and use it. This makes this task very simple - "self.get_ceph_cmd_result()". Also, remove method CephFSTestCase.run_cluster_cmd_result() in favour of this new method. Signed-off-by: Rishabh Dave <ridave@redhat.com>
110 lines
3.9 KiB
Python
110 lines
3.9 KiB
Python
from textwrap import dedent
|
|
from teuthology.exceptions import CommandFailedError
|
|
from tasks.cephfs.cephfs_test_case import CephFSTestCase
|
|
import os
|
|
|
|
|
|
class TestPoolPerm(CephFSTestCase):
|
|
def test_pool_perm(self):
|
|
self.mount_a.run_shell(["touch", "test_file"])
|
|
|
|
file_path = os.path.join(self.mount_a.mountpoint, "test_file")
|
|
|
|
remote_script = dedent("""
|
|
import os
|
|
import errno
|
|
|
|
fd = os.open("{path}", os.O_RDWR)
|
|
try:
|
|
if {check_read}:
|
|
ret = os.read(fd, 1024)
|
|
else:
|
|
os.write(fd, b'content')
|
|
except OSError as e:
|
|
if e.errno != errno.EPERM:
|
|
raise
|
|
else:
|
|
raise RuntimeError("client does not check permission of data pool")
|
|
""")
|
|
|
|
client_name = "client.{0}".format(self.mount_a.client_id)
|
|
|
|
# set data pool read only
|
|
self.get_ceph_cmd_result(
|
|
'auth', 'caps', client_name, 'mds', 'allow', 'mon', 'allow r',
|
|
'osd', 'allow r pool={0}'.format(self.fs.get_data_pool_name()))
|
|
|
|
self.mount_a.umount_wait()
|
|
self.mount_a.mount_wait()
|
|
|
|
# write should fail
|
|
self.mount_a.run_python(remote_script.format(path=file_path, check_read=str(False)))
|
|
|
|
# set data pool write only
|
|
self.get_ceph_cmd_result(
|
|
'auth', 'caps', client_name, 'mds', 'allow', 'mon', 'allow r',
|
|
'osd', 'allow w pool={0}'.format(self.fs.get_data_pool_name()))
|
|
|
|
self.mount_a.umount_wait()
|
|
self.mount_a.mount_wait()
|
|
|
|
# read should fail
|
|
self.mount_a.run_python(remote_script.format(path=file_path, check_read=str(True)))
|
|
|
|
def test_forbidden_modification(self):
|
|
"""
|
|
That a client who does not have the capability for setting
|
|
layout pools is prevented from doing so.
|
|
"""
|
|
|
|
# Set up
|
|
client_name = "client.{0}".format(self.mount_a.client_id)
|
|
new_pool_name = "data_new"
|
|
self.fs.add_data_pool(new_pool_name)
|
|
|
|
self.mount_a.run_shell(["touch", "layoutfile"])
|
|
self.mount_a.run_shell(["mkdir", "layoutdir"])
|
|
|
|
# Set MDS 'rw' perms: missing 'p' means no setting pool layouts
|
|
self.get_ceph_cmd_result(
|
|
'auth', 'caps', client_name, 'mds', 'allow rw', 'mon', 'allow r',
|
|
'osd',
|
|
'allow rw pool={0},allow rw pool={1}'.format(
|
|
self.fs.get_data_pool_names()[0],
|
|
self.fs.get_data_pool_names()[1],
|
|
))
|
|
|
|
self.mount_a.umount_wait()
|
|
self.mount_a.mount_wait()
|
|
|
|
with self.assertRaises(CommandFailedError):
|
|
self.mount_a.setfattr("layoutfile", "ceph.file.layout.pool",
|
|
new_pool_name)
|
|
with self.assertRaises(CommandFailedError):
|
|
self.mount_a.setfattr("layoutdir", "ceph.dir.layout.pool",
|
|
new_pool_name)
|
|
self.mount_a.umount_wait()
|
|
|
|
# Set MDS 'rwp' perms: should now be able to set layouts
|
|
self.get_ceph_cmd_result(
|
|
'auth', 'caps', client_name, 'mds', 'allow rwp', 'mon', 'allow r',
|
|
'osd',
|
|
'allow rw pool={0},allow rw pool={1}'.format(
|
|
self.fs.get_data_pool_names()[0],
|
|
self.fs.get_data_pool_names()[1],
|
|
))
|
|
self.mount_a.mount_wait()
|
|
self.mount_a.setfattr("layoutfile", "ceph.file.layout.pool",
|
|
new_pool_name)
|
|
self.mount_a.setfattr("layoutdir", "ceph.dir.layout.pool",
|
|
new_pool_name)
|
|
self.mount_a.umount_wait()
|
|
|
|
def tearDown(self):
|
|
self.get_ceph_cmd_result(
|
|
'auth', 'caps', "client.{0}".format(self.mount_a.client_id),
|
|
'mds', 'allow', 'mon', 'allow r', 'osd',
|
|
'allow rw pool={0}'.format(self.fs.get_data_pool_names()[0]))
|
|
super(TestPoolPerm, self).tearDown()
|
|
|