mirror of
https://github.com/ceph/ceph
synced 2024-12-18 01:16:55 +00:00
ff8d6a730b
the commit d406f228 in gperf implements a c11 feature used by a recent change in rocksdb: 16e03882, which uses aligned_alloc(). and 16e03882 in rocksdb was merged after v5.7 was tagged, while 16e03882 in gperf was merged after v2.6.1 was tagged. because aligned_alloc() is not implemented by tcmalloc until the not-yet-released 2.6.2, if we call aligned_alloc() in an application linked against tcmalloc, what gets called will be the glibc's aligned_alloc(). but if we free() the memory chunk allocated by aligned_alloc(), the tcmalloc's implementation kicks in, then InvalidFree() is called, because the memory chunk being freed was allocated by tcmalloc. in short, "mixing allocators", quote from Dan Mick. in rocksdb, aligned_alloc() is used if _ISOC11_SOURCE is defined, this makes sense, because aligned_alloc() is a C11 function. we could avoid using it by not defining _ISOC11_SOURCE. but as long as _GNU_SOURCE is defined, glibc defines _ISOC11_SOURCE. and libstdc++ requires _GNU_SOURCE, because it uses a fair amount of GNU extensions. Fixes: http://tracker.ceph.com/issues/21422 Signed-off-by: Kefu Chai <kchai@redhat.com>
69 lines
2.6 KiB
CMake
69 lines
2.6 KiB
CMake
function(do_build_rocksdb)
|
|
set(ROCKSDB_CMAKE_ARGS -DCMAKE_POSITION_INDEPENDENT_CODE=ON)
|
|
|
|
if(ALLOCATOR STREQUAL "jemalloc")
|
|
list(APPEND ROCKSDB_CMAKE_ARGS -DWITH_JEMALLOC=ON)
|
|
endif()
|
|
|
|
if (WITH_CCACHE AND CCACHE_FOUND)
|
|
list(APPEND ROCKSDB_CMAKE_ARGS -DCMAKE_CXX_COMPILER=ccache)
|
|
list(APPEND ROCKSDB_CMAKE_ARGS -DCMAKE_CXX_COMPILER_ARG1=${CMAKE_CXX_COMPILER})
|
|
else()
|
|
list(APPEND ROCKSDB_CMAKE_ARGS -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER})
|
|
endif()
|
|
|
|
list(APPEND ROCKSDB_CMAKE_ARGS -DPORTABLE=ON)
|
|
list(APPEND ROCKSDB_CMAKE_ARGS -DCMAKE_AR=${CMAKE_AR})
|
|
list(APPEND ROCKSDB_CMAKE_ARGS -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE})
|
|
|
|
if (CMAKE_CXX_COMPILER_ID STREQUAL Clang)
|
|
list(APPEND ROCKSDB_CMAKE_ARGS -DFAIL_ON_WARNINGS=OFF)
|
|
endif()
|
|
|
|
# we use an external project and copy the sources to bin directory to ensure
|
|
# that object files are built outside of the source tree.
|
|
include(ExternalProject)
|
|
ExternalProject_Add(rocksdb_ext
|
|
SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/rocksdb
|
|
CMAKE_ARGS ${ROCKSDB_CMAKE_ARGS}
|
|
BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/rocksdb
|
|
BUILD_COMMAND $(MAKE) rocksdb
|
|
INSTALL_COMMAND "true")
|
|
|
|
# force rocksdb make to be called on each time
|
|
ExternalProject_Add_Step(rocksdb_ext forcebuild
|
|
DEPENDEES configure
|
|
DEPENDERS build
|
|
COMMAND "true"
|
|
ALWAYS 1)
|
|
endfunction()
|
|
|
|
macro(build_rocksdb)
|
|
do_build_rocksdb()
|
|
add_library(rocksdb STATIC IMPORTED)
|
|
add_dependencies(rocksdb rocksdb_ext)
|
|
set_property(TARGET rocksdb PROPERTY IMPORTED_LOCATION "${CMAKE_CURRENT_BINARY_DIR}/rocksdb/librocksdb.a")
|
|
set(ROCKSDB_INCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/rocksdb/include)
|
|
set(ROCKSDB_LIBRARIES rocksdb)
|
|
foreach(ver "MAJOR" "MINOR" "PATCH")
|
|
file(STRINGS "${ROCKSDB_INCLUDE_DIR}/rocksdb/version.h" ROCKSDB_VER_${ver}_LINE
|
|
REGEX "^#define[ \t]+ROCKSDB_${ver}[ \t]+[0-9]+$")
|
|
string(REGEX REPLACE "^#define[ \t]+ROCKSDB_${ver}[ \t]+([0-9]+)$"
|
|
"\\1" ROCKSDB_VERSION_${ver} "${ROCKSDB_VER_${ver}_LINE}")
|
|
unset(ROCKDB_VER_${ver}_LINE)
|
|
endforeach()
|
|
set(ROCKSDB_VERSION_STRING
|
|
"${ROCKSDB_VERSION_MAJOR}.${ROCKSDB_VERSION_MINOR}.${ROCKSDB_VERSION_PATCH}")
|
|
|
|
if(ALLOCATOR MATCHES "tcmalloc(_minimal)?")
|
|
# see http://tracker.ceph.com/issues/21422
|
|
if(ROCKSDB_VERSION_STRING VERSION_GREATER 5.7 AND
|
|
TCMALLOC_VERSION_STRING VERSION_GREATER 2.5 AND
|
|
TCMALLOC_VERSION_STRING VERSION_LESS 2.6.2)
|
|
message(SEND_ERROR
|
|
"Incompatible tcmalloc v${TCMALLOC_VERSION_STRING} and rocksdb v${ROCKSDB_VERSION_STRING}, "
|
|
"please install gperf-tools 2.5 or > 2.6.2")
|
|
endif()
|
|
endif()
|
|
endmacro()
|