ceph/src/librados-config.cc
Kefu Chai cb1cda9671 common,test: g_ceph_context->put() upon return
prior to this change, global_init() could create a new CephContext
and assign it to g_ceph_context. it's our responsibilty to release
the CephContext explicitly using cct->put() before the application
quits. but sometimes, we fail to do so.

in this change, global_init() will return an intrusive_ptr<CephContext>,
which calls `g_ceph_context->put()` in its dtor. this ensures that
the CephContext is always destroyed before main() returns. so the
log is flushed before _log_exp_length is destroyed.

there are two cases where global_pre_init() is called directly.
- ceph_conf.cc: g_ceph_context->put() will be called by an intrusive_ptr<>
  deleter.
- rgw_main.cc: global_init() is called later on on the success code
  path, so it will be taken care of.

Fixes: http://tracker.ceph.com/issues/17762
Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-11-24 22:38:28 +08:00

80 lines
1.8 KiB
C++

// -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-
// vim: ts=8 sw=2 smarttab
/*
* Ceph - scalable distributed file system
*
* Copyright (C) 2004-2006 Sage Weil <sage@newdream.net>
*
* This is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public
* License version 2, as published by the Free Software
* Foundation. See file COPYING.
*
*/
#include "common/config.h"
#include "common/ceph_argparse.h"
#include "global/global_init.h"
#include "global/global_context.h"
#include "include/rados/librados.h"
void usage()
{
cout << "usage: librados-config [option]\n"
<< "where options are:\n"
<< " --version library version\n"
<< " --vernum library version code\n";
}
void usage_exit()
{
usage();
exit(1);
}
int main(int argc, const char **argv)
{
vector<const char*> args;
argv_to_vec(argc, argv, args);
env_to_vec(args);
bool opt_version = false;
bool opt_vernum = false;
auto cct = global_init(NULL, args, CEPH_ENTITY_TYPE_CLIENT,
CODE_ENVIRONMENT_UTILITY,
CINIT_FLAG_NO_DEFAULT_CONFIG_FILE);
common_init_finish(g_ceph_context);
for (std::vector<const char*>::iterator i = args.begin();
i != args.end(); ) {
if (strcmp(*i, "--") == 0) {
break;
}
else if (strcmp(*i, "--version") == 0) {
opt_version = true;
i = args.erase(i);
}
else if (strcmp(*i, "--vernum") == 0) {
opt_vernum = true;
i = args.erase(i);
}
else
++i;
}
if (!opt_version && !opt_vernum)
usage_exit();
if (opt_version) {
int maj, min, ext;
rados_version(&maj, &min, &ext);
cout << maj << "." << min << "." << ext << std::endl;
} else if (opt_vernum) {
cout << hex << LIBRADOS_VERSION_CODE << dec << std::endl;
}
return 0;
}