mirror of
https://github.com/ceph/ceph
synced 2024-12-24 12:24:19 +00:00
13ae13a906
Since snapshots never change, it's safe to read from replicas for them. A common use for this would be reading from a parent snapshot shared by many clones. Convert LibrbdWriteback and AioRead to use the ObjectOperation api so we can set flags. Fortunately the external wrapper holds no data, so its lifecycle doesn't need to be managed. Include a simple workunit that sets the flags in various combinations and looks for their presence in the logs from 'rbd export'. Fixes: #3064 Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
61 lines
1.5 KiB
Bash
Executable File
61 lines
1.5 KiB
Bash
Executable File
#!/bin/bash -ex
|
|
|
|
# create a snapshot, then export it and check that setting read flags works
|
|
# by looking at --debug-ms output
|
|
|
|
function clean_up {
|
|
rm -f test.log || true
|
|
rbd snap remove test@snap || true
|
|
rbd rm test || true
|
|
}
|
|
|
|
function test_read_flags {
|
|
local IMAGE=$1
|
|
local SET_BALANCED=$2
|
|
local SET_LOCALIZED=$3
|
|
local EXPECT_BALANCED=$4
|
|
local EXPECT_LOCALIZED=$5
|
|
|
|
local EXTRA_ARGS="--log-file test.log --debug-ms 1 --no-log-to-stderr"
|
|
if [ "$SET_BALANCED" = 'y' ]; then
|
|
EXTRA_ARGS="$EXTRA_ARGS --rbd-balance-snap-reads"
|
|
elif [ "$SET_LOCALIZED" = 'y' ]; then
|
|
EXTRA_ARGS="$EXTRA_ARGS --rbd-localize-snap-reads"
|
|
fi
|
|
|
|
rbd export $IMAGE - $EXTRA_ARGS > /dev/null
|
|
if [ "$EXPECT_BALANCED" = 'y' ]; then
|
|
grep -q balance_reads test.log
|
|
else
|
|
grep -L balance_reads test.log | grep -q test.log
|
|
fi
|
|
if [ "$EXPECT_LOCALIZED" = 'y' ]; then
|
|
grep -q localize_reads test.log
|
|
else
|
|
grep -L localize_reads test.log | grep -q test.log
|
|
fi
|
|
rm -f test.log
|
|
|
|
}
|
|
|
|
clean_up
|
|
|
|
trap clean_up INT TERM EXIT
|
|
|
|
rbd create -s 10 test
|
|
rbd snap create test@snap
|
|
|
|
# export from non snapshot with or without settings should not have flags
|
|
test_read_flags test n n n n
|
|
test_read_flags test y y n n
|
|
|
|
# export from snapshot should have read flags in log if they are set
|
|
test_read_flags test@snap n n n n
|
|
test_read_flags test@snap y n y n
|
|
test_read_flags test@snap n y n y
|
|
|
|
# balanced_reads happens to take priority over localize_reads
|
|
test_read_flags test@snap y y y n
|
|
|
|
echo OK
|