import json
import logging
import time
from .mgr_test_case import MgrTestCase
from contextlib import contextmanager
log = logging.getLogger(__name__)
class TestProgress(MgrTestCase):
POOL = "progress_data"
# How long we expect to wait at most between taking an OSD out
# and seeing the progress event pop up.
EVENT_CREATION_PERIOD = 60
WRITE_PERIOD = 30
# Generous period for OSD recovery, should be same order of magnitude
# to how long it took to write the data to begin with
RECOVERY_PERIOD = WRITE_PERIOD * 4
def _get_progress(self):
out = self.mgr_cluster.mon_manager.raw_cluster_cmd("progress", "json")
return json.loads(out)
def _all_events(self):
"""
To avoid racing on completion, we almost always want to look
for events in the total list of active and complete, so
munge them into a single list.
"""
p = self._get_progress()
log.info(json.dumps(p, indent=2))
return p['events'] + p['completed']
def _events_in_progress(self):
"""
this function returns all events that are in progress
"""
p = self._get_progress()
log.info(json.dumps(p, indent=2))
return p['events']
def _completed_events(self):
"""
This function returns all events that are completed
"""
p = self._get_progress()
log.info(json.dumps(p, indent=2))
return p['completed']
def is_osd_marked_out(self, ev):
return ev['message'].endswith('marked out')
def is_osd_marked_in(self, ev):
return ev['message'].endswith('marked in')
def _get_osd_in_out_events(self, marked='both'):
"""
Return the event that deals with OSDs being
marked in, out or both
"""
marked_in_events = []
marked_out_events = []
events_in_progress = self._events_in_progress()
for ev in events_in_progress:
if self.is_osd_marked_out(ev):
marked_out_events.append(ev)
elif self.is_osd_marked_in(ev):
marked_in_events.append(ev)
if marked == 'both':
return [marked_in_events] + [marked_out_events]
elif marked == 'in':
return marked_in_events
else:
return marked_out_events
def _osd_in_out_events_count(self, marked='both'):
"""
Count the number of on going recovery events that deals with
OSDs being marked in, out or both.
"""
events_in_progress = self._events_in_progress()
marked_in_count = 0
marked_out_count = 0
for ev in events_in_progress:
if self.is_osd_marked_out(ev):
marked_out_count += 1
elif self.is_osd_marked_in(ev):
marked_in_count += 1
if marked == 'both':
return marked_in_count + marked_out_count
elif marked == 'in':
return marked_in_count
else:
return marked_out_count
def _setup_pool(self, size=None):
self.mgr_cluster.mon_manager.create_pool(self.POOL)
if size is not None:
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'pool', 'set', self.POOL, 'size', str(size))
def _osd_in_out_completed_events_count(self, marked='both'):
"""
Count the number of completed recovery events that deals with
OSDs being marked in, out, or both.
"""
completed_events = self._completed_events()
marked_in_count = 0
marked_out_count = 0
for ev in completed_events:
if self.is_osd_marked_out(ev):
marked_out_count += 1
elif self.is_osd_marked_in(ev):
marked_in_count += 1
if marked == 'both':
return marked_in_count + marked_out_count
elif marked == 'in':
return marked_in_count
else:
return marked_out_count
def _write_some_data(self, t):
"""
To adapt to test systems of varying performance, we write
data for a defined time period, rather than to a defined
capacity. This will hopefully result in a similar timescale
for PG recovery after an OSD failure.
"""
args = [
"rados", "-p", self.POOL, "bench", str(t), "write", "-t", "16"]
self.mgr_cluster.admin_remote.run(args=args, wait=True)
def _osd_count(self):
osd_map = self.mgr_cluster.mon_manager.get_osd_dump_json()
return len(osd_map['osds'])
@contextmanager
def recovery_backfill_disabled(self):
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'set', 'nobackfill')
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'set', 'norecover')
yield
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'unset', 'nobackfill')
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'unset', 'norecover')
def setUp(self):
super(TestProgress, self).setUp()
# Ensure we have at least four OSDs
if self._osd_count() < 4:
self.skipTest("Not enough OSDS!")
# Remove any filesystems so that we can remove their pools
if self.mds_cluster:
self.mds_cluster.mds_stop()
self.mds_cluster.mds_fail()
self.mds_cluster.delete_all_filesystems()
# Remove all other pools
for pool in self.mgr_cluster.mon_manager.get_osd_dump_json()['pools']:
self.mgr_cluster.mon_manager.remove_pool(pool['pool_name'])
self._load_module("progress")
self.mgr_cluster.mon_manager.raw_cluster_cmd('progress', 'clear')
def _simulate_failure(self, osd_ids=None):
"""
Common lead-in to several tests: get some data in the cluster,
then mark an OSD out to trigger the start of a progress event.
Return the JSON representation of the failure event.
"""
if osd_ids is None:
osd_ids = [0]
self._setup_pool()
self._write_some_data(self.WRITE_PERIOD)
with self.recovery_backfill_disabled():
for osd_id in osd_ids:
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'out', str(osd_id))
# Wait for a progress event to pop up
self.wait_until_equal(lambda: self._osd_in_out_events_count('out'), 1,
timeout=self.EVENT_CREATION_PERIOD,
period=1)
ev = self._get_osd_in_out_events('out')[0]
log.info(json.dumps(ev, indent=1))
self.assertIn("Rebalancing after osd.0 marked out", ev['message'])
return ev
def _simulate_back_in(self, osd_ids, initial_event):
for osd_id in osd_ids:
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'in', str(osd_id))
# First Event should complete promptly
self.wait_until_true(lambda: self._is_complete(initial_event['id']),
timeout=self.RECOVERY_PERIOD)
with self.recovery_backfill_disabled():
try:
# Wait for progress event marked in to pop up
self.wait_until_equal(lambda: self._osd_in_out_events_count('in'), 1,
timeout=self.EVENT_CREATION_PERIOD,
period=1)
except RuntimeError as ex:
if not "Timed out after" in str(ex):
raise ex
log.info("There was no PGs affected by osd being marked in")
return None
new_event = self._get_osd_in_out_events('in')[0]
return new_event
def _no_events_anywhere(self):
"""
Whether there are any live or completed events
"""
p = self._get_progress()
total_events = len(p['events']) + len(p['completed'])
return total_events == 0
def _is_quiet(self):
"""
Whether any progress events are live.
"""
return len(self._get_progress()['events']) == 0
def _is_complete(self, ev_id):
progress = self._get_progress()
live_ids = [ev['id'] for ev in progress['events']]
complete_ids = [ev['id'] for ev in progress['completed']]
if ev_id in complete_ids:
assert ev_id not in live_ids
return True
else:
assert ev_id in live_ids
return False
def _is_inprogress_or_complete(self, ev_id):
for ev in self._events_in_progress():
if ev['id'] == ev_id:
return ev['progress'] > 0
# check if the event completed
return self._is_complete(ev_id)
def tearDown(self):
if self.POOL in self.mgr_cluster.mon_manager.pools:
self.mgr_cluster.mon_manager.remove_pool(self.POOL)
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'unset', 'nobackfill')
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'unset', 'norecover')
osd_map = self.mgr_cluster.mon_manager.get_osd_dump_json()
for osd in osd_map['osds']:
if osd['weight'] == 0.0:
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'in', str(osd['osd']))
super(TestProgress, self).tearDown()
def test_osd_healthy_recovery(self):
"""
The simple recovery case: an OSD goes down, its PGs get a new
placement, and we wait for the PG to get healthy in its new
locations.
"""
ev = self._simulate_failure()
# Wait for progress event to ultimately reach completion
self.wait_until_true(lambda: self._is_complete(ev['id']),
timeout=self.RECOVERY_PERIOD)
self.assertEqual(self._osd_in_out_events_count(), 0)
def test_pool_removal(self):
"""
That a pool removed during OSD recovery causes the
progress event to be correctly marked complete once there
is no more data to move.
"""
ev = self._simulate_failure()
self.mgr_cluster.mon_manager.remove_pool(self.POOL)
# Event should complete promptly
self.wait_until_true(lambda: self._is_complete(ev['id']),
timeout=self.RECOVERY_PERIOD)
self.assertEqual(self._osd_in_out_events_count(), 0)
def test_osd_came_back(self):
"""
When a recovery is underway, but then the out OSD
comes back in, such that recovery is no longer necessary.
It should create another event for when osd is marked in
and cancel the one that is still ongoing.
"""
ev1 = self._simulate_failure()
ev2 = self._simulate_back_in([0], ev1)
if ev2 is not None:
# Wait for progress event to ultimately complete
self.wait_until_true(lambda: self._is_complete(ev2['id']),
timeout=self.RECOVERY_PERIOD)
self.assertEqual(self._osd_in_out_events_count(), 0)
def test_turn_off_module(self):
"""
When the the module is turned off, there should not
be any on going events or completed events.
Also module should not accept any kind of Remote Event
coming in from other module, however, once it is turned
back, on creating an event should be working as it is.
"""
pool_size = 3
self._setup_pool(size=pool_size)
self._write_some_data(self.WRITE_PERIOD)
self.mgr_cluster.mon_manager.raw_cluster_cmd("progress", "off")
with self.recovery_backfill_disabled():
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'out', '0')
time.sleep(self.EVENT_CREATION_PERIOD/2)
with self.recovery_backfill_disabled():
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'in', '0')
time.sleep(self.EVENT_CREATION_PERIOD/2)
self.assertTrue(self._no_events_anywhere())
self.mgr_cluster.mon_manager.raw_cluster_cmd("progress", "on")
self._write_some_data(self.WRITE_PERIOD)
with self.recovery_backfill_disabled():
self.mgr_cluster.mon_manager.raw_cluster_cmd(
'osd', 'out', '0')
# Wait for a progress event to pop up
self.wait_until_equal(lambda: self._osd_in_out_events_count('out'), 1,
timeout=self.EVENT_CREATION_PERIOD,
period=1)
ev1 = self._get_osd_in_out_events('out')[0]
log.info(json.dumps(ev1, indent=1))
self.wait_until_true(lambda: self._is_complete(ev1['id']),
check_fn=lambda: self._is_inprogress_or_complete(ev1['id']),
timeout=self.RECOVERY_PERIOD)
self.assertTrue(self._is_quiet())