Commit Graph

132028 Commits

Author SHA1 Message Date
Xiubo Li
a6e83d8dec ceph-fuse: return EINVAL if get invalid fino instead of assert
All the snap ids of the finos returned to libfuse from libcephfs
will be recorded in the map of 'stag_snap_map', and will never be
erased before unmounting. So if libfuse passes invalid fino the
ceph-fuse should return EINVAL errno instead of crash itself.

Fixes: https://tracker.ceph.com/issues/54653
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2022-06-15 10:29:38 +08:00
Xiubo Li
2349083a9d ceph-fuse: reserve stag number 1 for snapdirs
There have two stags will be reserved, 0 for CEPH_NOSNAP and 1 for
CPEH_SNAPDIR.

This will always make sure that for the nonsnap and snapdir inode
numbers to be consistent for all the ceph-fuse mounts.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2022-06-15 10:29:38 +08:00
Xiubo Li
28d17ff81a mds-client: make the fake inos option unchangeable in runtime
If the flags is empty then in option.h in can_update_at_runtime()
it will return true. That means this opetion could be changed in
runtime, which is buggy. Because if this is false, ceph-fuse will
use its own fake inos instead of libcephfs'. If this is changed
during runtime, we will hit inos dosn't exist assert bugs.

Fixes: https://tracker.ceph.com/issues/54653
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2022-06-15 10:29:38 +08:00
Anthony D'Atri
bcc078c8bf
Merge pull request #46629 from anthonyeleven/anthonyeleven/46195_formatting
doc/man/8: Tweak formatting and wording in ceph.rst
2022-06-14 18:03:05 -07:00
Zac Dover
f5cfc22445 doc/dev: s/master/main/ in basic workflow
This PR changes "master" to "main" in the
basic_workflow.rst file. I have even changed
"master" to "main" in some terminal output from
several years ago. This isn't historically ac-
curate, of course, but my hope is that this change
will prevent someone in the future from being con-
fused about why an antiquated branch name is ref-
erred to.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-06-15 08:15:33 +10:00
Yuri Weinstein
35bf1ebb7a
Merge pull request #46362 from pdvian/wip-logm-mgrstat
mon/LogMonitor, MgrStat: Report logm and mgrstat committed version

Reviewed-by: Laura Flores <lflores@redhat.com>
2022-06-14 13:43:42 -07:00
Yuri Weinstein
f16e311bcc
Merge pull request #46279 from jianwei1216/osd-peering-complete-log-patch
osd: add log for pg peering and activiting complete

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2022-06-14 13:43:10 -07:00
Kefu Chai
88efdbe268 crimson/osd: use seastar::deferred_stop()
trade `seastar::defer()` for `seastar::deferred_stop()` to
simplify the code a little bit.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-06-15 00:32:22 +08:00
Zack Cerza
77b3080808 cephadm: Make sysctl conf writing idempotent
By checking the system's actual settings against our desired settings
before writing out the config file.

Fixes: https://tracker.ceph.com/issues/56026

Signed-off-by: Zack Cerza <zack@redhat.com>
2022-06-14 10:28:08 -06:00
Yuri Weinstein
69089202d8
Merge pull request #46509 from aclamk/wip-pglog-test-leak
test/pglog: Fix memory leak

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-06-14 08:27:57 -07:00
Yuri Weinstein
789e61cd5f
Merge pull request #46438 from pdvian/wip-scrub-starts
osd/scrub: Reintroduce scrub starts message

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2022-06-14 08:27:05 -07:00
Yuri Weinstein
8c9bf42521
Merge pull request #46428 from sseshasa/wip-fix-55773-have-pending
mon/OSDMonitor: Ensure kvmon() is writeable before handling "osd new" cmd

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-06-14 08:26:23 -07:00
Yuri Weinstein
6d95d4383b
Merge pull request #45984 from trociny/wip-51835
mgr: relax "pending_service_map.epoch > service_map.epoch" assert

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-06-14 08:25:25 -07:00
Adam King
390e2a0856
Merge pull request #46285 from s0nea/config-fqdn-active
mgr/cephadm: try to get FQDN for active instance

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Paul Cuzner <pcuzner@redhat.com>
2022-06-14 10:01:08 -04:00
Adam King
06f265d057
Merge pull request #46506 from asm0deuz/mod_iscsi_systemd
Modify how Iscsi tcmu-runner container is started within systemd

Reviewed-by: Adam King <adking@redhat.com>
2022-06-14 09:56:49 -04:00
Adam King
35aebc97d0
Merge pull request #44894 from guits/add_dockerfile_keepalived
cephadm: change default keepalived/haproxy container images

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
2022-06-14 09:52:53 -04:00
Adam King
50a4355d72
Merge pull request #46588 from guits/cluster-fsid-common
ceph-volume: make is_valid() optional

Reviewed-by: Teoman ONAY <tonay@redhat.com>
2022-06-14 09:48:53 -04:00
Deepika Upadhyay
a151b5065b
Merge pull request #46586 from SUSE/wip-suse-default-jaeger-off
ceph.spec.in: turn jaeger off by default for SUSE distros

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-06-14 18:16:27 +05:30
Ernesto Puerta
9a527b3f98
Merge pull request #46370 from rhcs-dashboard/stop-poll-page-inactive
mgr/dashboard: stop polling when page is not visible

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2022-06-14 13:23:59 +02:00
Ernesto Puerta
a84541439c
Merge pull request #46475 from rhcs-dashboard/01-hosts-failure
mgr/dashboard: fix drain e2e failure 

Reviewed-by: Sarthak Gupta <sarthak.dev.0702@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2022-06-14 13:21:26 +02:00
Venky Shankar
80b2776c62
Merge pull request #44567 from lxbsz/client_reply
client: do nothing when get a stale reply

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2022-06-14 15:16:27 +05:30
Yuval Lifshitz
e2aa88eddb
Merge pull request #46313 from zenomri/wip-omri-tracing-lua
rgw: add SetAttribute and AddEvent functions for TraceMetaTable in Lua

Reviewed-by: yuvalif
2022-06-14 12:22:21 +03:00
Ernesto Puerta
8bba174615
Merge pull request #46407 from melissa-kun-li/disable-create-image
mgr/dashboard: add rbd status endpoint and error page

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-06-14 11:00:21 +02:00
Nikhilkumar Shelke
dc4b0ee405 qa: subvolume ls command crashes if groupname as '_nogroup'
If --group_name=_nogroup is provided in the command then
throw error permission denied as it is internal group of ceph fs.

Fixes: https://tracker.ceph.com/issues/55759
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-06-14 12:34:51 +05:30
Nikhilkumar Shelke
acf1337334 mgr/volumes: subvolume ls command crashes if groupname as '_nogroup'
If --group_name=_nogroup is provided in the command then
throw error permission denied as it is internal group of ceph fs.

Fixes: https://tracker.ceph.com/issues/55759
Signed-off-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-06-14 12:17:23 +05:30
zdover23
6944600e6a
Merge pull request #46651 from zdover23/wip-doc-2022-06-13-dev-guide-essentials-master-to-main
doc/dev: s/master/main/ essentials.rst dev guide

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-06-14 16:27:14 +10:00
Xiubo Li
72194627c1 qa: wait rank 0 to become up:active state before mounting fuse client
When setting the ec pool to the layout the filesystem may not be
ready, so when mounting a fuse client it will fail. To fix this we
need to wait at least the rank 0 to be in up:active state.

Fixes: https://tracker.ceph.com/issues/55824
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2022-06-14 09:20:45 +08:00
Anthony D'Atri
bb5f95a15a
Merge pull request #46659 from anthonyeleven/anthonyeleven-46637-followup
doc/start: Polish network section of hardware-recommendations.rst
2022-06-13 16:58:08 -07:00
Anthony D'Atri
2eb173fef9 doc/start: Polish network section of hardware-recommendations.rst
Harmonize network throughput notation, minor tweaks to wording.
Followup to #46637

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-06-13 16:13:53 -07:00
Zac Dover
728b8f2674 doc/dev: s/master/main/ essentials.rst dev guide
This PR changes all reference to the "master" branch
to references to the "main" branch (because we renamed
"master" to main", and the docs now need to reflect that).

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-06-14 07:48:46 +10:00
zdover23
0eca78faef
Merge pull request #46637 from zdover23/wip-doc-2022-06-12-start-intro-networks-rewrite
doc/start: rewrite hardware-recs networks section

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-06-14 07:11:12 +10:00
Casey Bodley
6f765e25ab
Merge pull request #43597 from pritha-srivastava/wip-rgw-sts-role-multisite
rgw multisite: replicate metadata for iam roles

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-06-13 12:04:12 -04:00
Yuval Lifshitz
9e290f4012
Merge pull request #46568 from yuvalif/wip-yuval-lua-counters
rgw/lua: add counters to background table

Reviewed-by: mattbenjamin
Reviewed-by: Matan-b
2022-06-13 18:18:56 +03:00
Nizamudeen A
dcf0445153 mgr/dashboard: fix drain e2e failure
Cypress sometimes fail to register the click and that causes the
deselect/select to not happen properly. Deselecting the row immediately
after performing the action makes it pass from cypress.

Fixes: https://tracker.ceph.com/issues/55741
Signed-off-by: Nizamudeen A <nia@redhat.com>
2022-06-13 14:00:53 +05:30
Xiubo Li
1bbe6bbc29 client: do nothing when get a stale reply
In theory when we get a stale reply from incorrect session, that
means it's buggy in MDS. Anyway we should discard it without doing
anything.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2022-06-13 16:19:48 +08:00
Venky Shankar
2667314621
Merge pull request #44655 from lxbsz/wip-53741
mds: clear MDCache::rejoin_*_q queues before recovering file inodes 

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Nikhilkumar Shelke <nshelke@redhat.com>
2022-06-13 13:40:04 +05:30
Venky Shankar
27f4729256
Merge pull request #45556 from mchangir/qa-add-subvolume-option-flavors
qa: add subvolume option flavors

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
2022-06-13 12:29:43 +05:30
Venky Shankar
f7bc95c2f7
Merge pull request #44347 from kotreshhr/subvolumegroup-quotas
mgr/volumes: subvolumegroup quotas

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2022-06-13 12:26:59 +05:30
Venky Shankar
67371c1ab4
Merge pull request #46332 from lxbsz/qa-snap
qa: enlarge the tag number and test more for the snapshot

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-06-13 12:25:44 +05:30
Omri Zeneva
6e43859106 doc: add explanation about the new two functions and example
Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
2022-06-13 02:05:11 -04:00
Omri Zeneva
61054347f3 test: add unit tests
- added trace initialization
- opentelemetry linking when needed
- conditional ASSERT on SetBadAttribute, when we don't have opentelemetry (tracing sdk), we expect different result from the execute function.

Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
2022-06-13 02:05:11 -04:00
Omri Zeneva
923f4542cf rgw: add functionality of SetAttribute and AddEvent method in postRequest context
opentelemetry supports mainly string, int64, double and boolean for values of trace's Attributes,
so we should validate those types and static cast to the proper type, which is different than Lua types

SetAttribute Closure will be returned to lua only if the request's trace is real and not noop span or even null like what happens in preRequest Context

AddEvent method comes to give us the ability to record an event. the event can be a single string that represents the event, or event name and key-value pairs.

Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
2022-06-13 02:05:11 -04:00
dparmar18
269567d005 qa/cephfs: fix read_debug_file() return value and a pep8 violation
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2022-06-13 11:33:43 +05:30
dparmar18
0aca27d2fc qa/cephfs: fallback to older way of get_op_read_count
Fixes: https://tracker.ceph.com/issues/55538

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2022-06-13 11:33:43 +05:30
Zac Dover
778d3c0b59 doc/start: rewrite hardware-recs networks section
This rewrites the first two-thirds of the "Networks"
section of the Hardware Recommendations page in the
Intro to Ceph document. I have tried to divide the
techincal content in this section into subsections
that foreground the various subjects covered.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-06-13 14:34:36 +10:00
Anthony D'Atri
6c46e1d842
Merge pull request #46634 from Huber-ming/pr_target_main
SubmittingPatches.rst: PRs should target "main"
2022-06-12 20:47:48 -07:00
Anthony D'Atri
052877aaef
Merge pull request #46583 from zdover23/wip-doc-2022-06-08-intro-hardware-recs-osd-acro-fix
doc/start: make OSD and MDS structures parallel
2022-06-12 20:32:05 -07:00
Anthony D'Atri
d4ef619a8d
Merge pull request #46633 from zdover23/wip-doc-2022-06-12-start-intro-crush-para-fix
doc/start: rewrite CRUSH para
2022-06-12 20:26:02 -07:00
Huber-ming
a892525c71 SubmittingPatches.rst: PRs should target "main"
Signed-off-by: Huber-ming <zhangsm01@inspur.com>
2022-06-13 09:38:40 +08:00
Zac Dover
4f6edb92b9 doc/start: make OSD and MDS structures parallel
This PR makes the "Ceph OSDs" and "MDSs" bullet points
parallel by naming "object storage daemon" before referring
to the (admittedly more common and colloquial, but surely
unknown to people who genuinely require a document called
'Intro') acronym "OSD".

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-06-13 10:12:57 +10:00