Give users a clue when cache pools are enabled but the hit_set is not
configured. Note that technically this will work, but not well, so for
now let's just steer them away.
Signed-off-by: Sage Weil <sage@redhat.com>
If there is no hit set for a PG, blindly evict objects. This avoids an
assert(hit_set) in agent_estimate_atime_temp().
Fixes: #8982
Signed-off-by: Sage Weil <sage@redhat.com>
It is probably not a good idea to try to run the tiering agent without a
hit_set to inform its actions, but it is technically possible. For
example, one could simply blindly evict when we reach the full point.
However, this doesn't work because the agent mode is guarded by a hit_set
check, even though agent_setup() is not. Fix that.
Signed-off-by: Sage Weil <sage@redhat.com>
Newer versions of json.tool remove the trailing ' ' after the comma. Add
it back in with sed so that the .t works on both old and new versions, and
so that we don't have to remove the trailing spaces from all of the test
cases.
Backport: firefly
Fixes: #8920
Signed-off-by: Sage Weil <sage@redhat.com>
Fixes: #8586
This fixes error handling, in accordance with commit 6af5a537 that fixed
the same issue for the S3 case.
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
To get back to the reformatting procedure that otherwise
occurs during MDLog::open, introduce an MDLog::reopen call
that MDS can use in the standbyreplay->standby transition
for the special case where the journal is old.
Fixes: #8869
Signed-off-by: John Spray <john.spray@redhat.com>
* Make boot_start private.
* Define boot stages in enum, replace int with type.
* Merge steps 0 and 1, 0 always fell through to 1.
* starting_done was only ever reached by a fall through
from the previous step, so call it directly from there.
Signed-off-by: John Spray <john.spray@redhat.com>
Refactor to:
* have somewhere to put some logic for doing
background recovery in future.
* trim a few lines from the oversized MDCache.cc
whereever we can.
Signed-off-by: John Spray <john.spray@redhat.com>
A bit of colission from spec changes for the rhel7/ceph-common
changes and alfredo's pull request for wip-die-ceph-mkcephfs.
Signed-off-by: Sandon Van Ness <sandon@inktank.com>
(cherry picked from commit 1526546ddc)
A bit of colission from spec changes for the rhel7/ceph-common
changes and alfredo's pull request for wip-die-ceph-mkcephfs.
Signed-off-by: Sandon Van Ness <sandon@inktank.com>
This should ensure that we don't hit this limit on all but the very biggest
clusters. We seen it hit on a ~500 OSD dumpling cluster.
Backport: firefly, dumpling
Signed-off-by: Sage Weil <sage@redhat.com>
There were two problems here:
* write_pos was modified through an undump/dump cycle,
because it was probed during recovery.
* stream format was being forgotten.
Signed-off-by: John Spray <john.spray@redhat.com>
Higher the clone probability to 8% and lower the probability of flatten
to 2%. This should give us longer parent chaines (before this we would
usually have one parent and even then only for a few ops time).
Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
Truncate base images after they have been cloned from to cover more
code paths and make sure that clients look at snapshot parent_overlap
(i.e. parent_overlap of the base image at the time the snapshot was
taken) and not that of the base image (i.e. parent_overlap of the base
image as of now).
Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
The C++ version of rbd_get_parent_info() allows passing NULL for parent
image name, image name and snapshot name out parameters. Make C API do
the same both for consistency and to make it easier to check whether
the image at hand has a parent or not.
Signed-off-by: Ilya Dryomov <ilya.dryomov@inktank.com>
Currently for pools with different rules, "ceph df" cannot report
right available space for them, respectively. For detail assisment
of the bug ,pls refer to bug report #8943
This patch fix this bug and make ceph df works correctlly.
Fixes Bug #8943
Signed-off-by: Xiaoxi Chen <xiaoxi.chen@intel.com>
Fix dup bh_write for TX state bh
Tested-by: Sage Weil <sage@redhat.com>
Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
Original changeset
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
