Commit Graph

134171 Commits

Author SHA1 Message Date
Venky Shankar
61f9c4501e
Merge pull request #48149 from batrick/i57586
tools: allow spaces in dentries for first-damage.sh

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-09-20 09:36:38 +05:30
Samuel Just
2e712c26d8
Merge pull request #48057 from athanatos/sjust/wip-io-hang
crimson/osd/client_request: use fresh tracking_events/handle instances on requeue

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-09-19 17:52:36 -07:00
Samuel Just
b23b1a4f12 crimson/osd/client_request: use fresh tracking_events/handle instances on requeue
See instance_handle_t explanation in client_request.h

Fixes: https://tracker.ceph.com/issues/57494
Fixes: https://tracker.ceph.com/issues/57495
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 21:04:14 +00:00
Samuel Just
a79e029a72
Merge pull request #48059 from athanatos/sjust/wip-57506
crimson: fix for pgs stuck in +wait along with some debug improvements

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-09-19 13:40:41 -07:00
Samuel Just
e811060b84
Merge pull request #48091 from rzarzynski/wip-crimson-pgadvmap-complete-in-order
crimson/osd: PGAdvanceMap ops complete in order

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:30:52 -07:00
Nizamudeen A
7ca84d65ca
Merge pull request #48134 from rhcs-dashboard/silence-fix
mgr/dashboard: use service call instead of form component

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2022-09-20 00:53:55 +05:30
Patrick Donnelly
acab0766e5
tools: allow spaces in dentries for first-damage.sh
Fixes: https://tracker.ceph.com/issues/57586
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-09-19 13:34:22 -04:00
Patrick Donnelly
4081f949b7
qa: test first damage with dentry containing spaces
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-09-19 13:34:19 -04:00
Samuel Just
ad87f822bd
Merge pull request #45369 from jyha200/wip-samplededup
ceph_dedup_tool: adding sample-dedup

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-09-19 10:32:19 -07:00
Pere Diaz Bou
a84620552a mgr/prometheus: expose num objects repaired in pool
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-09-19 18:03:56 +02:00
Adam King
12235e92e6
Merge pull request #41855 from p-se/compile-cephadm-1
cephadm: compile cephadm

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2022-09-19 11:48:51 -04:00
Yuri Weinstein
346a33aeb6
Merge pull request #47873 from pdvian/wip-log-last
mon/LogMonitor: Fix log last

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-09-19 08:36:45 -07:00
Yuri Weinstein
98f8424eea
Merge pull request #47852 from Matan-B/wip-matanb-radosmodel
test/osd/RadosModel: Improve error debugging

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2022-09-19 08:36:15 -07:00
Yuri Weinstein
af5b108776
Merge pull request #47841 from Matan-B/wip-matanb-rados-striper
SimpleRADOSStriper: Avoid moving bufferlists by using deque in read()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2022-09-19 08:35:31 -07:00
Yuri Weinstein
c10c8a5e89
Merge pull request #47774 from vumrao/wip-vumrao-57271
blk/KernelDevice: Modify the rotational and discard check log message

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2022-09-19 08:33:54 -07:00
Casey Bodley
f57c9b6bdd
Merge pull request #48156 from cbodley/wip-rgw-unused-throttles
rgw: remove unused AioThrottles in rgw_op.cc

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2022-09-19 11:31:25 -04:00
Adam King
fb3ad64e12
Merge pull request #46321 from jmolmo/issue_55605
mgr/rook: fix error when trying to get the list of nfs services

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2022-09-19 11:04:58 -04:00
Patrick Donnelly
acd395ace2
qa: output higher debugging for cephfs-journal-tool/cephfs-data-scan
Fixes: https://tracker.ceph.com/issues/57597
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-09-19 10:44:08 -04:00
Yuri Weinstein
00038e90fc
Merge pull request #46961 from tcoldrick-bb/balancer-weekday
mgr/balancer: Disallow 7 as {begin,end}_weekday and 2400 as {begin,end}_time

Reviewed-by: Laura Flores <lflores@redhat.com>
2022-09-19 07:15:29 -07:00
Yuri Weinstein
6875406e05
Merge pull request #46091 from pdvian/wip-bluestore-error
os/bluestore: Log error to stderr if fail to decode label

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2022-09-19 07:15:01 -07:00
Yuri Weinstein
4ceb1dce5a
Merge pull request #43791 from rzarzynski/wip-net-perfctrs-for-encrypted-traffic
auth, msg/async: add perf counters for encrypted traffic

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2022-09-19 07:14:02 -07:00
Matan Breizman
be838652fa examples: Compile with c++20
This change will apply to ubuntu only.
Fixes: https://tracker.ceph.com/issues/57163

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2022-09-19 13:18:20 +00:00
Avan
ab17e4ba1f
Merge pull request #48166 from rhcs-dashboard/fix-empty-pid-path-case
exporter: don't skip loop if pid path is empty

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-09-19 18:47:15 +05:30
Avan Thakkar
c817d7d2db exporter: don't skip loop if pid path is empty
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

Fixes issue when pid file config comes empty from config dump which prevents to add metrics. Also get process metrics only if
pid_path isn't empty.
2022-09-19 16:00:20 +05:30
Igor Fedotov
78b1093679
Merge pull request #47986 from lmgdlmgd/patch-3
osd: set per_pool_stats true when OSD has no PG

Reviewed-by: Igor Fedotov <ifedotov@croit.io>
2022-09-19 11:54:30 +03:00
Lucian Petrut
c75a10c53b
Merge pull request #48139 from ktdreyer/win-simplify-openssl
win32: skip installing openssl man pages
2022-09-19 10:59:33 +03:00
Nizamudeen A
d30d92298a mgr/dashboard: use service call instead of form component
For creating the silence from the notification sidebar, instead of using
the silence form which will require initializing the whole component on
the landing page, we can just call the prometheus service and pass on
the required data to the service call. This will fix showing the
`Prometheus not configured` error everytime we visit the landing page when
the prometheus is not configured

Fixes: https://tracker.ceph.com/issues/57576
Signed-off-by: Nizamudeen A <nia@redhat.com>
2022-09-19 11:20:55 +05:30
myoungwon oh
e7ca6d0276 ceph_dedup_tool: fix threshold comparison
If threadhold count is 2, existing code always returns true
even though reference count is 1 actually  because it additionally
adds one via ++.

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-09-19 13:22:16 +09:00
Samuel Just
df71ca5592 ceph_dedup_tool: make SampleDedupWorkerThread::chunk_size const
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:22:10 +09:00
Samuel Just
4878cebe20 ceph_dedup_tool: remove unused SampleDedupWorkerThread::duplicable_chunks
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:22:04 +09:00
Samuel Just
6ae386d48f ceph_dedup_tool: minor code simplifications
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:21:57 +09:00
Samuel Just
f5abe9cd0b ceph_dedup_tool: remove unimplemented mark_non_dedup method signature
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:21:51 +09:00
Samuel Just
988113c1cd ceph_dedup_tool: fix log lines to use std::endl, update object skip message
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:21:45 +09:00
Samuel Just
a9791e5acd ceph_dedup_tool: remove unused SampleDedupWorkerThread::do_object_dedup
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:21:39 +09:00
Samuel Just
7f2967ff40 ceph_dedup_tool: make SampleDedupGlobal::sampling_rate const
Clarifies why it doesn't need to be protected by a lock.

Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:21:32 +09:00
Samuel Just
8a50a627ee ceph_dedup_tool: remove unused SampleDedupGlobal::object_dedup_threshold
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:21:26 +09:00
Samuel Just
31b0c047fd ceph_dedup_tool: fix unnecessarily complicated bool returns
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:21:19 +09:00
Samuel Just
da52fb63f2 ceph_dedup_tool: SampleDedupWorkerThread can simply inherit from Thread
SampleDedupWorkerThread didn't actually use any of the facilities on
CrawlerThread and indeed left several of them uninitialized.

Also allows us to remove the CrawlerThread constructor which left
several members uninitialized.

Signed-off-by: Samuel Just <sjust@redhat.com>
2022-09-19 13:21:12 +09:00
myoungwon oh
537462a102 qa: remove unused values in deduplication.py
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-09-19 13:21:07 +09:00
Sungmin Lee
f81b1b61c9 qa: add validation stage for deduplication.py
To validate sample-dedup actually works, validate() runs
separated thread from sample-dedup and verifies
two following things.
1. check sample-dedup starts properly.
2. check references of all the chunk objects' in chunk tier
   exists in designated base pool.
This routune repeats for max_valication_cnt times while
sample-dedup is running. If it doesn't raise any fail while the loop,
we can pretend sample-dedup works accurately.
If not, assert() will stop this test.

In case that a reference of chunk object doesn't exist in base pool,
validate() gives a second chance after repairing it (chunk-repair op)
to deal with false-positive reference inconsistency.

Signed-off-by: Sungmin Lee <sung_min.lee@samsung.com>
2022-09-19 13:21:00 +09:00
myoungwon oh
8d2cf96ff9 src/tools/ceph_dedup_tool: fixes to daemonize the process correctly
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-09-19 13:20:53 +09:00
myoungwon oh
cbe534e0b5 qa: add deduplication test under RGW workload (s3)
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2022-09-19 13:20:46 +09:00
zdover23
62e1390d93
Merge pull request #48157 from zdover23/wip-doc-2022-09-18-rados-network-config-prompt-correction
doc/rados: update prompts in network-config-ref

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2022-09-18 08:11:48 +10:00
Zac Dover
e26c1d8574 doc/rados: update prompts in network-config-ref
This PR adds unselectable prompts to network-config-
ref.rst.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2022-09-18 06:59:47 +10:00
Casey Bodley
da11f77265 rgw: remove unused AioThrottles in rgw_op.cc
throttle creation was moved to RadosStore::get_atomic_writer(),
RadosStore::get_append_writer(), and RadosMultipartUpload::get_writer()

these instances in rgw_op.cc were unused

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-09-17 11:42:11 -04:00
Patrick Donnelly
978b3494c3
qa: turn fail_fs off in case default changes
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-09-16 16:10:43 -04:00
Ken Dreyer
bacbfccb20 win32: remove libcurl
The Windows client does not use libcurl for anything. Remove it to
simplify the build process.

Note, if we ever add libcurl back on Windows, we should disable unused
protocols to harden the build:

  --disable-ftp --disable-ldap --disable-ldaps --disable-rtsp \
  --disable-dict --disable-telnet --disable-tftp --disable-pop3 \
  --disable-imap --disable-smb --disable-smtp --disable-gopher \
  --disable-mqtt --disable-manual --disable-ntlm

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
2022-09-16 14:30:39 -04:00
Ken Dreyer
1b4db7c477 win32: install wget when building on ubuntu
The build process requires wget. Install this on Ubuntu platforms.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
2022-09-16 13:52:24 -04:00
Ken Dreyer
100990cfa6 win32: install deps with DEBIAN_FRONTEND=noninteractive
This simplifies the installation process when I run it in an interactive
terminal.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
2022-09-16 13:51:58 -04:00
Nizamudeen A
e4638a14ec
Merge pull request #47849 from torchiaf/fix/37327
mgr/dashboard: Add details to the modal which displays the `safe-to-d…

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2022-09-16 20:49:48 +05:30