Commit Graph

75493 Commits

Author SHA1 Message Date
Sage Weil
8d1d6a0650 mgr/DaemonServer: debug log health checks
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
a8e07b33f7 mon/MgrStatMonitor: show health check count on receipt
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
76bdda85ed messages/MMonMgrReport: show health check count
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
78b33655ad mon/PGMap: only warn about too few pgs after >0 pools exist
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
3b01be0d4b mon/PGMap: some stuck warnings are err, some warn
inactive and stale -> error
degraded, unclean, undersized -> warning

Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
63f97ddcf6 qa/suites/rados: whitelist health warnings
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
e12afb714e mon/PGMap: do not warn about recovering, peering, stale
Wait for stuck before complaining.  These aren't scary in and of
themselves.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
b25ddafa16 qa/tasks/mon_clock_skew_check: vastly simplify
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
db0b2f6ede mon: shorten 'stuck' threshold from 5m -> 1m
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
bfe4c08429 osd/OSDMap: add per-osd flag OSD_FLAGS check
rename OSD_FLAGS to OSDMAP_FLAGS

Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
a23b7d7ee8 osd/OSDMap: rename a few health checks
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
6a9924270b mon: move osd health checks into OSDMap method
...with one check moving into HealthMonitor where it
belongs.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
83aaa75991 qa/tasks/ceph: stop logging health on shutdown
Don't log health during actual teardown or we'll see
various scary messages unrelated to our test run.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
b9cdb9fa7b mon/MgrMonitor: do not issue MGR_DOWN on new cluster
It is normal for the initial cluster to lack a mgr.  Wait for some
grace period before complaining about a missing mgr.

Default to 30m.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
57a8747f1d mon/Monitor: periodically log new-style health warnings to log
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
69ebbebb95 mon/MDSMonitor: implement new-style cephfs health checks
Our detail elements are still strings, so we keep the bit that collapses
the metadata into a string and appends it to the string.

Each MDS-generated item becomes a detail record.

Health checks are consolidated either by MDS_ or FS_, counting the
number of mds servers or file systems affected.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:02 -04:00
Sage Weil
ad7a4c803f mon,mgr: pass new-style health checks from mgr's PGMap
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:52:01 -04:00
Sage Weil
1bbd3c48e9 mon/PGMap: implement new-style health checks
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:51:30 -04:00
Sage Weil
24a1636302 mon/OSDMonitor: implement new health checks
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:51:30 -04:00
Sage Weil
8e815abe4e mon: new health check framework
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:51:30 -04:00
Sage Weil
0b59a7f8ad mon: HealthMonitor -> OldHealthMonitor
This will go away post-luminous.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:51:30 -04:00
Sage Weil
e170405fd8 mon: remove Formatter arg to QuorumService::get_health()
This is used to dump extra weirdness to the health detail structured
output, but we are about to remove all of that in luminous.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:51:30 -04:00
Sage Weil
6068e1856d mon/Monitor: move time sync status from 'ceph health' to 'time-sync-status' command
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:51:30 -04:00
Sage Weil
349fb86ee2 mon: move health_status_t to health.h
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:51:30 -04:00
Sage Weil
32d1fd3f7e mon: move pool quota health warnings into PGMap
This puts them on the mgr in a context where they can respond to both
osdmap and pgmap updates, and removes one more dependency on pgservice
in osdmon.

We keep the pool quota FULL warning since that is a function of OSDMap
state (the pool flag... not actual usage).

Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 12:51:30 -04:00
Douglas Fuller
1cb02ee1eb Ignore unmatched rstat errors from MDS during rebuild testing
Fixes: http://tracker.ceph.com/issues/20441

Signed-off-by: Douglas Fuller <dfuller@redhat.com>
2017-07-12 11:40:46 -05:00
Jos Collin
c0112a7a55 rgw Initialize pointer field in RGWReadMDLogEntriesCR
Fixes the Coverity Scan Report:
CID 1396155: Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member req is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-07-12 21:33:04 +05:30
Jos Collin
f1580a7c23 rgw: Initialize pointer field in RGWLC
Fixes the Coverity Scan Report:
CID 1396146 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member max_objs is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member obj_names is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-07-12 21:33:04 +05:30
Jos Collin
f3d5e33010 rgw: Initialize pointer field in seed
Fixes the Coverity Scan Report:
CID 1396116: Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member create_date is not initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member s is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member store is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-07-12 21:33:04 +05:30
Jos Collin
213db6e133 rgw: Initialize pointer field in ReadParams
Fixes the Coverity Scan Report:
CID 1353428: Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member cache_info is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-07-12 21:33:04 +05:30
Jos Collin
a1aca827a8 rgw: Initialize pointer field in RGWLib
CID 1352184: Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member ldh is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-07-12 21:33:04 +05:30
Jos Collin
3d181b81ab rgw: Initialize pointer field in req_state
Fixes the Coverity Scan Report:
CID 1352183: Uninitialized pointer field (UNINIT_CTOR)
4. uninit_member: Non-static class member req is not initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member op_type is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-07-12 21:33:04 +05:30
Jos Collin
f0f0d63cee rgw: Initialize pointer field in RGWLibFS
Fixes the Coverity Scan Report:
CID 1352180 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member field fs.rgw is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-07-12 21:33:04 +05:30
Jos Collin
964081bd47 rgw: Initialize pointer field in RGWObjectExpirer
Fixes the Coverity Scan Report:
CID 1351737 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member worker is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-07-12 21:33:04 +05:30
Yuri Weinstein
b932d7f883 Merge pull request #15630 from Abhishekvrshny/fix-rgw-multipart-leaks
rgw: fix leaks with incomplete multiparts

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-07-12 08:56:04 -07:00
Yuri Weinstein
a20dd80142 Merge pull request #15669 from rzarzynski/wip-rgw-fix-rgwbucket-error-handling
rgw: fix error handling in the link() method of RGWBucket.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-07-12 08:55:28 -07:00
Yuri Weinstein
ed075b05ff Merge pull request #15834 from prallabh/wip-20377
rgw: Do not fetch bucket stats by default upon bucket listing

Reviewed-by:  Radoslaw Zarzynski <rzarzyns@redhat.com>
2017-07-12 08:52:24 -07:00
Yuri Weinstein
4d030daab7 Merge pull request #15887 from rzarzynski/wip-rgw-20394
rgw: /info claims we do support Swift's accounts ACLs.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-07-12 08:49:39 -07:00
Yuri Weinstein
dba56d62d4 Merge pull request #16154 from mikulely/obj-placement-pool
rgw: drop unused rgw_pool parameter, local variables and member variable

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-07-12 08:48:49 -07:00
Yuri Weinstein
bcd437435f Merge pull request #14961 from yehudasa/wip-19739
rgw: verify md5 in post obj

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2017-07-12 08:45:41 -07:00
Yuri Weinstein
39ad2b8ac3 Merge pull request #15281 from jimifm/wip-rgw_rados-master
rgw/rgw_rados: Remove duplicate calls in RGWRados::finalize()

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-07-12 08:44:18 -07:00
Sage Weil
808bd2ca93 Merge pull request #16287 from liewegas/wip-try-decode
mon/MgrStatMonitor: do not crash on luminous dev version upgrades

Reviewed-by: Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-07-12 09:34:20 -05:00
Casey Bodley
86d985f455 Merge pull request #16197 from shashalu/fix-RGWRadosRemoveOmapKeysCR
rgw:multisite: fix RGWRadosRemoveOmapKeysCR and change cn to intrusive_ptr

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-07-12 10:11:14 -04:00
Sage Weil
36698ad399 Merge pull request #15843 from ovh/bp-drop-ping-fields
messages/MOSDPing.h: drop unused fields

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-12 08:33:32 -05:00
Casey Bodley
850f4bb998 Merge pull request #15929 from cbodley/wip-vstart-rgw-compression
vstart: add --rgw_compression to set rgw compression plugin

Reviewed-by: Matt Benjamin <mbenjami@redhat.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2017-07-12 08:40:10 -04:00
Jianpeng Ma
c02082d9d7 os/bluestore/BlueStore: using bufferlist::copy avoid rebuild.
If using bufferlist::get_contiguous, there is maybe rebuild whic cause
redundat memcopy. And bufferlist::copy can do the same function.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2017-07-12 20:08:25 +08:00
Sage Weil
5ec27fbcbf mon/MgrStatMonitor: do not crash on luninous dev version upgrades
Signed-off-by: Sage Weil <sage@redhat.com>
2017-07-12 07:30:53 -04:00
Jos Collin
82e85a6d86 Merge pull request #16254 from TsaiJin/wip-rbd-nbd-version
tools/rbd_nbd: add --version show support

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-07-12 08:56:44 +00:00
lu.shasha
0faae7e890 rgw:multisite: change raw 'RGWAioCompletionNotifier*' to intrusive_ptr for rgw_cr_rados
Signed-off-by: Shasha Lu <lu.shasha@eisoo.com>
2017-07-12 13:50:02 +08:00
Matt Benjamin
e121fd04d6 rgw_file: permit dirent offset computation
The new dirent chunking feature in nfs-ganesha 2.5 includes an
optimization inspired by RGW NFS, and avoids invalidating modified
dirs when the underlying FSAL can project the offset of a
name in it's parent directory, independent of other entries (e.g.,
if offset is a stable hash).

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2017-07-12 00:56:58 -04:00