Commit Graph

103683 Commits

Author SHA1 Message Date
Patrick Donnelly
25f4a0357c
Merge PR #31195 into master
* refs/pull/31195/head:
	vstart: Fix /dev/tty No such device or address

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-10-30 09:09:06 -07:00
Jason Dillaman
f4d99f796a
Merge pull request #31161 from trociny/wip-42488
rbd-mirror: mirrored clone should be same format 

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-10-30 12:07:30 -04:00
Jason Dillaman
5f823f8575
Merge pull request #31149 from wonderpow/master1
cls/rbd: add snapshot_add raise -ESTALE test case

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-10-30 12:07:12 -04:00
Jason Dillaman
922385c6c2
Merge pull request #31140 from Gangbiao/add-pybind-test-case
test/pybind: add create_snap rasie ImageExists test case

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-10-30 12:06:41 -04:00
Jason Dillaman
b50e6f5894
Merge pull request #30994 from JackSlateur/rbd_merged_du
rbd: add --merge to disk-usage

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-10-30 12:06:08 -04:00
Lenz Grimmer
5df7223985
mgr/dashboard: remove space in tox.ini deps (#31246)
mgr/dashboard: remove space in tox.ini deps

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-10-30 15:32:15 +00:00
Volker Theile
4385ce4805 vstart: Fix /dev/tty No such device or address
Running on Jenkins slave or as a daemon there will be no writable console.

Fixes: https://tracker.ceph.com/issues/42487

Signed-off-by: Volker Theile <vtheile@suse.com>
2019-10-30 15:52:28 +01:00
Nathan Cutler
49ab75109f backport-resolve-issue: prune duplicate URLs
I have seen PR descriptions with a single backport tracker URL mentioned twice.
When backport-resolve-issue hit one of these, it would say:

Found backport tracker: https://tracker.ceph.com/issues/39272
Found backport tracker: https://tracker.ceph.com/issues/39272
-----------------------------------------------------------------
INFO:root:Tracker https://tracker.ceph.com/issues/39272 links to PR https://github.com/ceph/ceph/pull/29153
INFO:root:Backport Tracker 39272 target version already populated with correct value v12.2.13
INFO:root:Backport Tracker 39272 status is already set to Resolved
-----------------------------------------------------------------
INFO:root:Tracker https://tracker.ceph.com/issues/39272 links to PR https://github.com/ceph/ceph/pull/29153
INFO:root:Backport Tracker 39272 target version already populated with correct value v12.2.13
INFO:root:Backport Tracker 39272 status is already set to Resolved
=================================================================

This commit fixes the issue.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
2019-10-30 14:30:08 +01:00
Lenz Grimmer
f61d002825
mgr/dashboard: Allow removal of single notification (#31048)
mgr/dashboard: Allow removal of single notification

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-10-30 12:32:37 +00:00
Lenz Grimmer
fb29d02330
mgr/dashboard: Use checkbox for multi selection (#30495)
mgr/dashboard: Use checkbox for multi selection

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-10-30 11:58:15 +00:00
Alfonso Martínez
da72765d8e mgr/dashboard: edit/clone/copy rbd image after its data is received
Fixes: https://tracker.ceph.com/issues/42561
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
2019-10-30 12:31:13 +01:00
Nathan Cutler
2566d95e31
Merge pull request #31193 from rhcs-dashboard/wip-42507-master
mgr/dashboard: update dashboard CODEOWNERShip

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
2019-10-30 11:54:18 +01:00
Nathan Cutler
942e7385b6 backport-resolve-issue: recognize that Target version is populated
Due to a regression, the script stopped recognizing that a Backport tracker
issue's "Target version" field is populated.

Fixes: af43b3cc3b
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2019-10-30 11:46:24 +01:00
Nathan Cutler
f28fbe6c54
Merge pull request #30988 from smithfarm/wip-bri-multi
backport-resolve-issue: resolve multiple backport issues
2019-10-30 11:31:21 +01:00
Sebastian Wagner
e463177d24 mgr/dashboard: remove space in tox.ini deps
Fixes: https://tracker.ceph.com/issues/42469
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-10-30 11:27:27 +01:00
Nathan Cutler
96cb16d5a6
Merge pull request #31163 from callithea/wip-issue-42489
doc: Small update of SubmittingPatches-backports

Reviewed-by: Nathan Cutler <ncutler@suse.com>
2019-10-30 11:02:30 +01:00
Nathan Cutler
147f386002
Merge pull request #30879 from smithfarm/wip-cbs-check-missing-milestone
ceph-backport.sh: implement --milestones feature and more-careful vetting

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-10-30 10:30:01 +01:00
Kefu Chai
2210425a68
Merge pull request #29930 from IlsooByun/rocksdb_ver
cmake: require RocksDB 5.14 or higher

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-10-30 10:11:01 +08:00
Sage Weil
a1a220d137 mds/MDSRank: report state to mgr as mds id, not rank
Introduced by 625dffe65c, which added
periodic scrub stats reporting.

Fixes: https://tracker.ceph.com/issues/42494
Fixes: https://tracker.ceph.com/issues/41525
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 17:34:34 -05:00
Patrick Donnelly
b4f772d4f0
Merge PR #30369 into master
* refs/pull/30369/head:
	doc/cephfs: add doc for cephfs io path

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-10-29 15:32:18 -07:00
Patrick Donnelly
80e6cb7001
Merge PR #31201 into master
* refs/pull/31201/head:
	doc: document rank option for journal reset

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2019-10-29 12:39:06 -07:00
Sage Weil
3c0df4489c Merge PR #31181 into master
* refs/pull/31181/head:
	ceph-daemon: only pass podman -it if need an interactive shell

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2019-10-29 13:39:40 -05:00
Alfredo Deza
cfc1f71801
Merge pull request #31159 from alfredodeza/wip-rm42484
ceph-volume tests remove xenial from functional testing

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
2019-10-29 12:05:11 -04:00
Sage Weil
af64b18f1c mgr/telemetry: send device telemetry via per-host POST to device endpoint
We do not want to associate devices with clusters because that may
communicate unnecessary information about the association between vendors
and clusters (which, when large, are potentially identifying).

Instead, do a POST per host with all of the devices on that host only.

The devices endpoint does not log the POST time, so these per-host
records won't be associated with each other.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 10:52:35 -05:00
Gangbiao Liu
22974178ad test/pybind: add create_snap rasie ImageExists test case
Signed-off-by: Gangbiao Liu <liugangbiao@cmss.chinamobile.com>
2019-10-29 23:25:33 +08:00
Kefu Chai
3773a341ad
Merge pull request #31222 from sebastian-philipp/python-common-avoid-setup_requires
python-common: avoid using setup_requires in setup.py

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-10-29 23:07:39 +08:00
Tiago Melo
c7bd94f07e mgr/dashboard: Allow removal of single notification
Signed-off-by: Tiago Melo <tmelo@suse.com>
2019-10-29 13:50:01 -01:00
Sage Weil
8c7dbeca8d ceph-daemon: only pass podman -it if need an interactive shell
Otherwise, we get errors like

2019-10-26T17:29:42.004 INFO:tasks.workunit.client.0.mira109.stderr:+ sudo /usr/sbin/ceph-daemon shell -- ceph -v
2019-10-26T17:29:42.004 INFO:tasks.workunit.client.0.mira109.stderr:+ grep 'ceph version'
2019-10-26T17:29:42.149 INFO:tasks.workunit.client.0.mira109.stderr:the input device is not a TTY

Fixes: https://tracker.ceph.com/issues/42499
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 09:41:16 -05:00
Sage Weil
f5bc2bd74a Merge PR #31059 into master
* refs/pull/31059/head:
	mgr/rook: implement update_mds
	mgr/ssh: implement 'mds update'
	mgr/orchestrator_cli: add 'mds update' command
	mgr/ssh: unique names for mds instances
	mgr/ssh: name mgrs with random string id; add removal support
	mgr/ssh: provide get_unique_name helper
	mgr/orchestrator_cli: rename 'mds rm' arg
	mgr/orchestrator_cli: rename 'mds add' arg
	mgr/ssh: add 'mds rm'
	mgr/ssh: (broken) mds rm
	mgr/ssh: make mds add work
	mgr/orchestrator: add count, hosts args to 'mds add'
	mgr/ssh: be consistently verbose
	mgr/ActivePyModules: expose 'mds_metadata' to modules

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-10-29 09:38:57 -05:00
Jan Fajerski
6f8d366039
Merge pull request #31197 from jan--f/c-v-fix-lvm-mokeypatch
ceph-volume: mokeypatch calls to lvm related binaries
2019-10-29 15:27:02 +01:00
Sebastian Wagner
1ad3b0a5b9 python-common: avoid using setup_requires in setup.py
Fixes: https://tracker.ceph.com/issues/42528

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-10-29 14:05:30 +01:00
Jason Dillaman
7683f5f259 pybind/mgr: use custom exception to handle authorization failures
Python2 does not include the PermissionError exception so use a
custom exception to support both versions.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:03 -04:00
Jason Dillaman
7cccdef25e qa/workunits/rbd: add permission tests for mgr profile
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:03 -04:00
Jason Dillaman
2dc7a95950 mgr: added placeholder 'osd' and 'mds' profiles
CephFS documents a previously unhandled profile named 'mds' that
needs to be accepted as valid (but currently provides no caps).
Similarly, the 'osd' cap is deployed in several scenarios as well.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:03 -04:00
Jason Dillaman
5137cd80db doc/rbd: add new 'profile rbd' mgr caps to examples
Fixes: https://tracker.ceph.com/issues/42265
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:03 -04:00
Jason Dillaman
cd71413f57 pybind/mgr: test session authorization against specific pools/namespaces
Use the optional "pool" and "namespace" constraints for the RBD cap
profiles to ensure the user has access to touch the specified
pool/namespace combo.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:03 -04:00
Jason Dillaman
282c31c383 mgr: python modules can now perform authorization tests
In cases where the python service or individual python modules are
enabled via caps, the module might want to perform finer grained
tests to ensure specific commands are allowed. An example of this is
the 'rbd_support' module limiting access by pools and namespaces.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:03 -04:00
Jason Dillaman
9193d87623 mgr: validate that profile caps are actually valid
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:03 -04:00
Jason Dillaman
b0d73aed19 mgr: added 'profile rbd/rbd-read-only' cap
These profiles can be further restricted via 'pool' and
'namespace' argument optionals.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:03 -04:00
Jason Dillaman
cb534e0049 mgr: support optional arguments for module and profile caps
This allows an optional, arbitrary key/value constraint clauses to
be appended to "profile XYZ" and "allow module XYZ" caps. A module
can then provide additional validatation against these meta-arguments.

Example:
profile rbd pool=rbd
allow module rbd_support with pool=rbd

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:03 -04:00
Jason Dillaman
3463613bd4 mgr: add new 'allow module' cap to MgrCap
This allows specific python add-on modules to be whitelisted instead
of manually adding each command exported by the module.

  allow module {module-name} {access-spec}

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:03 -04:00
Jason Dillaman
dbb1b54d49 mon: dropped daemon type argument for MonCap
This was a placeholder for handling MGR caps within the MonCap
class. Now that the MGR has its own MgrCap class, this is no
longer required.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:35:02 -04:00
Jason Dillaman
6350bee5c8 mgr: stop re-using MonCap for handling MGR caps
Use the existing MonCap as the basis for a new custom MgrCap
processor.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-10-29 08:33:59 -04:00
Ilya Dryomov
9c17ca0aa7
Merge pull request #31023 from idryomov/wip-krbd-udev-enumerate-retry
krbd: retry on transient errors from udev_enumerate_scan_devices()

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
2019-10-29 11:40:45 +01:00
Ilsoo Byun
a83a25c076 cmake: require RocksDB 5.14 or higher
error: ‘class rocksdb::Env’ has no member named ‘SetAllowNonOwnerAccess’
       opt.env->SetAllowNonOwnerAccess(false);
                    ^~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Ilsoo Byun <ilsoobyun@linecorp.com>
2019-10-29 18:04:24 +09:00
Jan Fajerski
aa34a05aa2
Merge pull request #31072 from sebastian-philipp/ceph-volume-inventory-device-id
ceph-volume: add Ceph's device id to inventory
2019-10-29 08:16:14 +01:00
Patrick Donnelly
094df5c3f0
qa: test fs:upgrade when running upgrade suite
Sometimes this suite breaks because it's not usually tested when upgrade
suites are modified.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-10-28 20:41:29 -07:00
Patrick Donnelly
eb00dcd660
Merge PR #31063 into master
* refs/pull/31063/head:
	qa: disable too few PG warning during Mimic deploy

Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2019-10-28 20:37:31 -07:00
Kefu Chai
6e4bc90863
Merge pull request #31178 from tchaikov/wip/rpm/pyyaml
ceph.spec.in: add missing python-yaml dependency for mgr-k8sevents

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
2019-10-29 07:57:36 +08:00
Sage Weil
d927374bb4 Merge PR #31168 into master
* refs/pull/31168/head:
	ceph-daemon: try py2 import before py3
	qa/suites/rados/singleton-nomsgr/ceph-daemon: make sure python3 is installed
	qa/standalone/test_ceph_damon.sh: test with python2 and python3
	mgr/ssh: python, not python3
	ceph-daemon: python, not python3
	ceph-daemon: os.makedirs
	ceph-daemon: configparser is ConfigParser on py2
	ceph-daemon: avoid py3-isms

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Alfredo Deza <adeza@redhat.com>
2019-10-28 14:59:43 -05:00