Commit Graph

142684 Commits

Author SHA1 Message Date
Afreen
946a26c41e mgr/dashboard: Code refactor rgw migrate component for using correctly the MIGRATE action verb
fixes https://tracker.ceph.com/issues/64152

this.MIGRATE = $localize`Migrate to Multi-Site`;

Just like other action verbs we should set this.Migrate = "MIGRATE" only.
This will require rephrasing in the following places as well:
1. d3256c4841/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-details/rgw-multisite-details.component.ts (L223-L228)

2. d3256c4841/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.ts (L180-L18)

Signed-off-by: Afreen <afreen23.git@gmail.com>
2024-01-25 17:20:35 +05:30
Nizamudeen A
a70dc48d48
Merge pull request #55270 from afreen23/fix-cap-inconsistency-multisite
mgr/dashboard: Fix inconsistency in capitalisation of "Multi-site"

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: rosinL <NOT@FOUND>
2024-01-25 15:40:43 +05:30
Redouane Kachach
463716e64d
Merge pull request #55182 from rkachach/fix_issue_64029
mgr/rook: adding some basic rook e2e testing
2024-01-25 10:23:43 +01:00
Venky Shankar
2a6c1dc36d qa: fs volume rename requires fs fail and refuse_client_session set
Introduced-by: fe3a4b9683
Fixes: http://tracker.ceph.com/issues/64174
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2024-01-25 12:08:50 +05:30
Samuel Just
000188f2ba
Merge pull request #55266 from athanatos/sjust/wip-63996
crimson: retain map references in OSDSingletonState::store_maps

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2024-01-24 21:05:09 -08:00
Samuel Just
db3addf01c crimson/osd/shard_services: retain map references in OSDSingletonState::store_maps
Introduced: 3f11cd94
Fixes: https://tracker.ceph.com/issues/63996
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-01-25 03:02:06 +00:00
Samuel Just
cb02911686 crimson/osd/shard_service.cc: convert to newer logging machinery
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-01-25 03:02:06 +00:00
Samuel Just
6ad175f0b9 crimson/osd/osd.cc: migrate logging to new style
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-01-25 03:02:04 +00:00
Samuel Just
3eebce4aab
Merge pull request #55288 from athanatos/sjust/wip-64140
Revert "crimson/os/alienstore/alien_log: _flush concurrently"

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2024-01-24 17:23:47 -08:00
Adam Emerson
0e584be902 rgw: Thread site config into RADOS driver
Make this available so multisite sync doesn't have to rely on the zone
service.

Signed-off-by: Adam Emerson <aemerson@redhat.com>
2024-01-24 16:59:58 -05:00
Adam C. Emerson
dc262061fe rgw: Asio frontend shares io_context with the rest of RGW
Pull the `io_context` and threads out of `AsioFrontend`, pass in a
reference to `io_context_pool` so it can be shut down at `AsioFrontend::join`

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2024-01-24 16:59:56 -05:00
Yuri Weinstein
5ddd51e819
Merge pull request #54987 from batrick/i63822
pybind/mgr/devicehealth: skip legacy objects that cannot be loaded

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
2024-01-24 13:31:31 -08:00
Yuri Weinstein
e538587e18
Merge pull request #54491 from jianwei1216/fix_osd_pg_stat_report_interval_max_cmain
fix: resolve inconsistent judgment of osd_pg_stat_report_interval_max

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
2024-01-24 13:30:50 -08:00
Yuri Weinstein
6bba2bc173
Merge pull request #53250 from YiteGu/add-perfcount-for-allocator
os/bluestore: add perfcount for bluestore/bluefs allocator

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2024-01-24 13:30:07 -08:00
Yuri Weinstein
2fac6737f8
Merge pull request #52530 from amathuria/wip-amat-fix-59531
osd: Add memstore to unsupported objstores for QoS

Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2024-01-24 13:28:16 -08:00
Adam C. Emerson
7c4eee61c4 rgw: SAL drivers take boost::asio::io_context
`RadosDriver` needs it, and since SAL generally uses `optional_yield`,
other stores are going to need it to implement that sensibly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2024-01-24 15:51:46 -05:00
Adam C. Emerson
82a40dc151 ceph/async: io_context_pool constructor/start takes init function
Add overloads of the constructor and `start` that take an init
function, for setting up the thread before dropping into
`io_context::run`.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2024-01-24 15:51:46 -05:00
Adam C. Emerson
c7789f10fe common/async: io_context_pool constructor takes int64_t
Just because this is what Ceph's config uses and it saves a narrowing
conversion. If we want to set a max value on the thread count, we
should do it in config.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2024-01-24 15:51:46 -05:00
Adam Emerson
809e1304b0 include/inline_memory.h: Add missing includes to fix build
Signed-off-by: Adam Emerson <aemerson@redhat.com>
2024-01-24 15:51:46 -05:00
Laura Flores
2b694195bf .github: fix length of dependabot commit message prefix
Followup to commit 265f727481.

Fixes this error mesage under GitHub Insights (https://github.com/ceph/ceph/network/updates):

```
The property '#/updates/1/commit-message/prefix' was not of a maximum string length of 15
```

Signed-off-by: Laura Flores <lflores@ibm.com>
2024-01-24 20:37:04 +00:00
Ramana Raja
1712b95c78 rbd-nbd: log errors during netlink_resize() using derr
When using rbd CLI to map the images to NBD devices via netlink,
any errors that arose during image resizing in netlink_resize()
were not logged. Switching the error logging from using cerr to
derr helps log the errors from netlink_resize().

Signed-off-by: Ramana Raja <rraja@redhat.com>
2024-01-24 15:33:59 -05:00
Ramana Raja
1eebb7ba79 rbd_nbd: fix resize of images mapped using netlink
Include device identifier or cookie in the message sent to the kernel
to resize images mapped to NBD devices using netlink. Otherwise,
netlink_resize() fails and the size of the device isn't updated.

Fixes: https://tracker.ceph.com/issues/64139
Signed-off-by: Ramana Raja <rraja@redhat.com>
2024-01-24 15:33:50 -05:00
Laura Flores
cd2edcf9d9
Merge pull request #49462 from rzarzynski/wip-bug-53789
osdc: fix the ENOCONN normalization in Objecter::_linger_reconnect()
2024-01-24 14:00:03 -06:00
Casey Bodley
5ea5521383
Merge pull request #55219 from samarahu/rgw_asio_frontend_asserts
rgw/asio: Add asserts to rgw_asio_frontend.cc

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2024-01-24 18:39:14 +00:00
Redouane Kachach
310eb4f9b7
mgr/rook: increase minikube mem to 6GB to avoid stability issues
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2024-01-24 19:03:56 +01:00
Gregory Farnum
e5b0db4b2f
Merge pull request #55192 from dparmar18/fix_docstrings_ceph_test_case
qa: typo fixes in ceph_test_case docstrings
2024-01-24 09:37:34 -08:00
Casey Bodley
d3256c4841
Merge pull request #53320 from jzhu116-bloomberg/wip-62710
rgw/multisite: maintain endpoints connectable status and retry the requests to them when appropriate

Reviewed-by: Mark Kogan <mkogan@ibm.com>
2024-01-24 16:01:43 +00:00
Adam King
bf084a5fd1
Merge pull request #54941 from samsungceph/vstart_network_v2
vstart: Pick only CIDR-formatted routes when cephadm enabled

Reviewed-by: Adam King <adking@redhat.com>
2024-01-24 10:25:23 -05:00
Afreen
b62c6521fd mgr/dashboard: Fix issue with Object's Overview page
Fixes https://tracker.ceph.com/issues/64150

Issue: Due to absence of null checks, the overview page was failing to
load.

Fix: Added, null check at relevant places to ensure data availability
before accessing the data.

Signed-off-by: Afreen <afreen23.git@gmail.com>
2024-01-24 20:39:54 +05:30
Casey Bodley
5c1a57a1af cmake/arrow: don't treat warnings as errors
with arrow's default BUILD_WARNING_LEVEL, -Werror is added to cflags and
debug builds fail on a warning about _FORTIFY_SOURCE

Fixes: https://tracker.ceph.com/issues/63130

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-01-24 09:47:05 -05:00
Casey Bodley
f4758e560f
Merge pull request #53668 from mdw-at-linuxbox/wip-master-update-kmip-1
Update libkmip to pull in some portability changes.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-01-24 13:30:25 +00:00
Matan Breizman
e128396eca crimson/osd/pg_map: add logs
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2024-01-24 12:23:42 +00:00
Matan Breizman
f3b39ab923 crimson/osd_pg_map: migrate logging to new style
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2024-01-24 11:03:54 +00:00
Matan Breizman
384f6532d3 crimson/osd:pg_map: rename create or remove pg
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2024-01-24 10:58:26 +00:00
Matan Breizman
195409de94 crimson/osd/pg_map: move maybe_create_pg and remove pg form header
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2024-01-24 10:58:26 +00:00
Redouane Kachach
1b3454914e
mgr/rook: adding some basic rook e2e testing
Fixes: https://tracker.ceph.com/issues/64029

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2024-01-24 11:00:54 +01:00
Samuel Just
4d52d1d22b Revert "crimson/os/alienstore/alien_log: _flush concurrently"
While submitting the log line asyncronously is reasonable,
with this implementation the EntryVector &q parameter does
not necessarily outlive the submission continuation.

This reverts commit 511af83e27.

Fixes: https://tracker.ceph.com/issues/64140
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-01-23 22:37:36 +00:00
Gal Salomon
a3415f7d0f
Merge pull request #55183 from galsalomon66/s3select_fixes_QE_bugs
rgw/s3select: bug fixes per QE recent defects
2024-01-23 23:59:15 +02:00
Marcus Watts
afc470ae63 Update libkmip submodule to pull in some portability changes.
Signed-off-by: Marcus Watts <mwatts@redhat.com>
2024-01-23 16:58:38 -05:00
Ronen Friedman
0fe3ccbd78
Merge pull request #55217 from ronen-fr/wip-rf-old-reserv
osd/scrub: check reservation replies for relevance

Reviewed-by: Samuel Just <sjust@redhat.com>-
2024-01-23 21:39:35 +02:00
Laura Flores
24dcb42d41
Merge pull request #55067 from yaarith/telemetry-pool-flags
mgr/telemetry: add pool flags
2024-01-23 12:22:32 -06:00
Laura Flores
d400b21f99
Merge pull request #55240 from rosinL/wip-fix-64032
install-deps: Force remove ceph-libboost* packages
2024-01-23 10:38:46 -06:00
zdover23
02e11fbe08
Merge pull request #55278 from Himura2la/patch-2
Docs: Specify correct fs type for mkfs on volume creation

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2024-01-24 01:58:23 +10:00
galsalomon66
852c1d9735 bug fixes per QE recent defects
update for the engine_version message
s3select submodule

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
2024-01-23 16:31:33 +02:00
Casey Bodley
aa42bf14cf
Merge pull request #55277 from yuvalif/wip-yuval-63578
rgw/lua: fix compilation issue when lua packages are disabled

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-01-23 14:18:22 +00:00
Himura Kazuto
886af37744
doc: specify correct fs type for mkfs
The default value is ext2, which is not supported (anymore?).

Signed-off-by: Vladislav Glagolev <vladislav.glagolev@devexpress.com>
2024-01-23 13:21:01 +00:00
Yuval Lifshitz
e539ca98d6 rgw/lua: fix compilation issue when lua packages are disabled
Fixes: https://tracker.ceph.com/issues/63578#change-253102

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2024-01-23 11:09:26 +00:00
Afreen
aeb8afe1d5 mgr/dashboard: Fix inconsistency in capitalisation of "Multi-site"
fixes https://tracker.ceph.com/issues/64125

Across the dashboard, two instances are present: Multi-site and
Multi-Site.
Making it consistent all over by using Multi-site.

Signed-off-by: Afreen <afreen23.git@gmail.com>
2024-01-23 15:42:36 +05:30
Ronen Friedman
7559a6c0d1 osd/scrub: check reservation replies for relevance
Compare a token (nonce) carried in the reservation reply with the remembered
token of the reservation request.  If they don't match, the reply is
stale and should be ignored (and logged).

Fixes: https://tracker.ceph.com/issues/64052

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-01-23 03:33:03 -06:00
Ronen Friedman
ee8e4150e4
Merge pull request #55107 from ronen-fr/wip-rf-rm-penaltyq
osd/scrub: remove the 'penalty queue' from the scrubber

Reviewed-by: Samuel Just <sjust@redhat.com>-
2024-01-23 07:57:39 +02:00