Idea of this is to allow scripts to lookup the contributor name/email by GitHub
username. This is useful in particular for adding appropriate "Reviewed-by"s
for each GitHub style "review".
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
os/bluestore: pass strict flag to bluestore_blob_use_tracker_t::equal()
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>
refactor OSD::build_initial_pg_history() so we update the info only if a
new interval is identified. also, this is consistent with
OSD::build_past_intervals_parallel().
Signed-off-by: Kefu Chai <kchai@redhat.com>
we need to manage the ip addr of the "standbys" state,
because the hostname/gid is insufficient to locate the
Standby node. we add ip of the mgr standby to metadata.
Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
because it will also statistic the latency of sync write
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
nvme-device-manager, to avoid name duplication with main thread
"ceph-osd"
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>
Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
os/bluestore: separate finisher for deferred_try_submit
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Varada Kari <varada.kari@sandisk.com>
Fix for:
CID 1313405 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion2 going out of scope
leaks the storage it points to.
CID 1219522 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion going out of scope
leaks the storage it points to.
CID 1219501 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion going out of scope
leaks the storage it points to.
CID 1313406 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion2 going out of scope
leaks the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
CID 1219593 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable completion going out of scope leaks
the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1402624 (#1 of 1): Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value sin. Field sin.sin_zero is
uninitialized.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1396232 (#1 of 1): Non-virtual destructor (VIRTUAL_DTOR)
nonvirtual_dtor: Class librbd::<unnamed>::SafeTimerSingleton has a
destructor and a pointer to it is upcast to class SafeTimer which
doesn't have a virtual destructor.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1405070 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405071 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405073 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405074 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405075 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405077 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405083 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405086 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405087 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
bad_memset: "memset" with fill value "'0'" (the zero character).
memset(&net, 48, 28UL). (CWE-665)
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 717207 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
uninit_member: Non-static class member dirp is not initialized
in this constructor nor in any functions that it calls.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1406088 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
uninit_member: Non-static class member root_ancestor is not
initialized in this constructor nor in any functions that it calls.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
calloc() does not take negative values, check return value from
get_max_buckets() and handle it correctly.
Fix for:
CID 1405301 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
negative_returns: arg_map.size is passed to a parameter that cannot
be negative.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
since it isn't used
Fix for:
CID 1394854 (#1 of 1): 'Constant' variable guards dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement:
opts->set(RBD_IMAGE_OPTION_....
Local variable features_set_specified is assigned only once, to a
constant value, making it effectively constant throughout its scope.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Patrick Donnelly
Casey Bodley
Jason Dillaman
Sage Weil
Jos Collin
xin.yuan
Kefu Chai
Xie Xingguo
Ashish Singh
Kefu Chai
Haomai Wang
Pan Liu
huanwen ren
Yehuda Sadeh
Danny Al-Gaaf