Commit Graph

80584 Commits

Author SHA1 Message Date
Andrew Schoen
cbf06de900
Merge pull request #18823 from ceph/wip-bz1498200
ceph-volume: support GPT and other deployed OSDs

Reviewed-by: Andrew Schoen <aschoen@redhat.com>
2017-11-09 12:01:12 -06:00
Sage Weil
78a465b90b os/bluestore: fix SharedBlob unregistration
We use the SharedBlobSet remove() in three cases:

- from SharedBlob::put(), we try to remove ourselves from the set, but
  have to deal with a racing lookup, so the removal is conditional on
  nref still being 0.
- from split_cache(), we move the SharedBlob to another collection
- from make_blob_unshared(), we remove the entry when we clear the sbid.

The problem is that the condtiional remove() (for the first case) was being
used for all three cases, and in the second two cases nref is always != 0,
so it doesn't actually happen.  This can lead to a crash during cache
shutdown.

Fix by making two variants: remove() that is unconditional, and
try_remove() that is conditional.

Set the sb->coll pointer after because remove() asserts the parent matches
where we are unregistering.

Fixes: http://tracker.ceph.com/issues/22039
Signed-off-by: Sage Weil <sage@redhat.com>
2017-11-09 11:57:13 -06:00
Yuri Weinstein
89c26b9838
Merge pull request #18817 from ZVampirEM77/wip-em-zone-cleanup
rgw cleanup: some unnecessary function called and repeated assignment

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-11-09 09:36:26 -08:00
Sage Weil
3855d2cbfd
Merge pull request #18683 from tchaikov/wip-erasure-cleanup
erasure-code: refactor the interfaces to hide internals from public

Reviewed-by: Sage Weil <sage@redhat.com>
2017-11-09 11:10:27 -06:00
Alfredo Deza
e2f281c115 doc/ceph-volume include the top level systemd.rst in the toctree
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:16 -05:00
Alfredo Deza
ff60592897 ceph-volume simple.activate add --file in help docstring as an example
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:16 -05:00
Alfredo Deza
29913951b7 doc/ceph-volume activate has a --file option for json files
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:16 -05:00
Alfredo Deza
366fb8c43a ceph-volume simple.activate enable the osd when activating
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:16 -05:00
Alfredo Deza
cb470622fd ceph-volume systemd.systemctl always force symlink when masking ceph-disk
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:16 -05:00
Alfredo Deza
c954c91339 ceph-volume simple.activate use the contents of the JSON file, fallback to CLI args
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:15 -05:00
Alfredo Deza
826c2709dd ceph-volume simple.activate only check for missing id and uuid if file is not passed in
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:15 -05:00
Alfredo Deza
bd3498f3ea ceph-volume simple.activate allow to pass a file to activate
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:15 -05:00
Alfredo Deza
d7fc26ab4e ceph-volume tests.util add tests for OSDPath validator
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:15 -05:00
Alfredo Deza
cda47c247b ceph-volume systemd.systemctl masking ceph-disk needs to be done by directly symlinking to dev/null
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:15 -05:00
Alfredo Deza
bad2f62b34 ceph-volume systemd.systemctl masking needs to use systemctl mask, not disable
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:15 -05:00
Alfredo Deza
6b2fc4c0ba ceph-volume simple.scan if mounted device cannot be detected, raise an error
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:14 -05:00
Alfredo Deza
230faf04a1 ceph-volume simple.activate remove str formatting from logging
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:14 -05:00
Alfredo Deza
b5acf4d720 ceph-volume util.arg_validators always convert the path to an absolute path
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 12:02:14 -05:00
Pavan Rallabhandi
70adfaae50 rgw: Fix swift object expiry not deleting objects
In cls_timeindex_list() though `to_index` has expired for a timespan, the marker is set for a subsequent index during the time boundary check.
This marker is further returned to RGWObjectExpirer::process_single_shard(), where this out_marker is trimmed from the respective shard,
resulting in a lost removal hint and a leaked object.

Fixes: http://tracker.ceph.com/issues/22084
Signed-off-by: Pavan Rallabhandi <PRallabhandi@walmartlabs.com>
2017-11-09 21:40:00 +05:30
linux
65445a4788 os/bluestore: avoid excessive ops in _txc_release_alloc
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
2017-11-09 17:00:26 +01:00
Abhishek Lekshmanan
4015a57c47 rgw: data sync: set num_shards when building full maps
When radosgw-admin data sync init is called on a cluster, the next run
of rgw crashes as when it processes ListBucketIndexesCR, num_shards
isn't set which is later referenced in ListBucketIndexesCR. Setting the
n sync_info.num_shards correctly to handle this case

Fixes: http://tracker.ceph.com/issues/22083
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
2017-11-09 15:50:56 +01:00
Casey Bodley
36d83f16e0
Merge pull request #18781 from iliul/correct-error-messages
rgw/rgw_op.cc: Fix error message in rgw_user_get_all_buckets_stats

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-11-09 09:48:26 -05:00
Casey Bodley
48d612001a
Merge pull request #18796 from ivancich/wip-fix-fmt-warnings
rgw: address warnings due to incorrect format code

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2017-11-09 09:43:33 -05:00
Kefu Chai
e2ade46c84
Merge pull request #17659 from majianpeng/osd-wait-ratherthan-waitinterval
osd/OSD: Using Wait rather than WaitInterval to wait queue.is_empty().

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-11-09 22:18:47 +08:00
Kefu Chai
a8f18c1539
Merge pull request #18759 from tchaikov/wip-mon-log-last
mon/LogMonitor: "log last" should return up to n entries

Reviewed-by: John Spray <john.spray@redhat.com>
2017-11-09 22:17:31 +08:00
Kefu Chai
cb58b34271
Merge pull request #18779 from tchaikov/wip-osd-remove-unused-objects_read_async
osd: remove unused ReplicatedBackend::objects_read_async()

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Xinze Chi <xinze@xsky.com>
2017-11-09 22:16:51 +08:00
Kefu Chai
b4f552d8cd
Merge pull request #18809 from tchaikov/wip-21904
mgr/zabbix: ignore osd with 0 kb capacity

Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: Wido den Hollander <wido@42on.com>
2017-11-09 22:15:06 +08:00
iliul
d60b57ef9c rgw/rgw_op.cc: Fix error message in rgw_user_get_all_buckets_stats
Signed-off-by: iliul <liul.stone@gmail.com>
2017-11-09 13:36:43 +00:00
Yao Zongyou
b761989033 rgw: check going_down() when lifecycle processing
Fixes: http://tracker.ceph.com/issues/22099

Signed-off-by: Yao Zongyou <yaozongyou@vip.qq.com>
2017-11-09 20:40:15 +08:00
Alfredo Deza
376dad7415 ceph-volume util.arg_validators require superuser privs to check paths
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:43 -05:00
Alfredo Deza
6bc1e9ee0b ceph-volume simple.scan skip directories to scan
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:43 -05:00
Alfredo Deza
cde0d51756 ceph-volume tests.devices.simple add activate CLI unit tests
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:43 -05:00
Alfredo Deza
dcc7c72196 ceph-volume tests.devices add help menu unit test
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:43 -05:00
Alfredo Deza
7071eeaeb5 doc/ceph-volume systemd describe the interaction with 'simple' activation
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:43 -05:00
Alfredo Deza
f9ee51f9fe doc/ceph-volume index initial description of simple
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:42 -05:00
Alfredo Deza
f872cd29b9 doc/ceph-volume lvm add back a system.rst with just the lvm portion of it
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:42 -05:00
Alfredo Deza
cf4e32a0dc doc/ceph-volume make systemd.rst generic enough to be related to other sub-commands
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:42 -05:00
Alfredo Deza
0672dd608d doc/ceph-volume move lvm/systemd.rst to top level, making it generic
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:42 -05:00
Alfredo Deza
80c796bd1c doc/ceph-volume simple.activate initial take on documenting activation
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:42 -05:00
Alfredo Deza
53420a4756 doc/ceph-volume lvm update systemd anchor to reflect lvm parent
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:42 -05:00
Alfredo Deza
7fc0e7ebca doc/ceph-volume lvm.activate update systemd anchor to reflect lvm parent
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:42 -05:00
Alfredo Deza
01a8b7e6a4 doc/ceph-volume lvm.systemd update anchor to reflect lvm parent
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:42 -05:00
Alfredo Deza
b30a3eaf17 doc/ceph-volume document the scan functionality
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-11-09 06:47:41 -05:00
Yao Zongyou
7605ade4b5 rgw: update life cycle related log level
Signed-off-by: Yao Zongyou <yaozongyou@vip.qq.com>
2017-11-09 19:12:50 +08:00
Chang Liu
1f1a6f18b6 tool: use coarse_mono_clock in ceph-kvstore-tool
Signed-off-by: Chang Liu <liuchang0812@gmail.com>
2017-11-09 11:16:06 +08:00
Chang Liu
e43f0c6e47 tool: ceph-kvstore-tool's store-crc command did not save result to the file as expected
"store-crc <path>" command did not save result to <path>, it didn't use <path>
argument and alwayls passed a NULL to "st.traverse" function. now we will create file
<path>, pass a *ofstream to "st.traverse" function.

Fiexes: http://tracker.ceph.com/issues/22092

Signed-off-by: Chang Liu <liuchang0812@gmail.com>
2017-11-09 11:16:06 +08:00
Jason Dillaman
14cc192016 doc/release-notes: clarify that you need to keep your existing OSD caps
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-11-08 18:22:26 -05:00
John Spray
c9eb2793e6 mon: monmap log on active should be debug
This isn't even a change to the map, just something
that got echoed every time a new mon was the leader.

Signed-off-by: John Spray <john.spray@redhat.com>
2017-11-08 17:03:25 +00:00
Jason Dillaman
5094838ab9
Merge pull request #18793 from idryomov/wip-qa-cram-path
qa/tasks/cram: include /usr/sbin in the PATH for all commands

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-11-08 11:00:41 -05:00
Yuri Weinstein
8328ccd67d
Merge pull request #18556 from joke-lee/validate_cors_rule_header_in_cors_option_request
rgw: add cors header rule check in cors option request

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-11-08 08:00:33 -08:00