MDSMonitor: do not allow MDS to transition from STATE_STOPPING
Reviewed-by: Yan, Zheng <zyan@redhat.com>
Reviewed-by: John Spray <john.spray@redhat.com>
As a safeguard against unitialized memory in isa and jerasure
plugins. Since the init method is supposed to be called before the
plugin is used, it is mostly not relevant. However it can lead to
problems that are non trivial to figure out.
Signed-off-by: Loic Dachary <ldachary@redhat.com>
Also fix the tests that verify the result when init is not called and
factorize the two tests that were almost identical for simplicity.
http://tracker.ceph.com/issues/10839Fixes: #10839
Backport: hammer
Signed-off-by: Loic Dachary <ldachary@redhat.com>
Continue to run into people who see this and run away (occasionally to
less robust solutions) without understanding why.
Signed-off-by: Sage Weil <sage@redhat.com>
Instead of the http://github.com/dachary namespace. It is not an issue
in the common case because it should be cloned because it is in the
.gitmodules file with the proper namespace.
http://tracker.ceph.com/issues/10836Fixes: #10836
Signed-off-by: Loic Dachary <ldachary@redhat.com>
Via two qa lab tests, it's hard to use retry_session which will cause connect_seq
increase, it will let reset_check harder. So use retry_global should avoid side
effect for replacing.
Signed-off-by: Haomai Wang <haomaiwang@gmail.com>
These are read and updated in places where using the session lock or
objecter->rwlock wouldn't make sense, so protect them with watch_lock
instead. last_error was already mostly protected by this lock, it was
just missing in tick().
Fixes: #10831
Backport: giant
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
The only caller of _get_osd_session() holds rwlock for write, so
_get_session() cannot race. The only caller of _get_session() which
may possibly race is _op_submit(), which handles the race more simply
inline.
Call _get_session() inline in place of _get_osd_session(), and remove
the unused functions _get_osd_session() and
_promote_lock_check_race().
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
The package was renamed a long time ago (around the Fedora 15
timeframe). The "junit4" name is only relevant for EPEL 6. For EPEL 7
and Fedora 20, the "junit" package has "Provides: junit4". And most
recently, in the junit package that ships in Fedora 21 and 22, the
package maintainer dropped the old Provides: line.
http://tracker.ceph.com/issues/10728Fixes: #10728
Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
Signed-off-by: Loic Dachary <ldachary@redhat.com>
They can only go into STATE_STOPPED. I was a little concerned
that some of the rejoin code might inadvertently allow a stopping
MDS to end up active, but after a little auditing it looks like
that all behaves properly and this is an invariant we maintain.
Fixes: #10791
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
OpenStack Object Storage API v1 defines two ways for the client to tell which response format it understands.
Until now RGW looked at query variable 'format' only. This commit implements the second way of setting the format by
providing 'Accept' HTTP-header with the desirable response mime-type.
Backport: hammer
Fixes: #10746
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
Signed-off-by: Dmytro Iurchenko <diurchenko@mirantis.com>
