Fix for:
CID 1313405 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion2 going out of scope
leaks the storage it points to.
CID 1219522 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion going out of scope
leaks the storage it points to.
CID 1219501 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion going out of scope
leaks the storage it points to.
CID 1313406 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable my_completion2 going out of scope
leaks the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
CID 1219593 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable completion going out of scope leaks
the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1402624 (#1 of 1): Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value sin. Field sin.sin_zero is
uninitialized.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1396232 (#1 of 1): Non-virtual destructor (VIRTUAL_DTOR)
nonvirtual_dtor: Class librbd::<unnamed>::SafeTimerSingleton has a
destructor and a pointer to it is upcast to class SafeTimer which
doesn't have a virtual destructor.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1405070 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405071 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405073 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405074 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405075 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405077 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405083 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405086 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
CID 1405087 (#1 of 1): Memset fill value of '0' (NO_EFFECT)
bad_memset: "memset" with fill value "'0'" (the zero character).
memset(&net, 48, 28UL). (CWE-665)
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 717207 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
uninit_member: Non-static class member dirp is not initialized
in this constructor nor in any functions that it calls.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1406088 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
uninit_member: Non-static class member root_ancestor is not
initialized in this constructor nor in any functions that it calls.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
calloc() does not take negative values, check return value from
get_max_buckets() and handle it correctly.
Fix for:
CID 1405301 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
negative_returns: arg_map.size is passed to a parameter that cannot
be negative.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
since it isn't used
Fix for:
CID 1394854 (#1 of 1): 'Constant' variable guards dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement:
opts->set(RBD_IMAGE_OPTION_....
Local variable features_set_specified is assigned only once, to a
constant value, making it effectively constant throughout its scope.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fixes the Coverity Scan Report:
** 1405275 Dereference after null check
CID 1405275 (#1 of 1): Dereference after null check (FORWARD_NULL)
5. var_deref_model: Passing null pointer value to append, which dereferences it.
Signed-off-by: Amit Kumar amitkuma@redhat.com
when a mds node reboot, mon deal beacon message from this mds.
The connection between mon and MDS has been released.This will cause Session is empty.Then this mon will assert(session);
BTW in mon/OSDMonitor.cc,this bug is fixed.
Signed-off-by: wangshuguang <wangshugaung@inspur.com>
updating releases to retire Kraken, Hammer. Also updated to mention
Jewel will be around until at least N is finalized
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
We need to update our info about the previous interval in order to
detect interval changes properly.
Fixes: http://tracker.ceph.com/issues/21203
Signed-off-by: w11979 <wang.wenfeng@h3c.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Adding Luminous release date, and dropping links for dev releases (since
they've been merged to 12.2.0), also rearranged the table so that newer
releases come left
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
So we don't output anything if csum is currently off:
_do_alloc_write blob Blob(0x7fad7cc25950 blob([0x42a80000~10000] none/0x1)
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
The global checksum setting may change, e.g., from NONE to CRC32,
which can cause improper re-initialization of the csum-settings of
existing blobs(e.g., partial write/overwrite may turn out to shrink
'csum_data').
We could develop some complicated solutions but for now let's not
bother since the above scenario is rare.
Fixes: http://tracker.ceph.com/issues/21175
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
