Commit Graph

116360 Commits

Author SHA1 Message Date
Yuval Lifshitz
eaf48d1a3a rgw/lua: allow setting metadata via lua
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2020-10-30 10:40:06 +02:00
Kefu Chai
d162c00c66
Merge pull request #37788 from tchaikov/wip-zbd
rpm,cmake: s/WITH_LIBZBD/WITH_ZBD/ and enable ZBD on demand

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-By: Neha Ojha <nojha@redhat.com>
2020-10-30 11:17:56 +08:00
Kefu Chai
92300bb747
Merge pull request #37888 from tchaikov/wip-crimson-gtest
crimson/gtest_seastar: do not keep a copy of argv

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2020-10-30 10:25:49 +08:00
Kefu Chai
2cdbbd1212
Merge pull request #37891 from tchaikov/wip-cmake-alienstore
cmake: build bluestore-tp before crimson-alienstore

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2020-10-30 10:25:06 +08:00
Kefu Chai
75c7a792e6
Merge pull request #37893 from tchaikov/wip-wunused-variable
osd/osd_types: mark unused variable [[maybe_unused]]

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-10-30 10:24:11 +08:00
Jason Dillaman
190534ae08
Merge pull request #37864 from trociny/wip-48020
mgr/rbd_support: store global schedule without localized prefix

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-10-29 20:58:44 -04:00
Jason Dillaman
54329691c0
Merge pull request #37880 from trociny/wip-rbd-finisher-cancel
librbd: relax requirements on finisher canceled callback

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-10-29 20:58:13 -04:00
Samuel Just
08c54e4ec2
Merge pull request #37886 from tchaikov/wip-osd-scheduler-move
osd/scheduler: rely on copy ellision to move return val

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
2020-10-29 10:56:44 -07:00
Casey Bodley
897f96eef1
Merge pull request #34866 from nickjanus/issue-45193
rgw-admin: fixes BucketInfo for missing buckets

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-10-29 12:00:52 -04:00
Yuval Lifshitz
f454b2a628
Merge pull request #37657 from batrick/rgw-lua-fixes
rgw: lua refactor
2020-10-29 17:56:46 +02:00
Mykola Golub
5e10672e4e
Merge pull request #37884 from dillaman/wip-48032
qa/workunits/rbd: fix permission issue when removing mirror peer

Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-10-29 15:48:35 +02:00
Kefu Chai
4cc179ff08
Merge pull request #37890 from tchaikov/wip-crimson-os-cleanup
crimson/os: fix couple issues reported by clang

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2020-10-29 19:59:08 +08:00
Matt Benjamin
64f15c838b
Merge pull request #36739 from pritha-srivastava/wip-rgw-sts-expire-session-token
rgw/sts: adding code for "aws:TokenIssueTime" to be used
2020-10-29 07:58:10 -04:00
Matt Benjamin
133f26325d
Merge pull request #35612 from pritha-srivastava/wip-sts-role-min-duration
rgw/sts: Adding a configurable rgw_sts_min_session_duration
2020-10-29 07:57:50 -04:00
Kefu Chai
755c0e7f8b osd/scheduler: rely on copy ellision to move return val
C++14 enforces copy ellision in this case.

also silences warning of

src/osd/scheduler/mClockScheduler.cc:122:21: warning: redundant move in return statement [-Wredundant-move]
  122 |     return std::move(ret);
      |            ~~~~~~~~~^~~~~

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 18:51:38 +08:00
Kefu Chai
f9f9270d75 osd/osd_types: mark unused variable [[maybe_unused]]
silences warning like:

rc/osd/osd_types.h:5482:18: warning: unused variable '_' [-Wunused-variable]
     auto [iter, _] = ref_delta.try_emplace(hoid, 0);
                  ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 18:36:13 +08:00
Kefu Chai
76fe6fc32c cmake: build bluestore-tp before crimson-alienstore
to address the FTBFS of

src/os/bluestore/BlueStore.cc:52:10: fatal error: tracing/bluestore.h: No such file or directory
   52 | #include "tracing/bluestore.h"
      |          ^~~~~~~~~~~~~~~~~~~~~
compilation terminated.

tracing/bluestore.h is created by the "bluestore-tp" target, there
is a good chance that we build crimson when WITH_LTTNG is enabled,
let's ensure that tracing/bluestore.h is ready before compiling
alienstore.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 17:21:06 +08:00
Kefu Chai
7736aaf32f crimson/os: capture local bindings using capture variable list
structured binding does not define variables, and the implicit
capture-by-copy `=` does not help in this case, we have to define a
capture with an initializer to create a *variable* enclosed by
the closure explicitly.

this address the error like:

src/crimson/os/seastore/segment_cleaner.cc:315:5: error: reference to local binding 'addr' declared in enclosing lambda expression
                  addr);
                  ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 16:32:26 +08:00
Kefu Chai
e29f6e84d7 crimson/os: do not move temporay variable
copy ellision ensures that copy ctor is not called in this case

silences warning like:

mson/os/seastore/lba_manager/btree/lba_btree_node_impl.cc:262:5: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
    std::move(begin()),
    ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 16:32:26 +08:00
Kefu Chai
6498d97a0e crimson/os: do not capture unused variable
silences warning like:

btree/extentmap_btree_node.h💯8: warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
      [this, ec, len] (auto &extents) {
       ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 16:32:25 +08:00
Kefu Chai
f3f688c48f
Merge pull request #37887 from tchaikov/wip-seastar
seastar: pick up changes to colocate libc allocator and seastar alloc…

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-10-29 15:21:41 +08:00
Kefu Chai
897fe53951 crimson/gtest_seastar: consume argv before passing them to seastar
so we can pass gtest options to the test without annoying seastar app.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 15:00:41 +08:00
Kefu Chai
0df04e602b crimson/gtest_seastar: do not keep a copy of argv
argv is always available in the whole life cycle of the application, so
there is no need to keep a copy of it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 14:04:51 +08:00
Kefu Chai
4cd2b00d2a seastar: pick up changes to colocate libc allocator and seastar allocator
this allows us to use seastar's builtin allocator along with the libc
allocator used by alien threads.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 13:59:41 +08:00
Kefu Chai
b1e133468f cmake: set HAVE_LIBZBD before creating "acconfig.h"
`acconfig.h` is generated using

configure_file(
  ${CMAKE_SOURCE_DIR}/src/include/config-h.in.cmake
  ${CMAKE_BINARY_DIR}/include/acconfig.h
)

in `config-h.in.cmake`, the cmake variable of `HAVE_LIBZBD` is checked.
so we need to ensure that this variable is visible from this
`configure_file()` statement.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 11:19:40 +08:00
Kefu Chai
98c06b534f rpm: pass -DWITH_ZBD=ON to cmake if zbd is enabled
this is a leftover of fd1b02a341

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 11:19:40 +08:00
Kefu Chai
afd598996a cmake: s/WITH_LIBZBD/WITH_LIBZBD/
fix the regression introduced by
d536386306

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-10-29 11:19:40 +08:00
Yan, Zheng
a80cb18726
Merge pull request #37777 from chenerqi/fix-modified-dentries-count
mds: fix count error of modified dentries
2020-10-29 11:08:10 +08:00
Jason Dillaman
79fb76cecd
Merge pull request #37636 from MahatiC/wip-init-ssd
librbd/cache: init functionality for SSD Cache

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-10-28 19:03:05 -04:00
Jason Dillaman
c457985dfa
Merge pull request #37680 from orozery/object-dispatch-aligned-crypto
librbd: crypto alignment support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2020-10-28 19:02:47 -04:00
Samuel Just
10b0a5ed3a
Merge pull request #37871 from cyx1231st/wip-seastore-misc-fixes
crimson/seastore: misc fixes in transaction manager

crimson/seastore: misc fixes in transaction manager
2020-10-28 13:16:55 -07:00
Daniel Gryniewicz
35bbc13258
Merge pull request #37877 from dang/wip-dang-cond-writeback
rgw: Fix broken merge in #37774
2020-10-28 14:27:06 -04:00
Jason Dillaman
caaba8eabe qa/workunits/rbd: fix permission issue when removing mirror peer
Fixes: https://tracker.ceph.com/issues/48032
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-10-28 14:06:57 -04:00
Daniel Gryniewicz
e47b71955d RGW - Fix broken merge in #37774
I messed up the merge in #37774 and somehow forgot to push a change.
This resulted it the flag being set on the wrong branch.  This fixes
that.

RHBZ#1845501

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2020-10-28 11:49:58 -04:00
Kefu Chai
651f77cf99
Merge pull request #37865 from neha-ojha/wip-mon-fixes
qa: miscellaneous mon test fixes

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-10-28 23:45:38 +08:00
Lenz Grimmer
0b9a4e053a
Merge pull request #36764 from ishanrai05/guide
mgr/dashboard: Style guide to give a the UI an overall look and feel

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-10-28 15:47:32 +01:00
Mykola Golub
0fe9cdefdc librbd: complete with -ECANCELED queued task requests instead of deleting
This is cleanup just to make it consistent with other cases.

Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-10-28 13:43:43 +00:00
Mykola Golub
20b2ef931a librbd: relax requirements on finisher canceled callback
The finisher timer is started with safe_callbacks = false, and
cancel_event may fail.

When canceling a task it is safe to just ignore the cancel_event
result and proceed, because the returned false value means the
callback is in TaskFinisher::complete already but before
acquiring the lock, so when it eventually acquires the lock it
will just find out the task is already deleted and return.

Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-10-28 13:43:15 +00:00
Mykola Golub
8e9e2a73f5 mgr/rbd_support: backward compatibility when loading global schedule
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-10-28 09:22:00 +00:00
Mykola Golub
e46e80474f mgr/rbd_support: store global schedule without localized prefix
so it is still used after mgr failover

Fixes: https://tracker.ceph.com/issues/48020
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-10-28 09:22:00 +00:00
Jan Fajerski
f4cd2a1784 Merge PR #37808 into master
* refs/pull/37808/head:
	ceph-volume: consume mount opt in simple activate

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-10-28 09:21:06 +01:00
Yingxin Cheng
354346572e crimson/os/seastore/transaction_manager: add missing final keyword
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-10-28 15:51:24 +08:00
Yingxin Cheng
4f2f4f4ab0 crimson/os/seastore/transaction_manager: use weak transaction when initialize cached extents
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-10-28 15:45:20 +08:00
Kefu Chai
b28174f13f
Merge pull request #37761 from tchaikov/wip-ceph.spec-with-seastar
ceph.spec.in: install gcc-toolset on RHEL only

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2020-10-28 14:43:49 +08:00
Mahati Chamarthy
01400fedc3 librbd/cache: init functionality for SSD Cache
Adds build option and implements init functionality for SSD cache

Signed-off-by: Lisa Li <xiaoyan.li@intel.com>
Signed-off-by: Mahati Chamarthy <mahati.chamarthy@intel.com>
Signed-off-by: Changcheng Liu <changcheng.liu@intel.com>
2020-10-28 11:16:41 +05:30
Erqi Chen
e76073ef19 mds: fix count error of modified dentries
CDir::_omap_commit counts modified dentries, for fragmenting
new dir modified dentries include head and snap items.

Fixes: https://tracker.ceph.com/issues/47981
Signed-off-by: Erqi Chen <chenerqi@gmail.com>
2020-10-28 11:11:19 +08:00
Brad Hubbard
677d939b39
Merge pull request #37826 from badone/wip-make-dist-ng-cli-noprompt
make-dist: Don't prompt while running 'npm ci'

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by:  Tiago Melo <tmelo@suse.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2020-10-28 07:32:41 +10:00
Neha Ojha
df7adbf387 qa/tasks/ceph_manager.py: remove redundant quorum status logging
2020-10-21T03:42:45.985 INFO:teuthology.orchestra.run.smithi114:> sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 ceph --cluster ceph quorum_status
2020-10-21T03:42:58.574 INFO:teuthology.orchestra.run.smithi114.stdout:{"election_epoch":1650,"quorum":[0,2],"quorum_names":["a","c"],"quorum_leader_name":"a","quorum_age":0,"features":{"quorum_con":"4540138297136906239","quorum_mon":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"]},"monmap":{"epoch":1,"fsid":"807c36f1-9e85-4fa3-81fc-95915ab50584","modified":"2020-10-21T00:34:48.421341Z","created":"2020-10-21T00:34:48.421341Z","min_mon_release":16,"min_mon_release_name":"pacific","election_strategy":3,"disallowed_leaders":"","features":{"persistent":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"],"optional":[]},"mons":[{"rank":0,"name":"a","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6789","nonce":0}]},"addr":"172.21.15.114:6789/0","public_addr":"172.21.15.114:6789/0","priority":0,"weight":0},{"rank":1,"name":"b","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.133:6789","nonce":0}]},"addr":"172.21.15.133:6789/0","public_addr":"172.21.15.133:6789/0","priority":0,"weight":0},{"rank":2,"name":"c","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6790","nonce":0}]},"addr":"172.21.15.114:6790/0","public_addr":"172.21.15.114:6790/0","priority":0,"weight":0}]}}
2020-10-21T03:42:58.589 INFO:tasks.mon_thrash.ceph_manager:quorum_status is {"election_epoch":1650,"quorum":[0,2],"quorum_names":["a","c"],"quorum_leader_name":"a","quorum_age":0,"features":{"quorum_con":"4540138297136906239","quorum_mon":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"]},"monmap":{"epoch":1,"fsid":"807c36f1-9e85-4fa3-81fc-95915ab50584","modified":"2020-10-21T00:34:48.421341Z","created":"2020-10-21T00:34:48.421341Z","min_mon_release":16,"min_mon_release_name":"pacific","election_strategy":3,"disallowed_leaders":"","features":{"persistent":["kraken","luminous","mimic","osdmap-prune","nautilus","octopus","pacific","elector-pinging"],"optional":[]},"mons":[{"rank":0,"name":"a","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6789","nonce":0}]},"addr":"172.21.15.114:6789/0","public_addr":"172.21.15.114:6789/0","priority":0,"weight":0},{"rank":1,"name":"b","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.133:6789","nonce":0}]},"addr":"172.21.15.133:6789/0","public_addr":"172.21.15.133:6789/0","priority":0,"weight":0},{"rank":2,"name":"c","public_addrs":{"addrvec":[{"type":"v1","addr":"172.21.15.114:6790","nonce":0}]},"addr":"172.21.15.114:6790/0","public_addr":"172.21.15.114:6790/0","priority":0,"weight":0}]}}

Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-10-27 21:14:54 +00:00
Neha Ojha
1fa25e0780 qa/suites/rados/dashboard: ignore MON_DOWN
This warning is expected during:

2020-10-27T16:29:40.549+0000 7fa1f0927700 10 mon.c@2(peon) e1 handle_auth_request haven't formed initial quorum, EBUSY

and is cleared after:

2020-10-27T16:29:42.597+0000 7fe7b3ada700  7 mon.a@1(peon).log v7 update_from_paxos applying incremental log 7 2020-10-27T16:29:42.319274+0000 mon.b (mon.0) 76 : cluster [INF] mon.b is new leader, mons b,a,c in quorum (ranks 0,1,2)
2020-10-27T16:29:42.597+0000 7fe7b3ada700  7 mon.a@1(peon).log v7 update_from_paxos applying incremental log 7 2020-10-27T16:29:42.326711+0000 mon.b (mon.0) 82 : cluster [INF] Health check cleared: MON_DOWN (was: 1/3 mons down, quorum b,a)

Signed-off-by: Neha Ojha <nojha@redhat.com>
2020-10-27 21:14:54 +00:00
Dimitri Savineau
1f4301a15d ceph-volume: consume mount opt in simple activate
When running ceph-volume simple activate command on a Filestore OSD
then the data device is mounted without any specific options so the
one from the ceph configuration file are ignored.
When deploying Filestore with the lvm subcommand then everything is
fine because the filestore_activate method uses mount_osd which relies
on the mount options defined in the ceph configuration file (if any).

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1891557
Fixes: https://tracker.ceph.com/issues/48018

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
2020-10-27 11:53:28 -04:00