Commit Graph

136623 Commits

Author SHA1 Message Date
Samuel Just
cd30a94e92
Merge pull request #50018 from Matan-B/wip-matanb-c-pg-pipeline
crimson/osd/osd_operations: Remove replicated_request_pg_pipeline

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-02-13 12:42:45 -08:00
Ilya Dryomov
1aeae0aebd CODEOWNERS: don't override doc-writers by core and rbd for some files
This happens because core and rbd ownership is defined after
doc-writers: a later match takes precedence.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-02-13 19:05:03 +01:00
Kaleb S. KEITHLEY
7c84974ea2 rgw: rgw_token.cc error: reference to 'formatter' is ambiguous
compiling main branch on Fedora 38 and 39/rawhide with gcc-c++-13.0.1
fails with the error:

/builddir/build/BUILD/ceph-18.0.0-2148-g9754cafc/src/rgw/rgw_token.cc:
In function 'int main(int, char**)':
/builddir/build/BUILD/ceph-18.0.0-2148-g9754cafc/src/rgw/rgw_token.cc:125:3:
error: reference to 'formatter' is ambiguous
  125 | formatter = new JSONFormatter(true /* pretty */);
      |   ^~~~~~~~~

Similar error for src/test/test_rgw_token.cc

Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
2023-02-13 11:15:59 -05:00
Casey Bodley
a9cbbba338
Merge pull request #50073 from cbodley/wip-codeowners-rgw
github: add rgw team to CODEOWNERS

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
2023-02-13 10:53:42 -05:00
Adam King
45813ea2f3
Merge pull request #49555 from fmount/drive_group_crush
Add per OSD crush_device_class definition

Reviewed-by: Adam King <adking@redhat.com>
2023-02-13 10:09:07 -05:00
zdover23
56158d5fbd
Merge pull request #50086 from zdover23/wip-doc-2023-02-13-multisite-migrating-single-site-to-multi-site
doc/rgw: "Migrating Single Site to Multi-Site"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-02-13 22:46:05 +10:00
Zac Dover
40c82f8ef6 doc/rgw: "Migrating Single Site to Multi-Site"
Refine "Migrating Single-site System to Multi-site" in
doc/radosgw/multisite.rst.

https://tracker.ceph.com/issues/58632

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Co-authored-by: Anthonh D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-02-13 22:06:33 +10:00
Ilya Dryomov
6d8fb57156
Merge pull request #50071 from idryomov/wip-58688
qa/suites/rbd: fix sporadic "rx-only direction" test failures

Reviewed-by: Ramana Raja <rraja@redhat.com>
2023-02-13 12:54:26 +01:00
Yingxin Cheng
7d54be7958 crimson/net: fix the corner case when the replacing connection doesn't have socket
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-13 14:42:13 +08:00
Yingxin Cheng
7b93616a84 test/crimson: improve messenger test coverage
* add blockings at custom_bp_t::SOCKET_CONNECTING
* adjust peer_wins to true

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-13 14:39:46 +08:00
Yingxin Cheng
19ede1aee1 test/crimson: enable blocking with custom_bp_t::SOCKET_CONNECTING in messenger test
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-13 11:35:35 +08:00
Yingxin Cheng
c30fb84d9c test/crimson: cleanup messenger test addresses
Consolidate the name/port/nonce of the addresses used in the messenger
unit tests.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-13 11:28:19 +08:00
Adam King
377b7606c1 cephadm: fix autopep8 arg parsing on newer tox versions
This was failing for me on new tox versions with

fix: commands[1]> autopep8 --max-line-length 100
incorrect number of argumentsfix: exit 99 (0.06 seconds) /home/adking/ceph/src/cephadm> autopep8 --max-line-length 100 pid=309039
fix: FAIL ✖ in 0.08 seconds

As it was considering our list of args for autopep8 to each be
one separate command. Fixed by just adding slashes to the ends
of the lines (as has already been done in the tox.ini in src/pybind/mgr
for some of the tests there)

Signed-off-by: Adam King <adking@redhat.com>
2023-02-12 22:18:25 -05:00
licc
63c7d2a44b rgw: RGWSI_RADOS::Pool::List::init() catches IoCtx::nobjects_begin() exceptions
Signed-off-by: lichaochao <lichaochao2_yewu@cmss.chinamobile.com>
2023-02-13 02:01:26 +01:00
licc
14176f00f4 rgw:log_list_init() catches IoCtx::nobjects_begin() exceptions
Signed-off-by: lichaochao <lichaochao2_yewu@cmss.chinamobile.com>
2023-02-13 02:00:49 +01:00
Casey Bodley
78c3839d89 github: add /examples to CODEOWNERS
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-02-12 11:00:59 -05:00
NitzanMordhai
839a0dcf7d ObjectStore: FileStore has been deprecated
ObjectStore will no longer create new FileStore object store and OSD
will terminate

dencoder: remove filestore
  remove filestore headers and change some location for other
  non related filestore headers

tools: ceph-objectstore-tool remove filestore functions
  Removing un-needed options after depreciting filestore

tools: Change DBObjectMap location
  change header path after depreciting filestore

FileStore: Delete folders, files and CMake entries from os
  depreciting filestore files and CMake entries

Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
2023-02-12 06:11:29 +00:00
Nitzan Mordechai
e682b60617 test: Remove all filestore tests and use
- test_trans convert FileStore to BlueStore test
 - xattr_bench convert FileStore to BlueStore usage
 - remove test_idempotent_sequence tests
 - remove test_idempotent
 - remove test_filejournal
 - removing filestore tests from store_test
 - remove rep_read_unfound test for filestore only
 - remove osd-dup convert filestore to bluestore
 - osd-scrub-repair start only bluestore osd
 - osd-pool-create remove filestore expected_num_object test
 - Remove chain_xattr and LFNIndex uneeded test

Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
2023-02-12 06:11:29 +00:00
Nitzan Mordechai
5008369a3e ceph_manager: removing filestore objectstore-tools file apply-layout-setting
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
2023-02-12 06:11:29 +00:00
Nitzan Mordechai
d8202bc67c rados: upgrade suite test filestore removal
When upgrading osd with filestore to reef, restart should not be possible
the osd won't boot and error message will be showed in the osd log

Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>
2023-02-12 06:11:29 +00:00
Nitzan Mordechai
4c4967dbb9 qa/suites: change all osd objectstore filestore
Removing and changing all suites to no longer use filestore

Signed-off-by: Nitzan Mordechai <nmordec@redhat.com>

ceph_volume: remove all filestore tests suites
Since filestore removed, no need to test it

Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
2023-02-12 06:11:29 +00:00
Anthony D'Atri
8c1d7ce1dd
Merge pull request #50077 from zdover23/wip-doc-2023-02-12-multisite-failover
doc/rgw: refine "Failover and Disaster Recovery"
2023-02-11 23:54:45 -05:00
Zac Dover
815359800c doc/rgw: refine "Failover and Disaster Recovery"
English grammar and syntax pass for "Failover and Disaster Recovery" in
doc/radosgw/multisite.rst.

https://tracker.ceph.com/issues/58632

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-02-12 09:47:16 +10:00
zdover23
f21d7e0e8c
Merge pull request #50066 from zdover23/wip-doc-2023-02-10-multisite-configuring-secondary-zones
doc/rgw: refine "Configuring Secondary Zones"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-02-11 09:51:51 +10:00
Casey Bodley
41c3975c9f github: add rgw team to CODEOWNERS
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-02-10 13:17:21 -05:00
Ilya Dryomov
5cec2670be qa/suites/rbd: fix sporadic "rx-only direction" test failures
The existing

    xmlstarlet sel -t -v  '//mirror/peers/peer[1]/uuid')" = ""

test is bogus since a tx-only peer gets added after the remote
rbd-mirror daemon pings the local cluster.  It happened to pass most
of the time because xmlstarlet filter just failed on an empty peers
array, producing the wrongly expected empty string by accident.

Fixes: https://tracker.ceph.com/issues/58688
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-02-10 15:26:27 +01:00
Ilya Dryomov
1944588033
Merge pull request #49763 from Svelar/vstart4
vstart: check mgr status after starting mgr

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-02-10 15:23:19 +01:00
Xuehan Xu
02c630d5b2 crimson/osd/pg: synchronize processing of peering events and backfill
events

All peering events and backfill events for the same pg has to be
processed sequentially, so use a single pipeline phase to synchronize
them.

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2023-02-10 15:36:07 +08:00
zdover23
f160cc8d0c
Merge pull request #50063 from zdover23/wip-doc-2023-02-10-cephfs-quota-extended-cephfs-attributes-and-getfattr
doc/cephfs: add note about CephFS extended attributes and getfattr

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-02-10 15:29:08 +10:00
Zac Dover
2c6f0ab538 doc/rgw: refine "Configuring Secondary Zones"
English grammar and syntax pass (and some pragmatics, too, where I had
enough understanding to be helpful that way) for "Configuring Secondary
Zones" in doc/radosgw/multisite.rst.

https://tracker.ceph.com/issues/58632

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-02-10 12:48:26 +10:00
Rongqi Sun
bdd7dd1dec vstart: check mgr status after starting mgr.
Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
2023-02-10 10:25:29 +08:00
Zac Dover
7f23dde6be doc/cephfs: add note about CephFS extended attributes and getfattr
Supersedes https://github.com/ceph/ceph/pull/50060

Add a note on the fact that CephFS extended attributes are not printed
by "getfattr /some/cephfs/dir/ -d -m -" even when the CephFS directory
has some extended attributes set on it.

https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/6ENI42ZMHTTP2OONBRD7FDP7LQBC4P2E/

Primary Author: Rishabh Dave <ridave@redhat.com>
Co-author: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-02-10 09:20:27 +10:00
Casey Bodley
5ddde6eb3d test/cls/rgw: test that index entry is removed after racing deletes
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-02-09 13:45:21 -05:00
Radoslaw Zarzynski
59c8ee4381 crimson/osd: make the ObjectContextRegistry per-PG
This patch moves the OBC registry from ShardServices (which
is basicaly a gateway to a bunch of PGs) into PG itself.
Dividing OBCs by PG (they truly belong to) minimizes the space
to search when e.g. checking whether a client is blocked or
not. Therefore, this commit is enabler of more performant
PR #47637.

The changeset draws the assumption that OBC registry and all
its users live on the same CPU core. It looks valid to me.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-02-09 18:10:12 +01:00
Rishabh Dave
b89892940d vstart.sh: set logging for client and MDS when -d is passed
Set debug log messages for client and MDS to 20 when option "--debug" is
passed to vstart.sh

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-02-09 22:23:14 +05:30
Yuri Weinstein
b83fbc2ad0
Merge pull request #49132 from aclamk/wip-aclamk-bs-excl-lock
blk/kernel: Add O_EXCL for block devices

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
2023-02-09 07:29:36 -08:00
Nizamudeen A
25bc57d38f mgr/dashboard: fix rbd mirroring daemon health status
Fixes: https://tracker.ceph.com/issues/58679
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-02-09 17:29:19 +05:30
Matan
7800ea59aa
Merge pull request #50023 from rosinL/fix-vstart
vstart: correct condition for checking crimson

Reviewed-by:  Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-02-09 12:30:52 +02:00
Guillaume Abrioux
4f19a0f4e1 ceph-volume: do not raise RuntimeError in util.lsblk
Otherwise it makes `simple scan` calls fail.

```
  File "/usr/lib/python3.6/site-packages/ceph_volume/util/disk.py", line 246, in lsblk
    raise RuntimeError(f"{device} not found is lsblk report")
RuntimeError: /var/lib/ceph/osd/ceph-0/ not found is lsblk report
```

Fixes: https://tracker.ceph.com/issues/58655

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2023-02-09 10:03:21 +01:00
Yingxin
c7f6ef9a63
Merge pull request #49744 from xxhdx1985126/wip-fix-seastar-mem-leak
seastar: fix mem leak caused by no maximum memory limit for cpu core

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-09 16:34:26 +08:00
Nizamudeen A
7b93592083 mgr/dashboard: fix conflicting peer dependency: postcss@8.4.21
The overrides was done by me as a workaround for an issue in postcss
when i upgraded to angular 13. but it looks like that issue was no more
when i tested with the latest.

Fixes: https://tracker.ceph.com/issues/58475
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-02-09 12:23:08 +05:30
Yuri Weinstein
186df9b881
Merge pull request #48703 from sseshasa/wip-fix-mclk-builtin-profile-mods
osd: Restore defaults of mClock built-in profiles upon modification

Reviewed-by: Neha Ojha <nojha@redhat.com>
2023-02-08 17:15:08 -08:00
dependabot[bot]
97ad991527
mgr/dashboard: bump @sideway/formula
Bumps [@sideway/formula](https://github.com/sideway/formula) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/sideway/formula/releases)
- [Commits](https://github.com/sideway/formula/compare/v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: "@sideway/formula"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-02-09 00:43:26 +00:00
Laura Flores
49b662bd81
Merge pull request #48591 from rzarzynski/wip-osd-snaptrimmer-waitscrub-fix-name
osd: fix name of WaitScrub state of SnapTrimmer
2023-02-08 17:37:13 -06:00
Laura Flores
670a47a852
Merge pull request #47702 from ifed01/wip-ifed-more-pin-fix
os/bluestore: fix onode ref counting.
2023-02-08 17:36:34 -06:00
Casey Bodley
08efcc2536 cls/rgw: remove index entry after cancelling last racing delete op
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-02-08 14:01:37 -05:00
Adam King
e667329274
Merge pull request #49888 from phlogistonjohn/jjm-more-utils-coverage
cephadm: more test coverage for various utils functions

Reviewed-by: Adam King <adking@redhat.com>
2023-02-08 13:45:09 -05:00
Casey Bodley
525899d460 rgw/beast: StreamIO remembers connection errors for graceful shutdown
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-02-08 13:03:55 -05:00
zdover23
04ee67f2f1
Merge pull request #50030 from zdover23/wip-doc-2023-02-09-multisite-to-config-2ndary-zones
doc/rgw: refine multisite to "config 2ndary zones"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-02-09 00:53:10 +10:00
Zac Dover
c3a1770d4c doc/rgw: refine multisite to "config 2ndary zones"
Refine the English in doc/radosgw/multisite.rst up to (but not
including) "Configure Secondary Zones".

https://tracker.ceph.com/issues/58632

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-02-09 00:32:44 +10:00