Commit Graph

136509 Commits

Author SHA1 Message Date
Casey Bodley
525899d460 rgw/beast: StreamIO remembers connection errors for graceful shutdown
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-02-08 13:03:55 -05:00
zdover23
04ee67f2f1
Merge pull request #50030 from zdover23/wip-doc-2023-02-09-multisite-to-config-2ndary-zones
doc/rgw: refine multisite to "config 2ndary zones"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-02-09 00:53:10 +10:00
Zac Dover
c3a1770d4c doc/rgw: refine multisite to "config 2ndary zones"
Refine the English in doc/radosgw/multisite.rst up to (but not
including) "Configure Secondary Zones".

https://tracker.ceph.com/issues/58632

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-02-09 00:32:44 +10:00
Venky Shankar
27158b4afd
Merge pull request #50027 from joscollin/wip-drop-aitalic
cephfs-top: drop curses.A_ITALIC

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-02-08 18:53:45 +05:30
Nizamudeen A
c65085ed88
Merge pull request #50021 from rhcs-dashboard/rename-endpoints
mgr/rgw: rename endpoints to zone_endpoints to match rgw spec

Reviewed-by: rkachach <NOT@FOUND>
2023-02-08 18:37:38 +05:30
Aashish Sharma
3063c8a4fb
Merge pull request #48783 from rhcs-dashboard/fix-grafana-stat-panel
mgr/dashboard: Replace vonage-status-panel with native grafana stat panel


Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-02-08 18:34:30 +05:30
Jos Collin
0cb9dfa4e1
cephfs-top: drop curses.A_ITALIC
Fixes: https://tracker.ceph.com/issues/58663
Signed-off-by: Jos Collin <jcollin@redhat.com>
2023-02-08 15:48:42 +05:30
Pere Diaz Bou
5cb32e8b15
Merge pull request #49627 from rhcs-dashboard/box-podman-osd
cephadm/box: create osds with podman.

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-02-08 11:10:51 +01:00
luo rixin
be753fc93d vstart: correct condition for checking crimson
Signed-off-by: luo rixin <luorixin@huawei.com>
2023-02-08 15:52:34 +08:00
Yingxin Cheng
1bc5827275 crimson/net: fix fmt related compile issue
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
f1ba1a7687 crimson/net: drop and replace __func__
__func__ is meaningless in the lambda function with continuations.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
f99ebd9f14 crimson/net: fixes to print exceptions and errors
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
6a20a68aaf crimson/net: introduce IOHandler class for message and event dispatching
IOHandler also represents the Connection as ConnectionHandler.

ProtocolV2 and IOHandler will be finally running in different cores, as
ProtocolV2 will need to call IOHandler interfaces asynchronously. And
IOHandler will also notify ProtocolV2 through HandshakeListener
asynchronously.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
f60fd12151 crimson/net: cleanups to Protocol and ProtocolV2 interfaces
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
9f107e0ad0 crimson/net: cleanup, rename out_state to io_state
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
9fb5f24924 crimson/net: drop Protocol::print_conn()
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
e95543aa70 crimson/net: move mark_down() from ProtocolV2 to Protocol
Process mark_down in Protocol rather than in ProtocolV2 to prevent
further event dispatching after mark_down is called by user. Then notify
ProtocolV2 as the IO/socket core and handshake core can be different and
the notification can be asynchronous.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
8e7ce94575 crimson/net: move is_connected() from ProtocolV2 to Protocol
Infer is_connected by connection events instead of the protocol V2
internals. That can save a cross-core operation for connection users
from the connection IO core to the handshake core.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
4a5ad0a79d crimson/net: hide dispatchers from ProtocolV2
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
1f473d649a crimson/net: unshare conn for ProtocolV2 and Protocol
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
4fc9db08da crimson/net: make it explict about the FrameAssemberV2 ownership
FrameAssemblerV2 is owned by ProtocolV2 during handshake, and owned by
Protocol during messaging.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
cfd33b7eb3 crimson/net: change out_state_changed to promise<> as it is not shared
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
e1393ad102 crimson/net: move message read path from ProtocolV2 to Protocol
Also move socket shutdown ownership to Protocol at READY/open.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
ff57f47295 crimson/net: move message write path from ProtocolV2 to Protocol
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
7e84140f0d crimson/net: move dispatch ms_handle_connect() before READY
It would be too late to notify connected after the status becomes READY
and open.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
c8578821b4 crimson/net: move intercept_frame() from ProtocolV2 down to FrameAssemblerV2
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
f7b622b231 crimson/net: refactor socket managements
Previously, the socket state is transparent to the protocol and
implicitly handled. Move the responsibilities into protocol for finer
controls to further decouple the IO and handshake.

Also, refactor the fault handling and make the in/out message
dispatching more symmetric.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
f8fe2ad087 crimson/net: fix execution_done wait mechanism
* prepare the execution_done before the function is invoked, not after.
* execution_done future doesn't need to be shared.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
03b732e48a crimson/net: improve logs
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
3471a4b645 test/crimson/test_messenger: change the logger subsys to test
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
a6ecc06584 crimson/net: move ms_handle_accept into the replacing gate
To prevent others to close the connection before the gate, and causing
abort without proper closing the moving socket.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
c8d5a14c22 crimson/net: add aborts when the state is inconsistent
To prevent unexpected event dispatching and state transitions.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
fe7054da22 crimson/net: move remote reset after waiting
And only dispatch the remote reset when the connection is still valid.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
b958da388f crimson/net: introduce and integrate FrameAssemblerV2
FrameAssemblerV2 encapsulates the low-level frame processing for
protocol v2, and manages the socket instance.

FrameAssemblerV2 is supposed to be running on the socket core for
performance reasons, which will be changable.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
fa0ef9e627 crimson/net: split gate for handshake and IO
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
275214692e crimson/net: move close logic from Protocol to ProtocolV2
Protocol class will be removed.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
1ce6acbf49 crimson/net: rename in/out related members and methods
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
f26c1c09fa crimson/net: move IO members into Protocol class
In order to introduce the cross-core IOHandler class.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
0be7365f59 crimson/net: proper group SocketConnection interfaces
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Yingxin Cheng
2ac211c352 crimson/net: move socket from Protocol to SocketConnection
Protocol class will be removed.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2023-02-08 14:07:41 +08:00
Anthony D'Atri
be94fa2b06
Merge pull request #50022 from zdover23/wip-doc-2023-02-08-multisite-maintenance
doc/radosgw: refine "Maintenance" in multisite.rst
2023-02-07 21:11:59 -05:00
Dan Mick
2fd483beed
Merge pull request #50011 from zmc/deps-broken-repos
install-deps.sh: Fail when downloading apt repos
2023-02-07 16:19:05 -08:00
Zac Dover
85816fbca0 doc/radosgw: refine "Maintenance" in multisite.rst
Refine the text in the "Maintenance" section of
doc/radosgw/multisite.rst.

https://tracker.ceph.com/issues/58632

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-02-08 10:12:50 +10:00
Nizamudeen A
252a2d9340 mgr/rgw: rename endpoints to zone_endpoints to match rgw spec
As per the docs (and the codes), the rgw_spec.endpoint should actually
be rgw_spec.zone_endpoint.

```
rgw_realm: myrealm
rgw_zonegroup: myzonegroup
rgw_zone: myzone
zone_endpoints: http://<rgw_host1>:<rgw_port1>, http://<rgw_host2>:<rgw_port2>
```
Refer: https://docs.ceph.com/en/latest/mgr/rgw/#rgw-realm-operations

Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-02-08 00:44:37 +05:30
Redouane Kachach
68fb4eee52
mgr/rgw: fix module crash because of typing_extensions missing
Fixes: https://tracker.ceph.com/issues/58660

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2023-02-07 19:04:57 +01:00
Radoslaw Zarzynski
d4a4ed17bd crimson/osd: fix zeroed starting timestamp of tracked ops
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-02-07 14:22:40 +00:00
Matan Breizman
f4d336a2db crimson/osd/osd_operations: Rename client_request_pg_pipeline
Rename client_request_pg_pipeline to request_pg_pipeline

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-02-07 11:16:07 +00:00
Matan Breizman
e141428949 crimson/osd/osd_operations: Remove replicated_request_pg_pipeline
Use client_request_pg_pipeline instead.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2023-02-07 11:13:19 +00:00
Anthony D'Atri
9754cafc02
Merge pull request #49723 from anthonyeleven/anthonyeleven/58123
ceph: Clarify usage message for admin-socket commands
2023-02-06 19:49:13 -05:00
Zack Cerza
349a92bdb7 install-deps.sh: Fail when downloading apt repos
More specifically, if we get e.g. a 504 while attempting to download a
.list file, fail the build and log the status code.

Signed-off-by: Zack Cerza <zack@redhat.com>
2023-02-06 13:50:46 -07:00