Greg Farnum
24d61fa419
mon: add WARN_UNUSED_RESULT to the MonitorStore functions that return error codes
...
Signed-off-by: Greg Farnum <greg@inktank.com>
2012-11-28 16:28:58 -08:00
Greg Farnum
c762f91a51
mon: remove the silly write_bl_ss write_bl_ss_impl distinction
...
It was introduced at the same time as all these unchecked return codes,
but I can't tell why.
Signed-off-by: Greg Farnum <greg@inktank.com>
2012-11-28 16:28:58 -08:00
Greg Farnum
399f269d4f
mon: convert store users with unchecked return codes to just assert on issues
...
This will make them much more noticeable and reduce the odds of something
writing data which assumes the previous op succeeded.
Signed-off-by: Greg Farnum <greg@inktank.com>
2012-11-28 16:28:58 -08:00
Greg Farnum
ab312f8deb
mon: update Paxos::read()'s successful read check
...
It was returning success if it got back an error code; don't do that!
Signed-off-by: Greg Farnum <greg@inktank.com>
2012-11-28 16:28:58 -08:00
Greg Farnum
3fe7c6cbe0
mon: add new get_bl_[sn|ss]_safe functions
...
These functions are like the non-safe versions, but assert that
there were no disk errors and have void return types. Change a
bunch of callers who weren't checking the return code to use
these variants instead.
(Unfortunately we can't make them default safe because several of
the callers depend on getting back the length, and are perfectly happy
with ENOENT producing a 0 return value.)
Signed-off-by: Greg Farnum <greg@inktank.com>
2012-11-28 16:28:51 -08:00
Greg Farnum
60f60ff738
mon: In MonitorStore, wrap all uses of ::close and assert success
...
Signed-off-by: Greg Farnum <greg@inktank.com>
2012-11-28 16:28:44 -08:00
Alex Elder
dd3a24a647
create qa/workunits/rbd/map-unmap.sh
...
This adds a bash script that creates an rbd image, then repeatedly
maps and unmaps it for a specified duration (5 minutes by default).
Signed-off-by: Alex Elder <elder@inktank.com>
2012-11-28 17:22:49 -06:00
Yehuda Sadeh
6a36ac5bd6
Merge branch 'wip-3532-2'
2012-11-28 13:56:27 -08:00
Yehuda Sadeh
5d6da25c78
rgw: bucket check --check-objects
...
A new option that goes through the indexed objects, verifies
their actual state and updates the index accordingly.
Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
2012-11-28 13:53:29 -08:00
Yehuda Sadeh
e5dc46f6aa
rgw: check_disk_state() removes multipart parts from index
...
Besides suggesting changes to the object's index, we also need
to remove the parts that build the object. This only applies to
parts of multipart objects.
Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
2012-11-28 13:52:44 -08:00
Sage Weil
78286b1403
log: 10,000 recent log entries
...
This is what we were (wrongly) doing before, so there are no memory
utilization surprises.
Signed-off-by: Sage Weil <sage@inktank.com>
2012-11-28 13:00:36 -08:00
Sage Weil
4de7748b72
log: fix log_max_recent config
...
<facepalm>
Signed-off-by: Sage Weil <sage@inktank.com>
2012-11-28 12:59:43 -08:00
Greg Farnum
39b93f5898
mon: check all uses of fsync in the MonitorStore for errors
...
This can sometimes return errors since it's a storage access, and
we're pretty sure ignoring it is the cause of a broken store we've seen.
Signed-off-by: Greg Farnum <greg@inktank.com>
2012-11-28 12:35:11 -08:00
Noah Watkins
88a3e7d148
Makefile: fix libcephfs for gcov and cleanups
...
Adds EXTRALIBS, removes unused CFLAGS.
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Reviewed-by: Joe Buck <jbbuck@gmail.com>
2012-11-28 11:59:45 -08:00
Dan Mick
80c506d4b9
rbd: fix import from stdin, add test
...
Make import work; do I/O in image native block size.
Note: creating sparse images is not currently attempted; could
scan for runs of zeros and write discontiguous chunks to image.
Fixes : #3503
Signed-off-by: Dan Mick <dan.mick@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
(cherry picked from commit c99d9c3ae7
)
2012-11-28 11:45:31 -08:00
Dan Mick
fcebe04801
rbd: allow export to stdout, add tests
...
Fixes : #3502
Signed-off-by: Dan Mick <dan.mick@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
(cherry picked from commit a738f44bc4
)
2012-11-28 11:45:27 -08:00
Sage Weil
a176800396
mon: fix compiler warning
...
signed/unsigned comparison
Signed-off-by: Sage Weil <sage@inktank.com>
2012-11-28 11:11:53 -08:00
Danny Al-Gaaf
653f134785
os/DBObjectMap.h: remove twice included <string>
...
Fix includes: remove twice included <string>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:43 -08:00
Danny Al-Gaaf
e7f8e56228
mds/journal.cc: remove twice included common/config.h
...
Fix includes: remove twice included common/config.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:43 -08:00
Danny Al-Gaaf
1f3e5ad23e
mon/Monitor.cc: remove twice included osd/OSDMap.h
...
Fix includes: remove twice included osd/OSDMap.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:43 -08:00
Danny Al-Gaaf
ec2f261762
messages/MClientRequest.h: remove twice included sys/types.h
...
Fix includes: remove twice included sys/types.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:43 -08:00
Danny Al-Gaaf
34f6d2911a
mount/canonicalize.c: remove twice included string.h
...
Fix includes: remove twice included string.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
54da979d20
common/pipe.c: remove twice included unistd.h
...
Fix includes: remove twice included unistd.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
1341e6d70d
crushtool.cc: remove twice included sys/stat.h
...
Fix includes: remove twice included sys/stat.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
0718c1523f
rgw/rgw_rest.cc: remove twice included rgw_formats.h
...
Cleanup includes: Remove twice included rgw_formats.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
947b33a231
os/DBObjectMap.cc: remove twice included headers
...
Fix includes: remove twice included <string> and <tr1/memory>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
a0d978f615
remove twice included linux/types.h
...
Cleanup includes: remove twice included linux/types.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
238f9321db
rados.cc: remove twice included headers
...
Fix includes: remove twice included common/obj_bencher.h and
common/errno.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
428d974c17
osdmaptool.cc: remove twice included sys/stat.h
...
Fix includes: remove twice included sys/stat.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
93ff160d31
os/IndexManager.cc: remove twice included FlatIndex.h
...
Fix includes: remove twice included FlatIndex.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
aee71e15fb
osd/OSD.h: remove twice included OpRequest.h
...
Fix includes: remove twice included OpRequest.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
03a4c8c940
tools/common.cc: remove twice included headers
...
Cleanup includes: Remove twice included sys/stat.h and osd/OSDMap.h.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
82c1f48b74
mds/Resetter.h: remove twice included msg/Messenger.h
...
Fix includes: remove twice included msg/Messenger.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
428f300fd4
mds/Migrator.cc: remove twice included Migrator.h
...
Fix includes: remove twice included Migrator.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:42 -08:00
Danny Al-Gaaf
abc8cb68dc
mds/Dumper.h: remove twice included msg/Messenger.h
...
Fix includes: remove twice included msg/Messenger.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:41 -08:00
Danny Al-Gaaf
e1431b8e2e
librados/RadosClient.cc: remove twice included sys/stat.h
...
Fix includes: remove twice included sys/stat.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:41 -08:00
Danny Al-Gaaf
1ca3d75644
include/buffer.h: remove twice included stdio.h
...
Fix includes: remove twice included stdio.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:41 -08:00
Danny Al-Gaaf
9ac063a80f
monmaptool.cc: remove twice included sys/stat.h
...
Fix includes: remove twice included sys/stat.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:41 -08:00
Danny Al-Gaaf
8a19b89c8d
client/SyntheticClient.cc: remove twice included headers
...
Fix includes: remove twice included common/config.h and sys/types.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:32 -08:00
Danny Al-Gaaf
f814afad70
fusetrace_ll.cc: remove twice included sys/time.h
...
Fix includes: remove twice included sys/time.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:32 -08:00
Danny Al-Gaaf
3fa561eb1e
ceph_syn.cc: remove twice included sys/stat.h
...
Fix includes: remove twice included sys/stat.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:32 -08:00
Danny Al-Gaaf
8a6278ecc9
ceph_osd.cc: remove twice included sys/stat.h
...
Fix includes: remove twice included sys/stat.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:32 -08:00
Danny Al-Gaaf
5fb2185c03
client/MetaRequest.cc: remove twice included client/Dentry.h
...
Fix includes: remove twice included client/Dentry.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:32 -08:00
Danny Al-Gaaf
f8ef4a88ec
client/Client.cc: remove twice included headers
...
Fix includes: remove twice included common/config.h". Remove include
of sys/param.h in special __FreeBSD__ section, since this file is
included in general anyway
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:32 -08:00
Danny Al-Gaaf
c753f58eb9
ceph_mds.cc: remove twice included sys/stat.h
...
Fix includes: remove twice included sys/stat.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:32 -08:00
Danny Al-Gaaf
1c0c055876
ceph_fuse.cc: remove twice included sys/stat.h
...
Fix includes: remove twice included sys/stat.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:30 -08:00
Danny Al-Gaaf
f65307a048
ceph_mon.cc: remove twice included sys/stat.h
...
Fix includes: remove twice included sys/stat.h
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2012-11-28 08:25:29 -08:00
Sage Weil
43ef8c10ba
mon: do not crash on invalid 'mon tell N ...' target
...
Fixes : #3545
Signed-off-by: Sage Weil <sage@inktank.com>
2012-11-27 20:51:03 -08:00
Dan Mick
c99d9c3ae7
rbd: fix import from stdin, add test
...
Make import work; do I/O in image native block size.
Note: creating sparse images is not currently attempted; could
scan for runs of zeros and write discontiguous chunks to image.
Fixes : #3503
Signed-off-by: Dan Mick <dan.mick@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
2012-11-27 17:29:23 -08:00
Dan Mick
a738f44bc4
rbd: allow export to stdout, add tests
...
Fixes : #3502
Signed-off-by: Dan Mick <dan.mick@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
2012-11-27 17:29:16 -08:00