Commit Graph

129608 Commits

Author SHA1 Message Date
Neha Ojha
75c4960abf
Merge pull request #44878 from aclamk/fix-git-id-aclamk
github: fix id and mail

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-02-03 09:39:13 -08:00
Joseph Sawaya
606939cbf2 crimson/os/seastore: change segment_off_t to seastore_off_t
Signed-off-by: Joseph Sawaya <josephsawaya938@gmail.com>
2022-02-03 11:49:25 -05:00
Patrick Donnelly
d341c5b773
mds: add inline feature to MDS bootstrap incompat
File systems that had inline data enabled at some point would have this
bit in the CompatSet "incompat" set. This would conflict during upgrade
with the default v16.2.4 CompatSet assigned to existing (16.2.4-) MDS.
Subsequently, this would cause an assertion in FSMap::sanity during
pending map creation.

This bit will get added anyway during the upgrade process so might as
well add it to the MDS CompatSet during bootstrap.

Fixes: https://tracker.ceph.com/issues/54081
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-03 11:02:02 -05:00
Patrick Donnelly
e2c461e02a
mds: throw some feature definitions in static memory
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-03 11:02:02 -05:00
Patrick Donnelly
445cdd4120
qa: test inline compat set on older MDSMap
Reproduced here:

    /ceph/teuthology-archive/pdonnell-2022-01-31_19:13:02-fs:upgrade-master-distro-default-smithi/6651572/teuthology.log

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-03 11:01:59 -05:00
Patrick Donnelly
547b21c0de
doc: document PI .qa symlinks
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-03 10:08:30 -05:00
Patrick Donnelly
1f714da814
qa: fix or add missing .qa links
Using this command:

    find qa/suites/ -type d -execdir ln -sfT ../.qa/ {}/.qa \;

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-03 10:08:30 -05:00
Patrick Donnelly
ec6cd23b20
qa: move .qa terminator
So links can be elsewhere in the qa suite (not used yet) and to simplify
a find command in a follow-up commit.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-03 10:08:30 -05:00
Adam Kupczyk
caa5a8ae62 github: fix id and mail
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
2022-02-03 15:43:41 +01:00
Arthur Outhenin-Chalandre
8ff1e6b399
monitoring: build jsonnet/jb only for testing
Build jsonnet and jb in the testso that we can build ceph without
internet access and still be able to run the test needed for monitoring
using jsonnet tools.

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
2022-02-03 13:08:37 +01:00
Arthur Outhenin-Chalandre
ecaf9070ae
spec: debian: monitoring: build jsonnet from source to use 0.18.0
As this new version is recently released it's still not in every distro
we use. We now build jsonnet from source so that we can use this new
version of jsonnet. This commit could be reverted later on when the new
version would be available everywhere.

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
2022-02-03 13:08:36 +01:00
Arthur Outhenin-Chalandre
98236e3a1d
mgr/dashboard: monitoring: refactor into ceph-mixin
Mixin is a way to bundle dashboards, prometheus rules and alerts into
jsonnet package. Shifting to mixin will allow easier integration with
monitoring automation that some users may use.

This commit moves `/monitoring/grafana/dashboards` and
`/monitoring/prometheus` to `/monitoring/ceph-mixin`. Prometheus alerts
was also converted to Jsonnet using an automated way (from yaml to json
to jsonnet). This commit minimises any change made to the generated files
and should not change neithers the dashboards nor the Prometheus alerts.

In the future some configuration will also be added to jsonnet to add
more functionalities to the dashboards or alerts (i.e.: multi cluster).

Fixes: https://tracker.ceph.com/issues/53374
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
2022-02-03 13:08:20 +01:00
Arthur Outhenin-Chalandre
e102620394
spec: debian: add golang as build dependency
Add golang as a build dependency to build golang project in the test
for monitoring/ceph-mixin.

Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
2022-02-03 09:49:55 +01:00
Mykola Golub
02c6a56f49 rgw: check bucket shard init status in RGWRadosBILogTrimCR
to avoid using not properly initialized bs.bucket_obj.

Fixes: https://tracker.ceph.com/issues/54119
Signed-off-by: Mykola Golub <mgolub@suse.com>
2022-02-03 08:16:20 +00:00
Pere Diaz Bou
6c0c75fa17
Merge pull request #44812 from rhcs-dashboard/box-remove-error
cephadm/box: fix remove image tar error
2022-02-03 07:49:46 +01:00
Yingxin
18618bf6d4
Merge pull request #44832 from cyx1231st/wip-crimson-msgr-test-timeout
test/crimson/test_messenger: increase timeout

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-02-03 11:56:38 +08:00
Laura Flores
5ac1dd6866 mgr/telemetry: compare len(values) to len(categories)
This format will allow us to safely add or remove
categories as needed in the future.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-02-03 00:03:07 +00:00
Laura Flores
c617b78f7b mgr/telemetry: collect what we can from heap stats, mempools, and osd histograms
If we run into a problem collecting heap stats, mempools,
or osd histograms from a particular osd (i.e. the osd is down),
we should continue to collect what we can from other osds rather
than exiting and returning an empty JSON object.

Some log messages are also refined.

Fixes: https://tracker.ceph.com/issues/53985
Signed-off-by: Laura Flores <lflores@redhat.com>
2022-02-03 00:02:51 +00:00
Neha Ojha
8ca5729d21 qa/suites/rados/thrash-old-clients: remove centos_8.3_container_tools_3.0
Signed-off-by: Neha Ojha <nojha@redhat.com>
2022-02-02 23:26:54 +00:00
Laura Flores
4a2b54c1f2 doc/mgr: update telemetry doc to reflect basic_pool_usage collection
Signed-off-by: Laura Flores <lflores@redhat.com>
2022-02-02 23:08:53 +00:00
Laura Flores
7467ed59ac mgr/telemetry: fix perf channel to screen out non-default pool applications
Signed-off-by: Laura Flores <lflores@redhat.com>
2022-02-02 23:08:11 +00:00
Laura Flores
285d14457c mgr/telemetry: add stats_by_class to the basic_pool_usage collection
Any device classes that are not default ('hdd', 'ssd', 'nvme') are screened out.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-02-02 23:06:43 +00:00
Laura Flores
ee63d624ba mgr/telemetry: add df stats to the basic_pool_usage collection
The `df` stats under `pools` indicate data usage for each pool.
The `kb_bytes` field is screened out since it is redundant.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-02-02 23:02:01 +00:00
Laura Flores
1f571cd425 mgr/telemetry: create basic_pool_usage collection
Here, I define the `basic_pool_usage` collection and add
pool application under the basic channel. I screen out
any applications that are not default.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-02-02 22:57:38 +00:00
Neha Ojha
77b0791760 qa/distros/container-hosts: remove centos_8.2 and centos_8.3
Related to https://tracker.ceph.com/issues/54087

Signed-off-by: Neha Ojha <nojha@redhat.com>
2022-02-02 20:03:33 +00:00
Neha Ojha
8f1d1b7c55 qa/distros/podman: remove centos_8.2 and centos_8.3
Related to https://tracker.ceph.com/issues/54087

Signed-off-by: Neha Ojha <nojha@redhat.com>
2022-02-02 20:02:48 +00:00
Adam Kupczyk
372bda3509 os/bluestore/bluefs: Make volume selector operations atomic
Make all RocksDBBlueFSVolumeSelector files/extents/size tracking atomic.
It used to be synchronized by BlueFS global lock.
Now, in Fine Grain Locking era, it is necessary to prevent corruption.

Fixes: https://tracker.ceph.com/issues/53906

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
2022-02-02 20:30:09 +01:00
Adam Kupczyk
d233e3b1d2 os/bluestore/bluefs: Code for volume selector check
Adds ability to verify that volume selector properly tracks disk usage.
Creates options:
- bluefs_check_volume_selector_on_umount
- bluefs_check_volume_selector_often
that can be used to validate that vselector does not diverge from
values it should have.

Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
2022-02-02 20:30:09 +01:00
Soumya Koduri
9dfe5ac714 rgw/qa: Add test suite for lifecycle cases
Execute lifecycle s3-tests in the teuthology test-suite by configuring
required storage classes and 'rgw lc debug interval' option.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2022-02-03 00:16:03 +05:30
Ernesto Puerta
c47ace9215
Merge pull request #43707 from BenoitKnecht/ceph-mgr-service-id
mgr: Fix ceph_daemon label in ceph_rgw_* metrics

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-02-02 18:39:57 +01:00
Patrick Donnelly
0fcf8922dc
qa: update rhel kclient to setup container tools
To fix [1,2].

[1] https://github.com/ceph/ceph/pull/42000#issuecomment-905628920
[2] https://github.com/ceph/ceph/pull/42000#issuecomment-906276775

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-02 10:44:35 -05:00
Patrick Donnelly
fb75ed6d39
qa: stop overriding distro for k-testing
This is a continuation of previous commit

    qa: only use RHEL for workload testing

We don't want to test fs:workload with centos/ubuntu to avoid packaging
issues and to reduce the matrix of distros we're running workloads on.
Also, the testing kernel should install fine on the distros we test with
"supported" random distros.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-02 10:44:35 -05:00
Patrick Donnelly
017ccd21e6
qa: only use RHEL for workload testing
It's not useful testing workloads with different distributions; it just
adds to the maintenance burden of this qa suite as distro upgrades often
break compilation of various tests.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-02 10:44:35 -05:00
Patrick Donnelly
405bb2e48e
qa: convert fs:workload to use cephadm
Note: it's important to keep the install task which supplies packages
needed for some workloads.

Fixes: https://tracker.ceph.com/issues/51333
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-02 10:44:35 -05:00
Patrick Donnelly
50c39dc007
qa: split fs begin task
To allow switching to cephadm task.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-02 10:44:35 -05:00
Patrick Donnelly
27c1110129
qa/tasks/cephadm: setup CephManager when OSDs are provisioned
The Filesystem object may use this when configuring EC data pools at
file system creation (via a FuseMount).

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-02 10:44:34 -05:00
Patrick Donnelly
2436405c5d
qa/tasks/cephadm: setup file system if MDS are provisioned
This is the same behavior/code as what the ceph task does.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2022-02-02 10:44:34 -05:00
Yingxin Cheng
82af52e8b7 test/crimson/test_messenger: increase timeout
120 seconds are still too short for make check, change to 300.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-02-02 23:24:49 +08:00
Yuval Lifshitz
bd429ed9be rgw/admin: fix radosgw-admin datalog list max-entries issue
Fixes: https://tracker.ceph.com/issues/54116

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2022-02-02 16:53:21 +02:00
Ernesto Puerta
8505861220
Merge pull request #44609 from rhcs-dashboard/daemon_action
mgr/dashboard: perform daemon actions

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-02-02 14:06:57 +01:00
Nizamudeen A
8feb2b8fe0 doc: update dashboard kcli test env documentation
Fixes: https://tracker.ceph.com/issues/54105
Signed-off-by: Nizamudeen A <nia@redhat.com>
2022-02-02 13:50:00 +05:30
Casey Bodley
12d23d3f63 qa/rgw: install s3cmd with extra_system_packages
this was preventing installation on ubuntu because of
https://tracker.ceph.com/issues/25026

Fixes: https://tracker.ceph.com/issues/54103

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-02-01 10:39:18 -05:00
Casey Bodley
40a7174491
Merge pull request #44850 from cbodley/wip-qa-rgw-centos8-eol
qa/rgw: rgw/verify no longer pins centos 8.0

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2022-02-01 10:18:13 -05:00
Adam King
d5a8ef292d
Merge pull request #44810 from rkachach/fix_doc_issue_54018
doc/cephadm: fixing cluster purging section

Reviewed-by: Adam King <adking@redhat.com>
2022-02-01 08:25:11 -05:00
Ilya Dryomov
9dbcf6ab28
Merge pull request #44834 from idryomov/wip-rbd-image-id-spec
mgr/rbd_support: fix mon command API regressions

Reviewed-by: Mykola Golub <mgolub@suse.com>
2022-02-01 12:08:02 +01:00
Pere Diaz Bou
71c493528e cephadm/box: fix remove image tar error and cleanups
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-02-01 08:48:58 +01:00
Neha Ojha
e2f0fea57f
Merge pull request #44820 from NitzanMordhai/nitzan-add-email-contact
Nitzan add email contact

Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-01-31 19:08:13 -08:00
Matt Benjamin
c8291d9662 rgwlc: add cls_rgw_lc_get_entry_ret to rgw_types.h (dencoder)
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2022-01-31 19:17:36 -05:00
Casey Bodley
36711cc49c
Merge pull request #44408 from linuxbox2/wip-rgwlc-warn-attr
rgwlc:  warn on missing RGW_ATTR_LC

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2022-01-31 17:49:35 -05:00
Casey Bodley
0fad609d4d qa/rgw: rgw/verify no longer pins centos 8.0
the symlink rgw/verify/centos_latest.yaml already selects centos

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-01-31 17:23:27 -05:00