RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-10 05:00:59 +00:00
Code Issues Packages Projects Releases Wiki Activity
86,714 Commits 213 Branches 0 Tags 1.2 GiB
dd46ae1006
Commit Graph

86714 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Adam C. Emerson
5bfcd2335b test/libcephfs: Expand buffer slightly 
So the snprintf output isn't truncated.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
389538f356 rgw: There is no point in const return values 
Pointer-to-const or reference-to-const yes. Const value, no.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
25f6b63949 rgw: Catch exceptions at const references 
/Never/ by value.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
46b40274d4 rgw: Remove extra 'const' from cast 
Casting to pointer-to-const makes sense. Casting to a const
value (even a const pointer) doesn't.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
7a551495d9 rdma: Silence qualifier warnings 
No point in reinterpret_casting something const anyway, you can always
assign non-const to const.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
7fcfb60170 msg/rdma/infiniband: Silence memset warning 
Though it may be better in the long-run to replace the malloc-like
interface with an Allocator type interface.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
1065d7996e rgw: Exceptions should be caught by const reference 
/Not/ by value.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
4365b1d358 FuseStore: Expand buffers to prevent overflow 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
a0d15b915f perfglue: Silence truncation warning 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
5ef603f388 mount: Enlarge buffer to fix overflow warning 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
cfd425e319 mon: Remove unused variable 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
1683aed539 blkdev: Check return of snprintf and error on truncation 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
ef8465c2a5 blkdev: Get rid of get_device_by_uuid 
This function's interface is bad, in that it takes char*s with no
sizes. Also nobody calls it.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
d55048146a test: Enlarge a few buffers 
To get rid of overflow warnings.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
8dffe4eb95 mds: Do not memset fnode_t 
fnode_t can initialize itself.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
6e8188498e auto: Catch exceptions by const reference 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
d5adb05a24 client: Do not memset frag_info_t and inode_t 
They do a perfectly good job of initializing themselves.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
5811a396e6 test: Increase buffer to prevent possible truncation 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Adam C. Emerson
27e95a4144 rgw: Fix uninitialized value warning 
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
 2018-05-09 13:26:29 -04:00
Venky Shankar
c007bdff75 doc: fix iscsi target name when configuring target 
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 3b2d739e4c)
 2018-05-09 13:18:48 -04:00
Jason Dillaman
890ee7ea12
Merge pull request #21906 from vshankar/iscsi-target-cli-typo 
doc: fix iscsi target name when configuring target

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
 2018-05-09 10:17:51 -07:00
Jason Dillaman
486483881a rbd: disk-usage can now optionally compute exact on-disk usage 
Fixes: http://tracker.ceph.com/issues/24064
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
 2018-05-09 13:13:56 -04:00
Jason Dillaman
46eafdabde rbd: don't load config overrides from monitor initially 
The overrides will be loaded when we connect to the cluster via librados
and the current approach prevents running 'rbd help' without a running
cluster.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
 2018-05-09 12:37:22 -04:00
Adam C. Emerson
89d1de6245
Merge pull request #20974 from XiangxiangMeng/rgw-policy-keyword-modify 
rgw: policy: modify some operation permission keyword

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
 2018-05-09 12:28:22 -04:00
Jason Dillaman
43dbdb9d29 mon: pool-ops against non-existent pools should return error 
Fixes: http://tracker.ceph.com/issues/24000
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
 2018-05-09 11:45:51 -04:00
Jason Dillaman
43f7b17129 osdc: self-managed snapshot helper should catch decode exception 
Fixes: http://tracker.ceph.com/issues/24000
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
 2018-05-09 11:31:41 -04:00
Venky Shankar
3b2d739e4c doc: fix iscsi target name when configuring target 
Signed-off-by: Venky Shankar <vshankar@redhat.com>
 2018-05-09 20:43:59 +05:30
Casey Bodley
d1e3430bc3
Merge pull request #21788 from cbodley/wip-22914 
rgw: bucket sync status improvements, part 1

Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
 2018-05-09 11:06:40 -04:00
Tatjana Dehler
fdda18725c
Merge pull request #21855 from votdev/fix_rgw_backend_mimic 
mimic: mgr/dashboard: Refactor RGW backend

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
 2018-05-09 16:59:32 +02:00
Tatjana Dehler
f4ebfb343d
Merge pull request #21851 from votdev/improve_error_panel 
mgr/dashboard: Improve error panel

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
 2018-05-09 16:49:03 +02:00
Erwan Velu
d501c7b33a ceph-disk: get_partition_dev() should fail until get_dev_path(partname) is populated 
get_partition_dev() is a function called to get a block device path.

The @retry decorator implements a timeout mecanism as it exist a race
between the partition creation command and the actual presence of the
partition.

This function have a semantic issue.
The function is asked if /dev/sda6 exists but check if /sys/block/sda/sda6 exists.
Once /sys/block/sda/sda6 is populated within the timeout, the function returns "/dev/sda6".
But this doesn't check if "/dev/sda6" really exists, so a function
using this value fall into a race condition and fails too.

We do have this case inside the CI where timing are very variable
regarding the workload and VM's performance and even sometimes nasted VMs.

This patch offer to double-check before returning that the actual /dev/
entry actually exist once the BLOCKDIR (/sys) is populated. If not, the
@retry is triggered to let some time resolution this temporary situation.

If this state is permanent, an explicit error message is reported like :
    /dev/sdb1 is not populated while /sys/block/sdb has it

Signed-off-by: Erwan Velu <erwan@redhat.com>
 2018-05-09 16:33:51 +02:00
John Spray
23583ccc25 osd: write "bench" output to stdout 
...not stderr.  Seems more reasonable as this
command is essentially feeding back a measurement result,
rather than just commenting on its status

Fixes: http://tracker.ceph.com/issues/24022
Signed-off-by: John Spray <john.spray@redhat.com>
 2018-05-09 15:19:18 +01:00
Kefu Chai
2fc5c1a95d
Merge pull request #21835 from tchaikov/mimic-23921 
mimic: crush, osd: handle multiple parents properly when applying pg upmaps

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
 2018-05-09 22:08:52 +08:00
Wido den Hollander
d15d510bab
mgr/telegraf: Telegraf module for Ceph Mgr 
Telegraf is a agent for collecting and reporting metrics.

It has multiple inputs and can send data to various outputs like
for example InfluxDB or ElasticSearch.

This module works by using the socket_listener of Telegraf and can
send data over UDP, TCP and a local Unix Socket.

Signed-off-by: Wido den Hollander <wido@42on.com>
 2018-05-09 16:00:15 +02:00
Jason Dillaman
d35bc94319 rbd-mirror: ensure remote demotion is replayed locally 
The bootstrap process cannot immediately quit if it notices the remote
image is not primary. Instead, it needs to continue if the local image is
still chained to the remote.

Fixes: http://tracker.ceph.com/issues/24009
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
 2018-05-09 09:42:40 -04:00
Casey Bodley
61516bcfac cmake: move crypto_plugins target 
the crypto_plugins target was defined in
src/crypto/isa-l/CMakeLists.txt, but this is only included
if(HAVE_INTEL AND HAVE_BETTER_YASM_ELF64 AND (NOT APPLE))

moving it out of the if() block allows the os target to depend on it
even if no plugins are built

Signed-off-by: Casey Bodley <cbodley@redhat.com>
 2018-05-09 09:06:55 -04:00
Kefu Chai
7fbb485138 osdc: guard op->on_notify_finish with lock 
Fixes: http://tracker.ceph.com/issues/23966
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit c16371965c)
 2018-05-09 21:04:08 +08:00
Kefu Chai
1b380399f7
Merge pull request #21834 from tchaikov/mimic-23966 
mimic: osdc: guard op->on_notify_finish with lock

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
 2018-05-09 21:03:50 +08:00
Jason Dillaman
855faac169 librados: fix potential race condition if notify immediately fails 
Fixes: http://tracker.ceph.com/issues/23966
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit cc06fbab08ef5b7f1b18f2af333c019ad86de03d)
 2018-05-09 20:23:38 +08:00
Jason Dillaman
0b8bd36b3d osdc: invoke notify finish context on linger commit failure 
Fixes: http://tracker.ceph.com/issues/23966
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit fcd414f632)
 2018-05-09 20:23:38 +08:00
Kefu Chai
84aaeb3c5e
Merge pull request #21609 from dragonylffly/wip-fix-create-ioctx 
librados: return ENOENT if pool_id invalid

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
 2018-05-09 20:20:54 +08:00
Kefu Chai
a2f7d73b44
Merge pull request #21830 from tchaikov/mimic-qa-cephfs-snap 
mimic: qa: fix test on "ceph fs set cephfs allow_new_snaps"

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
 2018-05-09 20:12:13 +08:00
Kefu Chai
5884eb24ef
Merge pull request #21859 from dillaman/wip-23966-mimic 
librados: fix potential race condition if notify immediately fails

Reviewed-by: Kefu Chai <kchai@redhat.com>
 2018-05-09 20:10:00 +08:00
Casey Bodley
d9284902e1 rgw: use coarse_real_clock for req_state::time 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
 2018-05-09 08:02:32 -04:00
Volker Theile
063f1372c9
Merge pull request #21882 from sebastian-philipp/dashboard-run-backend-api-request-insecure 
mgr/dashboard: Allow insecure HTTPS in run-backend-api-request

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
 2018-05-09 13:54:18 +02:00
Volker Theile
90bc97da17
Merge pull request #21820 from tspmelo/wip-ui-error-handling 
mgr/dashboard: Add error handling on the frontend

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
 2018-05-09 13:35:07 +02:00
Volker Theile
78102cabcb
Merge pull request #21819 from tspmelo/wip-prettier 
mgr/dashboard: Add Prettier formatter to the frontend

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
 2018-05-09 13:28:42 +02:00
Tiago Melo
9b3cc51dbe mgr/dashboard: Add Prettier formatter to the frontend 
This will force the use of prettier on frontend code,
bringing a more consistent formatting to all the code.

The current configuration will apply the prettier formatting,
on all staged files, during the precommit hook.

Signed-off-by: Tiago Melo <tmelo@suse.com>
 2018-05-09 11:20:24 +01:00
Ricardo Marques
ee80c7b2ae
Merge pull request #21643 from s0nea/wip-dashboard-configurations-table 
mgr/dashboard: replace configuration html table with cd-table

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
 2018-05-09 10:51:09 +01:00
Ricardo Marques
424a9f1406
Merge pull request #21777 from votdev/proxy_conf_ssl 
mgr/dashboard: Use HTTPS in dev proxy configuration and HACKING.rst

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
 2018-05-09 10:37:12 +01:00