Commit Graph

122001 Commits

Author SHA1 Message Date
Paul Cuzner
7082232800 mgr/prometheus:Improve the pool metadata
Adds percent_used and used_bytes to the per pool
metrics group, and add additional labels to the ceph_pool_metadata
metric
- compression_mode - so consumers can tell whether compression
  is active
- description - provide a text string showing the protection
  scheme of the pool (e.g. replica2, or ec:4+2
- type - text string showing replicated or erasure enabling
  easy filtering across the pools

These additional fields allow compression savings to be more
easily shown. The inclusion of percent_used ensures that any
prometheus based view of pool usage will ALWAYS match the CLI.

Fixes: https://tracker.ceph.com/issues/49049

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-04-08 09:07:01 +12:00
Adam C. Emerson
e866d1954b
Merge pull request #40632 from adamemerson/wip-warnless-4now
Warning Cleanup and Clang Compile Fix

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2021-04-07 16:38:22 -04:00
Kalpesh
42d87989e9 rgw/test: Changing force-branch to master
This PR includes 2 things:
1. Changing force-branch to master and removing the git-remote. This change was forgetten for PR #39139.
2. Proper cleanup/removal after completion of commands more precisely removing the kafka logs directory.

Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
2021-04-08 01:37:29 +05:30
Adam C. Emerson
f9307c60aa test/osd: Change const copy in loop to const reference
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-04-07 13:29:09 -04:00
Adam C. Emerson
f82805a83b rgw: Fix brace-enclosed-scalar warning
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-04-07 13:29:08 -04:00
Adam C. Emerson
607da6aa09 rgw: Fix warnings from s3select
Since this is a submodule, just wrap the include in a pragma.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-04-07 13:29:08 -04:00
Adam C. Emerson
ce91460884 rgw: Remove unused variables
(Also mark the file as C++ rather than C)

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-04-07 13:29:08 -04:00
Adam C. Emerson
1e6225cadb test/librados: Remove unused capture
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-04-07 13:29:08 -04:00
Adam C. Emerson
2a65dcb4c8 rbd: Fix ambiguous call to addr.parse
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-04-07 13:28:05 -04:00
Adam C. Emerson
aee46aaa50 rgw: Fix signed comparison warning
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-04-07 13:28:02 -04:00
Adam C. Emerson
f483f161d6 test/librados: Disambiguate function call
Cleaning up a warning.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-04-07 13:25:00 -04:00
Adam C. Emerson
ff99ed6357 rgw: Add missing extension to file in sources list
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2021-04-07 13:20:11 -04:00
J. Eric Ivancich
116ef52566
Merge pull request #38737 from IlsooByun/objmeta-key-underscore
rgw: keep underscore in metatdata key

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2021-04-07 12:31:37 -04:00
J. Eric Ivancich
951e1e2e42
Merge pull request #39749 from linuxbox2/wip-olock-fixes
rgw: objectlock: improve client error messages

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-04-07 12:31:10 -04:00
J. Eric Ivancich
de725023c4
Merge pull request #40263 from ivancich/wip-update-listing-comments
rgw: update bucket listing log output

Reviewed-by: Ali Maredia <amaredia@redhat.com>
2021-04-07 12:30:47 -04:00
Neha Ojha
88b947f07b
Merge pull request #40570 from zdover23/wip-doc-mclock-rewrite-first-half-2021-Apr-2
doc/rados: rewrite mclock-config-ref

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
2021-04-07 08:53:35 -07:00
Casey Bodley
b97954f888
Merge pull request #40639 from yuvalif/wip-yuval-fix-50201
rgw/multisite: return correct error code when op fails

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-04-07 11:03:34 -04:00
Guillaume Abrioux
6602eb7e7c doc/cephadm: fix a typo
This fixes a small typo in the cephadm/iscsi documentation

s/iSCSI Ganesha gateway/iSCSI gateway/

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2021-04-07 17:02:05 +02:00
Radoslaw Zarzynski
cb3dc1515c crimson/osd: fix broken debug in Notify::send_completion().
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-07 14:35:28 +00:00
Kefu Chai
39b2b5edc0 qa/tasks/mgr: skip test_diskprediction_local on python>=3.8
query the python version before trying to test diskprediction_local

Fixes: https://tracker.ceph.com/issues/50196
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-07 21:27:44 +08:00
胡玮文
9a864f086b cephadm: cleanup extra slash in runtime dir
%t already contains a slash, no need to add an extra one

Signed-off-by: 胡玮文 <huww98@outlook.com>
2021-04-07 21:25:10 +08:00
Kefu Chai
a866516a95
Merge pull request #40581 from weixinwei/master
os/bluestore/BlueFS: do not _flush_range deleted files

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2021-04-07 21:18:01 +08:00
Casey Bodley
4bf2ea2f70
Merge pull request #40601 from cbodley/wip-50147
qa/rgw: move ignore-pg-availability.yaml out of suites/rgw

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2021-04-07 08:49:49 -04:00
Xiubo Li
89c5113561 client: don't allow access to MDS-private inodes
Fixes: https://tracker.ceph.com/issues/50112
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2021-04-07 19:53:15 +08:00
Rishabh Dave
0e1d9caa0f
Merge pull request #39907 from guits/fix_get_first_lv
ceph-volume: `get_first_lv()` refactor
2021-04-07 17:02:05 +05:30
Ilya Dryomov
dc55f0bb43 packaging: require ceph-common for immutable object cache daemon
This daemon has a systemd service which starts it with --setuser ceph
--setgroup ceph.  "ceph" user and group are created by ceph-common and
won't be there unless ceph-common is installed.

Fixes: https://tracker.ceph.com/issues/50207
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-04-07 13:11:23 +02:00
Ernesto Puerta
caee16b814
Merge pull request #40624 from rhcs-dashboard/read-only-config-access-disable
mgr/dashboard: Revoke read-only user's access to Manager modules 

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2021-04-07 13:04:28 +02:00
Kefu Chai
91bc0e54ab mgr/selftest: add a command for querying python version
so the test driver can skip certain tests based on the version of python
runtime on the test node

Fixes: https://tracker.ceph.com/issues/50196
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-04-07 19:01:46 +08:00
Yuval Lifshitz
83e89dfa33 rgw/multisite: return correct error code when op fails
when trying to disable/enbale sync on non-master zone

Fixes: https://tracker.ceph.com/issues/50201

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2021-04-07 12:51:30 +03:00
Guillaume Abrioux
a5e4216b49 ceph-volume: get_first_*() refactor
As indicated by commit 17957d9beb those
fuctions were meant to avoid writing something like following:

```
lvs = get_lvs()
if len(lvs) >= 1:
	lvs = lv[0]
```

Those functions should return `None` if 0 or more than 1 item is returned.
The current name of these functions are confusing and can lead to thinking that
we just want the first item returned, even though it returns more than 1
item, let's rename them to `get_single_pv()`, `get_single_vg()` and
`get_single_lv()`

Closes: https://tracker.ceph.com/issues/49643

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
2021-04-07 09:13:39 +02:00
Ronen Friedman
79c5b078e6
Merge pull request #40637 from ronen-fr/wip-ronenf-rgw-logbacking
rgw: fix lambda capture of a non-variable
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2021-04-07 10:13:01 +03:00
Kefu Chai
c76940977e
Merge pull request #40604 from liewegas/podman-registries-conf
qa/distros/podman: preserve registries.conf

Reviewed-by: David Galloway <dgallowa@redhat.com>
2021-04-07 15:12:24 +08:00
Kefu Chai
c6e8fc5933
Merge pull request #40487 from tchaikov/wip-boost-1.75
install-deps.sh: install boost 1.75

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-04-07 15:10:34 +08:00
Kefu Chai
bb45bf90a6
Merge pull request #40583 from a16bitsysop/include
tools/cephfs_mirror/PeerReplayer.cc: add missing include

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-04-07 15:07:34 +08:00
Kefu Chai
2b8551a58f
Merge pull request #40607 from tchaikov/wip-journald-if-msghdr
common: disable journald logging backend if struct msghdr is not found

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2021-04-07 15:06:25 +08:00
Kefu Chai
e0f96a6829
Merge pull request #40609 from tchaikov/wip-common-buffer-cleanup
common/buffer.cc: use shift_round_up() when appropriate

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-04-07 15:05:23 +08:00
Xiubo Li
eb89c464ae mds: do not show the default auth if it's unambiguous
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2021-04-07 14:04:36 +08:00
Xiubo Li
4f63998185 mds: switch to rank number instead
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2021-04-07 14:04:36 +08:00
Ronen Friedman
6016ae0f46 rgw: fix lambda capture of a non-variable
One cannot just capture a structured binding "non-variable".

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2021-04-07 08:47:36 +03:00
Ronen Friedman
c57731d3ce Revert "osd: Try other PGs when reservation failures occur"
This reverts commit 08c3ede084.

Due to https://tracker.ceph.com/issues/49868
Should be reinstated once that bug is solved. See tracker comments for analysis
and suggested fixes.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2021-04-07 08:38:17 +03:00
Ronen Friedman
b8045f7b18 Revert "test: Add test for scrub parallelism"
This reverts commit dd63577ab3.

As 08c3ede084 (the tested functionality) is reverted.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2021-04-07 08:37:03 +03:00
weixinwei
744bd5271c os/bluestore/BlueFS: do not _flush_range deleted files
Fixes: https://tracker.ceph.com/issues/49861
Signed-off-by: weixinwei <weixw3@lenovo.com>
2021-04-07 10:58:06 +08:00
Sage Weil
9e96806aea Merge PR #40603 into master
* refs/pull/40603/head:
	qa/tasks/ceph.conf: shorten cephx TTL for testing

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2021-04-06 17:28:08 -04:00
Casey Bodley
fb760da0ed
Merge pull request #40190 from cbodley/wip-qa-rgw-sigv4-warnings
rgw: silence some unused variable warnings

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2021-04-06 16:08:28 -04:00
Sage Weil
3b391cbf7a Merge PR #40602 into master
* refs/pull/40602/head:
	qa/tasks/cephadm: add apply() method/task

Reviewed-by: Sebastian Wagner <swagner@suse.com>
2021-04-06 16:04:27 -04:00
Sage Weil
2218c9473f Merge PR #40597 into master
* refs/pull/40597/head:
	cephadm: pass '-i' to docker|podman run for shell|enter

Reviewed-by: Adam King <adking@redhat.com>
2021-04-06 16:04:17 -04:00
J. Eric Ivancich
b38cdb58dc
Merge pull request #40553 from dang/wip-dang-zipper-list
RGW Zipper - Make sure bucket list progresses

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
2021-04-06 13:49:35 -04:00
Patrick Donnelly
61b014c4a6
Merge PR #39939 into master
* refs/pull/39939/head:
	cephfs: ceph-dokan - properly log the mounted root
	cephfs: Update ceph-dokan "--removable" flag
	cephfs: document using multiple fs on Windows
	cephfs: provide additional volume details on Windows
	cephfs: add ceph-dokan unmap command

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-06 10:46:23 -07:00
Patrick Donnelly
d0e3b7129d
Merge PR #40418 into master
* refs/pull/40418/head:
	test: unmount when finished ino_release_cb
	test: wait a time for inode release
	qa: move ino_release_cb to libcephfs sub-suite
	qa: simplify recall triggers for bug
	qa: fix name for qa task referencing tracker issue

Reviewed-by: Jeff Layton <jlayton@redhat.com>
2021-04-06 10:45:00 -07:00
Patrick Donnelly
eb38b924ff
Merge PR #40460 into master
* refs/pull/40460/head:
	client: only check pool permissions for regular files

Reviewed-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-04-06 10:43:54 -07:00