Commit Graph

11 Commits

Author SHA1 Message Date
Sage Weil
ffce49f96a CodingStyle: update my_type_t sample
Signed-off-by: Sage Weil <sage@redhat.com>
2018-05-24 14:03:49 -05:00
Sage Weil
2c45dc6fe7 CodingStyle: allow #pragma once
Signed-off-by: Sage Weil <sage@redhat.com>
2018-05-23 06:42:09 -05:00
Sage Weil
69a1715a74 CodingStyle: a few updates
The C++ style was originally adopted in 2011.  Most of the guidelines
have been followed but some have not.  Drop the ones we haven't been
following.

Signed-off-by: Sage Weil <sage@redhat.com>
2018-05-22 21:40:11 -05:00
Joao Eduardo Luis
7528728197 CodingStyle: add python and javascript/typescript
As we are rapidly expanding our code base beyond C++ and C, it is a good
idea to enforce coding styles for other languages.

Signed-off-by: Joao Eduardo Luis <joao@suse.de>
2018-04-11 14:45:36 +01:00
Sage Weil
4e05cc748b "Correct" license from LGPL2 to LGPL2.1
Back in commit 7469f26a33 when the COPYING
file was added to the repository and the project was "licensed," the
license file was

                     GNU LESSER GENERAL PUBLIC LICENSE
                          Version 2.1, February 1999

However, the license was abbreviated as LGPL2 in various places (pretty
much everywhere, actually), due to my own ignorance/carelessness.  (I was
distinguishing it from shiny new version 3, released 6 months earlier.)

Version 2 of LGPL is the "Library General Public License," published in
June 1991: https://www.gnu.org/licenses/old-licenses/lgpl-2.0.html

Note that this ambiguity persists for most of the project's lifetime.  For
example, the original debian/copyright in 8adc9dac1d
said "LGPL2" bug in 4545f8b929 (2009, a year
later) it is changed to LGPL2.1 to satisfy Debian's lintian checks.  (It's
remained LGPL2.1 ever since.)

"Correct" the record by changing LGPL2 references to LGPL2.1.

Signed-off-by: Sage Weil <sage@redhat.com>
2018-03-13 16:07:50 -05:00
Kefu Chai
691199bd37 CodingStyle: fix broken URLs
Signed-off-by: Kefu Chai <kchai@redhat.com>
2015-11-30 21:12:37 +08:00
Dan Mick
e920a61521 Clarify CodingStyle with respect to tab compression of space runs
Signed-off-by: Dan Mick <dan.mick@inktank.com>
Reviewed-by: Greg Farnum <gregory.farnum@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
2012-08-31 15:47:12 -07:00
Sage Weil
a9f815b554 CodingStyle: whitespace
Signed-off-by: Sage Weil <sage@newdream.net>
2011-07-14 10:50:08 -07:00
Sage Weil
bc6eb10586 CodingStyle: final decisions?
- _d suffix for naked struct/class types (not _t!)

- m_ prefix for class members

- prefer braces for single line ifs.

Signed-off-by: Sage Weil <sage@newdream.net>
2011-07-14 10:49:33 -07:00
Tommi Virtanen
f29b9bd7de CodingStyle: Typos, whitespace. 2011-07-13 11:25:22 -07:00
Sage Weil
24faa3d198 CodingStyle 2011-07-11 09:57:22 -07:00