Commit Graph

76768 Commits

Author SHA1 Message Date
Sage Weil
03e6f976e7 Merge pull request #16869 from liewegas/wip-crush-ids
crush/CrushWrapper: fix out of bounds access

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-07 10:35:47 -05:00
Jos Collin
61074a7266 Merge pull request #16845 from amitkumar50/cov-librados-aio
test/librados: Initialize member variables in aio.cc

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 14:51:13 +00:00
amitkuma
7f7c40771d test/librados: Initializing left members from aio.cc
Fixes the coverity Issue:

** 1322815 Uninitialized pointer field
CID 1322815 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member m_sem is not initialized
in this constructor nor in any functions that it calls.

** 1322816 Uninitialized pointer field
CID 1322816 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member m_sem is not initialized
in this constructor nor in any functions that it calls.

** 1322817 Uninitialized pointer field
CID 1322817 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member m_sem is not initialized
in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-07 22:21:14 +05:30
Jason Dillaman
36f3c9ae09 rbd-mirror: clean up logging during test shut down
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:35 -04:00
Jason Dillaman
b38baa9489 rbd-mirror: avoid silently failing to register image replayer admin sockets
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:34 -04:00
Jason Dillaman
955e7cac4b rbd-mirror: restore deletion propagation and image replayer cleanup
The previous intermediate commits removed handling for deletion
propagation and image replayer cleanup since this logic has been
moved from instance to image replayer. Note that eventually the
policy's release notification will be responsible for the cleanup
of image replayers.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:34 -04:00
Jason Dillaman
eba021c151 rbd-mirror: ensure threads are mockable for testing
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:34 -04:00
Jason Dillaman
76b676dcb7 rbd-mirror: moved wait for deletion logic within image replayer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:34 -04:00
Jason Dillaman
fa58b08292 rbd-mirror: simplified acquire/release notification messages
The other instances should already know about the possible peers, so
we can co-opt these messages for use by the policy mapper.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:34 -04:00
Jason Dillaman
d49945242e rbd-mirror: co-opt image acquire/release notifications
This notifications will now be used by the policy when a (re)map is
required.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
5ae0f6a6b1 rbd-mirror: new 'peer image removed' notification to instance watchers
Note: this commit intentionally breaks backwards compatibility with
Luminous RC instance watcher notifications.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
4e1b834d2d rbd-mirror: simplify resync handling within image replayer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
028847cb33 rbd-mirror: pre-register image id before creating image
This fixes a potential race condition that could occur previously
if rbd-mirror daemon failed between creating an image and recording
the image id to the remote journal.

Fixes: http://tracker.ceph.com/issues/15764
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
2a6cfd8373 rbd-mirror: clean up bootstrap recovery from missing local image
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
5dcd9ed0d5 rbd-mirror: image replayer should query remote mirror uuid / image id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:33 -04:00
Jason Dillaman
b3dba1c876 rbd-mirror: helper state machine for querying remote peer uuid / image id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:13:31 -04:00
Jason Dillaman
697c1d7a4a rbd-mirror: helper state machine for retrieving image id from global id
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:09:21 -04:00
Jason Dillaman
bde2f9e1ac Merge pull request #16393 from PCzhangPC/fix3
rbd: 'image-meta remove' for missing key does not return error

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-08-07 10:03:20 -04:00
Sage Weil
bf494e9455 crush/CrushWrapper: fix out of bounds access
Fixes: http://tracker.ceph.com/issues/20926
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-07 09:39:18 -04:00
Sage Weil
4f01c8fc91 Merge pull request #16851 from xiexingguo/wip-doc-update-class-cli
doc/release-notes: update device class cli
2017-08-07 08:26:35 -05:00
Yuri Weinstein
59a0f3c532 Merge pull request #16551 from fangyuxiangGL/data-notifier-interval
rgw: add a separate configuration for data notify interval

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-08-07 05:48:54 -07:00
Yuri Weinstein
93a7ae801a Merge pull request #16726 from theanalyst/rgw-crypt-debug-log
rgw_crypt: log error messages during failures

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@mirantis.com>
2017-08-07 05:48:14 -07:00
Yuri Weinstein
1c63af1286 Merge pull request #16770 from tianshan/fix_create_bucket
rgw: should not restrict location_constraint same when user not provide

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 05:45:52 -07:00
Nathan Cutler
8bb3d8444f qa: big: add openstack.yaml
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2017-08-07 12:07:36 +02:00
Jos Collin
e5da05f8f7 Merge pull request #16862 from scienceluo/wip-luo-check-fix-branch
common/cmdparse.cc: remove unused variable 'argnum' in dump_cmd_to_json()

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 09:30:48 +00:00
Luo Kexue
5d6d22997a Common: remove variable 'argnum' that is modified but its new value is never used.
Signed-off-by: Luo Kexue <luo.kexue@zte.com.cn>
2017-08-07 16:21:16 +08:00
xie xingguo
d066ab2fe6 doc/release-notes: update device class cli
These commands are nearly stable and are unlikely to change for now...

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-07 12:28:53 +08:00
Jos Collin
6f00f9a71d Merge pull request #16847 from amitkumar50/cov-1054870
rgw: Initialize of member variable admin_specified in RGWUserAdminOpState

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-07 04:01:36 +00:00
Sage Weil
311bfcaf04 Merge pull request #16822 from liewegas/wip-20849
os/bluestore: _do_remove: dirty shard individually as each blob is unshared

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-06 21:43:22 -05:00
Sage Weil
fce8d83fdf Merge pull request #16844 from xiexingguo/wip-bluestore-core
os/bluestore: default journal media to store media if bluefs is disabled

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-06 20:17:57 -05:00
Sage Weil
1a9363596d Merge pull request #14053 from jdurgin/wip-19191
osd/PG: reset the missing set when restarting backfill

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-06 14:08:34 -05:00
Sage Weil
96f3ef6fd1 Merge pull request #16837 from xiexingguo/wip-still-more-class-fixes
crush: more class fixes

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-06 14:07:33 -05:00
Sage Weil
db47061327 Merge pull request #16838 from xiexingguo/wip-fix-purge
mon/OSDMonitor: sanity check osd before performing 'osd purge'

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-06 14:07:15 -05:00
Sage Weil
0b5267e428 Merge pull request #16832 from liewegas/wip-20915
rpm,deb: fix ceph-volume

Reviewed-by: Nathan Cutler <ncutler@suse.com>
2017-08-06 13:41:21 -05:00
amitkuma
f47baa86aa messages: Initialization of uninitialized members varied classes
Fixes the coverity issues:

** 1188168 Uninitialized scalar field
CID 1188168 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member success is not initialized
in this constructor nor in any functions that it calls.

** 1188169 Uninitialized scalar field
2. uninit_member: Non-static class member map_epoch is not initialized
in this constructor nor in any functions that it calls.
CID 1188169 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member min_epoch is not initialized
in this constructor nor in any functions that it calls.

** 1188170 Uninitialized scalar field
2. uninit_member: Non-static class member map_epoch is not initialized
in this constructor nor in any functions that it calls.
CID 1188170 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member min_epoch is not initialized
in this constructor nor in any functions that it calls.

** 1188171 Uninitialized scalar field
2. uninit_member: Non-static class member map_epoch is not initialized
in this constructor nor in any functions that it calls.
CID 1188171 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member min_epoch is not initialized
in this constructor nor in any functions that it calls.

** 1188172 Uninitialized scalar field
2. uninit_member: Non-static class member map_epoch is not initialized
 in this constructor nor in any functions that it calls.
CID 1188172 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member min_epoch is not initialized
 in this constructor nor in any functions that it calls.

** 1188173 Uninitialized scalar field
2. uninit_member: Non-static class member map_epoch is not initialized
 in this constructor nor in any functions that it calls.
CID 1188173 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member min_epoch is not initialized
 in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-06 23:11:10 +05:30
amitkuma
1a6bc40881 rgw: Initilzation of admin_specified
Fixes the coverity issue:

** 1054870 Uninitialized scalar field
CID 1054870 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member admin_specified is not
initialized in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-06 22:55:07 +05:30
amitkuma
3b4a4b2292 messages: Initialization of members module messages
Fixes coverity issues:

** 1054864 Uninitialized scalar field
2. uninit_member: Non-static class member op is not initialized
in this constructor nor in any functions that it calls.
CID 1054864 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member version is not initialized
in this constructor nor in any functions that it calls.

** 1054865 Uninitialized scalar field
2. uninit_member: Non-static class member map_epoch is not initialized
in this constructor nor in any functions that it calls.
CID 1054865 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member min_epoch is not initialized
in this constructor nor in any functions that it calls.

** 1054866 Uninitialized scalar field
2. uninit_member: Non-static class member map_epoch is not initialized
in this constructor nor in any functions that it calls.
CID 1054866 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member min_epoch is not initialized
in this constructor nor in any functions that it calls.

** 1054867 Uninitialized scalar field
2. uninit_member: Non-static class member map_epoch is not initialized
in this constructor nor in any functions that it calls.
CID 1054867 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member min_epoch is not initialized
in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-06 22:43:21 +05:30
Sage Weil
c275379348 os/bluestore: _do_remove: dirty shard individually as each blob is unshared
Two problems with old code:

1- dirty_shard range is inclusive, so we might dirty the shard after b_end
2- we might unshare blobs in two shards with an unloaded shard in between,
which would mean dirtying a shard that isn't loaded.

Fix by ensuring the shard for each unshared blob is dirty individually.

Fixes: http://tracker.ceph.com/issues/20849
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 10:32:01 -04:00
Sage Weil
95a0288368 Merge pull request #16849 from liewegas/wip-jewel-x
qa/suites/upgarde/jewel-x/parallel: more whitelisting
2017-08-06 09:15:35 -05:00
Sage Weil
ed2d984ad1 qa/suites/upgarde/jewel-x/parallel: more whitelisting
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 10:04:14 -04:00
Sage Weil
18b06bc04f Merge pull request #16830 from liewegas/wip-jewel-x
upgrade/jewel-x: a few fixes

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2017-08-06 08:57:55 -05:00
Sage Weil
58f15d2b98 qa/suites/upgrade/jewel-x/parallel: more whitelisting
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Sage Weil
622e950e43 qa/suites/upgrade/*-x/parallel: whitelist more stuff
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Sage Weil
2d260443f0 qa/suites/upgrade/*/parallel: disable POOL_APP_NOT_ENABLED
There is some other random workload running (that creates pools)
while we upgrade and wait for healthy.  Just disable the warning
for these tests.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Sage Weil
7908552cc3 mon: add mon_warn_on_pool_no_app option
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Sage Weil
f4c2863999 qa/suites/upgrade/jewel-x/parallel: whitelist OSD_DOWN
We restart OSDs during the upgrade.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Sage Weil
d7848f9358 mon/MgrMonitor: use static mgr commands if none defined yet
During upgrade, we may get a command (like 'pg dump') before we
pass our first post-upgrade paxos round embedding the static mgr
commands.  Until then, use the static mgr commands (that's what
we're proposing anyway).

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-06 09:56:55 -04:00
Adir Lev
720d044db1
msg/async/rdma: improves RX buffer management
The commit adds following changes:
- rx buffers are allocated from the memory pool (boost::pool)
- flat memory layout for buffer data/metadata to reduce cpu cache misses
- number of receive buffers can be much larger than receive queue len
- post new buffers to the srq as soon as possible.
- stat counters

Signed-off-by: Alex Mikheev <alexm@mellanox.com>
2017-08-06 11:21:48 +00:00
xie xingguo
0fc6a5feb3 os/bluestore: default journal media to store media if bluefs is disabled
So we won't prevent bluestore-without-bluefs backed OSDs from booting:
0> 2017-08-06 18:28:07.431316 7ffa1c95fd00 -1 /home/xxg/build/ceph-dev/src/os/bluestore/BlueStore.cc: In function
'virtual bool BlueStore::is_journal_rotational()' thread 7ffa1c95fd00 time 2017-08-06 18:28:07.428503
/home/xxg/build/ceph-dev/src/os/bluestore/BlueStore.cc: 4401: FAILED assert(bluefs)

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-06 18:58:14 +08:00
Jos Collin
f1b1e94494 Merge pull request #16780 from amitkumar50/cov-1414521
libradosstriper: Initialize member variable m_writeRc in WriteCompletionData

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-06 09:05:34 +00:00