Commit Graph

44725 Commits

Author SHA1 Message Date
Sage Weil
48c4228671 Merge pull request #5800 from ceph/wip-user
ceph-disk: do async startup on upstart; fix dmcrypt create/activate bug

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-09-10 18:48:53 -04:00
Sage Weil
d4eeb9be0f rocksdb: recognized --without-tcmalloc
Signed-off-by: Sage Weil <sage@redhat.com>
2015-09-10 17:03:03 -04:00
David Zafman
86dbfc88f8 Merge pull request #5031 from trociny/wip-10098
ceph-objectstore-tool: add mark-complete operation

Reviewed-by: David Zafman <dzafman@redhat.com>
2015-09-10 13:42:09 -07:00
Yehuda Sadeh
fa94ca4ed0 Merge pull request #5866 from jmunhoz/wip-requestid-on-error
rgw: include RequestId as part of the Error response

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2015-09-10 13:14:40 -07:00
Kefu Chai
a795c885e9 common/buffer: add the move constructor for bufferlist
Signed-off-by: Kefu Chai <kchai@redhat.com>
2015-09-10 13:13:41 -07:00
Kefu Chai
1b43d811de common/buffer: fix the const-ness of bufferlist::contents_equal()
Signed-off-by: Kefu Chai <kchai@redhat.com>
2015-09-10 12:16:35 -07:00
Kefu Chai
8ed7242226 test/bufferlist: do not expect !is_page_aligned() after unaligned rebuild
if the size of a bufferlist is page aligned we allocate page aligned
memory chunk for it when rebuild() is called. otherwise we just call
the plain new() to allocate new memory chunk for holding the continuous
buffer. but we should not expect that `new` allocator always returns
unaligned memory chunks. instead, it *could* return page aligned
memory chunk as long as the allocator feels appropriate. so, the
`EXPECT_FALSE(bl.is_page_aligned())` after the `rebuild()` call is
removed.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2015-09-10 12:09:49 -07:00
Kefu Chai
6504e37334 common/buffer: add bufferlist::const_iterator
* implement bufferlist::iterator using bufferlist::iterator_impl
* unlike its cousin, `bufferlist::const_iterator` is not exported using
  CEPH_BUFFER_API. will do it once we think it will have external users.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2015-09-10 12:09:49 -07:00
Joao Eduardo Luis
046bdf8e9e Merge pull request #5859 from jecluis/wip-test-mon-ping
test: mon/mon-ping.sh: make sure 'ceph mon ping' works as expected

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-09-10 20:04:41 +01:00
Josh Durgin
50c9beeba2 Merge pull request #5873 from dillaman/wip-rbd-missing-return
rbd: missing return statement within do_metadata_remove

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-09-10 13:45:37 -04:00
Danny Al-Gaaf
5a2b688cd8 src/.gitignore: add some more files to be ignored
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:22 +02:00
Danny Al-Gaaf
1aaccd79f3 librbd/test_internal.cc: fix -Wsign-compare
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
99ea120ba9 objectstore/store_test.cc: fix -Wsign-compare
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
d9d4989046 Transaction.c: replace deprecated function call
Replace deprecated use of collection_move() with collection_move_rename().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
6e97b0fa85 rbd.cc: fix -Wreturn-type, return result from do_metadata_remove()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
2767736a91 osdc/Objecter.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
0297ce191a osd/ReplicatedPG.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
120071bcc6 osd/OSD.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
a1be9ef4fe NewStore.cc: prefer --/++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
534fdd5c8f ErasureCodeShecTableCache.cc: prefer --operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
4a2377c40b rgw_object_expirer_core.cc: remove left over unused variable
Remove unused variable is_next_available and while loop. These
are leftovers from commit #a69a989f.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
b229162e36 client/Client.cc: fix memory leak, free sgids in error case
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
e243aa84c0 mds/MDSDaemon.cc: fix resource leak in MDSDaemon
Delete mdsmap in descructor. Remove not needed checks for
mds_rank and objecter before call delete since the C++ standard
allows the deletion of pointer with NULL-value. The check is
redundant.

Fix for:
CID 1316224 (#1 of 1): Resource leak in object (CTOR_DTOR_LEAK)
1. alloc_new: Allocating memory by calling new MDSMap.
2. var_assign: Assigning: this->mdsmap = new MDSMap.
3. ctor_dtor_leak: The constructor allocates field mdsmap of MDSDaemon
   but the destructor and whatever functions it calls do not free it.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Danny Al-Gaaf
a29dd45dd8 client/Client.cc: remove only once used variable
Fix for:
[src/client/Client.cc:4555]: (style) The scope of the variable
 'initial_group_count' can be reduced.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Danny Al-Gaaf
7a7248d952 ConfigKeyService.cc: move assert before first deref
Fix for:

[src/mon/ConfigKeyService.cc:94] -> [src/mon/ConfigKeyService.cc:100]:
 (warning) Possible null pointer dereference: m - otherwise it is redundant
 to check it against null.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Danny Al-Gaaf
742feec7bc mds/MDCache.cc: fix unitialized variable
Fix for:

[src/mds/MDCache.cc:8172]: (error) Uninitialized variable: checked_rank

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Jason Dillaman
8e07c8c8af rbd: missing return statement within do_metadata_remove
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-09-10 12:21:57 -04:00
Sage Weil
e7c509ab75 Merge pull request #5780 from dzafman/wip-12387
osd: When generating past intervals due to an import end at pg epoch

Reviewed-by: Sage Weil <sage@redhat.com>
2015-09-10 10:56:45 -04:00
Sage Weil
82ba048d2c common: add debug option to deliberately leak some memory
This will be used to verify leak detection tests are working.

Signed-off-by: Sage Weil <sage@redhat.com>
2015-09-10 10:35:11 -04:00
Sage Weil
c4401ad60e test/Makefile-client: ship LibradosTestStub.h in tarball
Signed-off-by: Sage Weil <sage@redhat.com>
2015-09-10 07:51:52 -04:00
Loic Dachary
3d73e5b172 Merge pull request #5868 from jmunhoz/wip-x-amz-request-id-doc
doc: rgw: update x-amz-request-id status

Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@ril.com>
2015-09-10 12:50:34 +02:00
Orit Wasserman
f00c243de9 Merge pull request #5863 from ceph/wip-13015
rgw: preserve all attrs if intra-zone copy
2015-09-10 12:16:03 +02:00
Javier M. Mellid
71909b64b8 doc: rgw: update x-amz-request-id status
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2015-09-10 11:25:17 +02:00
Javier M. Mellid
c503e97b7f rgw: include RequestId as part of the Error response
The RGW error responses must contain a RequestId to be compliant with
the Amazon S3 errors. This RequestId is the ID of the request associated
with the error.

Fixes: #13020

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2015-09-10 10:58:02 +02:00
Joao Eduardo Luis
94d84ccd95 test: mon/mon-ping.sh: make sure 'ceph mon ping' works as expected
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
2015-09-10 09:53:59 +01:00
Joao Eduardo Luis
b7aaecc903 Merge pull request #5343 from hjwsm1989/wip-12442
mon/MonClient: fix error in 'ceph ping mon.id'

Reviewed-by: Joao Eduardo Luis <joao@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-10 09:46:58 +01:00
Mykola Golub
6907778d76 ceph-objectstore-tool: add mark-complete operation
It is supposed to be used as a last resort to fix a cluster that has
PGs in 'incomplete' state, using the following procedure:

1) stop the osd that is primary for the incomplete PG;
2) run:
  ceph-objectstore-tool --data-path ... --journal-path ... --pgid $PGID --op mark-complete
3) start the osd.

Fixes: #10098
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
2015-09-10 09:01:30 +03:00
Josh Durgin
903983a11a Merge pull request #5816 from dillaman/wip-librbd-gmock
Initial support for gmock-based unit tests in librbd

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-09-10 01:47:07 -04:00
Sage Weil
a1941026f0 Merge pull request #5557 from guangyy/wip-12666
rgw: expose the number of unhealthy workers through admin socket

Reviewed-by: Sage Weil <sage@redhat.com>
2015-09-09 22:16:09 -04:00
Josh Durgin
8218fd1485 Merge pull request #5786 from ceph/wip-12911
rbd export-diff should export data chunks in-order

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-09-09 21:18:07 -04:00
Loic Dachary
6e0d93cc6d Merge pull request #5858 from jecluis/wip-test-mon-scrub
test: mon/mon-scrub.sh: have test running on make check

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-09-10 02:55:55 +02:00
Yehuda Sadeh
06147dda2c rgw: preserve all attrs if intra-zone copy
Fixes: #13015
Intra zone copy requires that all objects' attributes are preserved.
This was broken at commit: e41d97c8e3

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
2015-09-09 15:43:55 -07:00
Sage Weil
f74c60f429 Merge pull request #5442 from ceph/wip-12551
ReplicatedPG,Objecter: copy_get should include truncate_seq and size

Reviewed-by: Sage Weil <sage@redhat.com>
2015-09-09 16:21:07 -04:00
Yehuda Sadeh
6c7265a67c Merge pull request #5490 from dwj192/master
rgw:add --reset-regions for regionmap update

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2015-09-09 11:38:24 -07:00
Joao Eduardo Luis
293d12a2bc test/Makefile.am: run mon/mon-scrub.sh as part of checks
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
2015-09-09 18:17:48 +01:00
Joao Eduardo Luis
6ceb37d4ba test: mon/mon-scrub.sh: port clashed with other tests
This will allow the test to be run during make check.

Signed-off-by: Joao Eduardo Luis <joao@suse.de>
2015-09-09 18:17:48 +01:00
Yehuda Sadeh
dbf8f67e69 Merge pull request #5828 from lebauce/fix-swift-prefix
rgw: add delimiter to prefix only when path is specified

Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
2015-09-09 08:33:59 -07:00
Danny Al-Gaaf
897f074969 test_async_compressor.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00
Danny Al-Gaaf
9d9b305981 os/KeyValueStore.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00
Danny Al-Gaaf
8810f8f2b8 SnappyCompressor.h: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00