Commit Graph

130723 Commits

Author SHA1 Message Date
Venky Shankar
91dcd8bda1
Merge pull request #45971 from rishabh-d-dave/cephfs-shell-exclam-marks
qa/cephfs: bug fix and some cleanup for test_cephfs_shell.py

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-04-21 18:52:20 +05:30
Kefu Chai
f1907aeb4b
Merge pull request #45977 from tchaikov/wip-cmake-dml-cleanup
cmake: try to find dml only if PMEM is enabled

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-04-21 19:31:20 +08:00
Rishabh Dave
a4bbb62bd6 qa/cephfs: cleanup some code in test_cephfs_shell.py
Also delete a comment since it's incorrect.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2022-04-21 16:47:39 +05:30
Rishabh Dave
faa506798d qa/cephfs: don't use exclam mark in tests in test_cephfs_shell.py
Exclamation mark is a special character for bash as well as
cephfs-shell. For bash, it substitutes current command with matching
command from command history and for cephfs-shell it runs the command
as OS-level command and not inside the cephfs-shell.

And evey command executed in tests (say "ls") is run by passing it as a
parameter to cephfs-shell command (that is "cephfs-shell -c <conf> --
ls"). So, exclamation mark, when used in tests, is consumed by bash
instead of cephfs-shell.

To avoid these complications it's best (and even simpler!) to issue the
command meant for bash on bash without going through cephfs-shell.

Fixes: https://tracker.ceph.com/issues/55394
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2022-04-21 16:40:29 +05:30
Redouane Kachach
01c8999d03
mgr/cephadm: do not add _admin label when no-minimize-config is provided
Fixes: https://tracker.ceph.com/issues/52727

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2022-04-21 12:01:44 +02:00
Anthony D'Atri
161d7afe42
Merge pull request #45979 from lxbsz/doc_noatime
doc: cephfs: update with atime not supporting explaination
2022-04-21 01:03:10 -07:00
Redouane Kachach
92ecb58d46
mgr/cephadm: Adding image tag and date to cephadm startup messages
Fixes: https://tracker.ceph.com/issues/55008
Fixes: https://tracker.ceph.com/issues/54373
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2022-04-21 09:50:20 +02:00
Xiubo Li
54126629a6 doc: cephfs: update with atime not supporting explaination
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2022-04-21 14:10:24 +08:00
Greg Farnum
c454d0d1d3 test: osd: add a /0 cidr test for 32-bit...
...and make the OSDMap handle it.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2022-04-21 00:26:17 +00:00
Greg Farnum
8244586cf5 test: add a /0 cidr test that blocklists EVERYTHING
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2022-04-21 00:26:17 +00:00
Greg Farnum
138daff1dc test: add a 128-bit range blocklist test
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2022-04-21 00:26:17 +00:00
Kefu Chai
e43ba4c388
Merge pull request #45975 from adamemerson/wip-mrun-bashism
mrun: Change mrun to use bash

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-04-21 08:11:43 +08:00
Kefu Chai
ea4ae6d2f1 cmake/modules: use exact version of python3 when finding cython
* CMakeLists.txt:
    always pass "EXACT" to find_package(Python3).
    because per cmake document, "EXACT" only takes effect when
    <Package>_FIND_VERSION_COUNT is greater than 1, where <Package>
    is "Python3". see also cmake/modules/FindPython/Support.cmake
* cmake/modules/AddCephTest.cmake:
    drop redundant find_package(Python3) calls. since Python3 is
    a mandatory requirement for building Ceph, we only need a
    single call of find_package(Python3..) in the top of the source
    tree. the only possible case to repeat it is to ensure that we
    have the correct version of Python3 used in following CMake
    script. but there is no need to repeat it if we just want to
    ensure that we have a python3 interpretor in place.
* cmake/modules/Distutils.cmake:
    always pass "EXACT" to find_package(Python3).
    we should always pass EXACT to find_package() when finding python3,
    this is a follow-up of e2babdfae8

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-04-21 06:52:18 +08:00
Kefu Chai
c51b3c3a17 cmake: try to find dml only if PMEM is enabled
as the feature dependent on DML library requires PMEM backend.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-04-21 06:28:09 +08:00
Adam C. Emerson
1a049489cc tooling: Change mrun to use bash
Since mrun contains some bashisms, have it use bash explicitly.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2022-04-20 17:00:45 -04:00
David Galloway
62762fd913
Merge pull request #45973 from ionutbalutoiu/add-windows-tests
qa/crontab/teuthology-cronjobs: add windows suite
2022-04-20 16:08:21 -04:00
Ionut Balutoiu
d8113881a2 qa/crontab/teuthology-cronjobs: add windows suite
Signed-off-by: Ionut Balutoiu <ibalutoiu@cloudbasesolutions.com>
2022-04-20 19:56:23 +03:00
Daniel Gryniewicz
92252d22c8 RGW: Zipper - zonegroup, placement tier
Add ZoneGroup and PlacementTier to the Zipper API.  This cleaned up a
lot of issues in the Module branch.

In addition, add cloud transition.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2022-04-20 12:11:12 -04:00
Greg Farnum
6a997da13d test: add 32-bit ipv4 and 64-bit ipv6 blocklist testing
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2022-04-20 15:59:55 +00:00
Greg Farnum
f107f2124d test: add a 30-bit range mask to ipv6 blocklisting tests
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2022-04-20 15:59:55 +00:00
Greg Farnum
42910b432d test: split up ip- and range-based blocklisting tests
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2022-04-20 15:59:55 +00:00
Kefu Chai
8b7ee35c3a
Merge pull request #44230 from optimistyzy/122_add_dml
blk/pmem: use DML library to offload read/write operations in pmem

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-04-20 18:47:00 +08:00
Ilya Dryomov
9d130e1e7f
Merge pull request #45872 from idryomov/wip-make-check-enable-rbd-caches
run-make-check.sh: enable RBD persistent caches

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
2022-04-20 11:08:41 +02:00
Yingxin Cheng
3fdbf9c94a crimson/os/seastore/segment_cleaner: cleanup SegmentProvider interfaces
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-04-20 10:59:31 +08:00
Yingxin Cheng
6383581e18 crimson/os/seastore/segment_cleaner: cleanup segment_info_set_t
* better encapsulated interfaces to SegmentCleaner;
* drop unused device related implementations;
* improve related metrics and logs;

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2022-04-20 10:59:20 +08:00
Kefu Chai
ee4fdcd6e1
Merge pull request #45609 from optimistyzy/wip_pmem_devdax
blk/pmem: Add the devdax support.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-04-20 09:54:00 +08:00
David Galloway
1167dee3f0
Merge pull request #45048 from ceph/1710
doc: Add Quincy 17.2.0 release notes
2022-04-19 21:37:33 -04:00
Neha Ojha
c1d65f9790 doc/releases/quincy.rst: mention log_to_journald
Details about https://tracker.ceph.com/issues/55383

Signed-off-by: Neha Ojha <nojha@redhat.com>
2022-04-20 01:08:42 +00:00
David Galloway
9ffbeee152 doc: Typo and indentation fix
Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-04-19 20:20:44 -04:00
David Galloway
0f4be50475
Merge pull request #45933 from ionutbalutoiu/qa-add-rbd-wnbd-tests
qa: add basic Ceph on Windows integration test
2022-04-19 16:50:24 -04:00
David Galloway
20822019bd doc: No changelog for first release
The diff between origin/pacific..origin/quincy is definitely not what we want listed.  There is no Changelog for the first major release.

Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-04-19 14:32:39 -04:00
Neha Ojha
f581878c00 doc/releases: additional clarification, release date
- address review comments
- emphasize LevelDB removal
- update release date

Signed-off-by: Neha Ojha <nojha@redhat.com>
2022-04-19 17:30:08 +00:00
Venky Shankar
7608a400c0
Merge pull request #45945 from vshankar/wip-54374
mgr/snap_schedule: add time zone suffix to snapshot dir name

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-04-19 22:57:07 +05:30
David Galloway
a9d5958690
Merge pull request #45916 from tchaikov/wip-python3
cmake/modules: always use the python3 specified in command line
2022-04-19 11:55:35 -04:00
Samuel Just
66e7b59985
Merge pull request #45864 from cyx1231st/wip-crimson-refactor-with-device-ut
test/crimson/.../test_transaction_manager: test multiple devices

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-04-19 08:14:03 -07:00
Samuel Just
9a4294b756
Merge pull request #45938 from liu-chunmei/seastore-omap-enlarge
crimson/seastore: enlarge omap_leaf_node size

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-04-19 08:03:47 -07:00
Ionut Balutoiu
8054199787 qa: add basic Ceph on Windows integration test
Due to lack of Windows support in the Teuthology, the test case adopts
the following workaround:

* Deploy baremetal machine with `ubuntu_latest.yaml` and
  configure it with libvirt KVM.
* Create a libvirt VM and provision it with Windows Server 2019, using
  the official ISO from Microsoft.
* Configure SSH in the Windows VM, and run the tests remotely via SSH.

The implementation of the test case consists of workunit scripts.

`qa/workunits/windows/test_rbd_wnbd.py` is the main Python script
to test Ceph on Windows basic functionality. This is executed in the
libvirt VM configured with Windows Server 2019.

Co-authored-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Co-authored-by: Daniel Vincze <dvincze@cloudbasesolutions.com>

Signed-off-by: Ionut Balutoiu <ibalutoiu@cloudbasesolutions.com>
2022-04-19 17:21:52 +03:00
Ernesto Puerta
6f773621e1
Merge pull request #45708 from votdev/issue_55133_improve_exception_handling
mgr/dashboard: Imrove error message of '/api/grafana/validation' API endpoint

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-04-19 13:29:00 +02:00
Venky Shankar
3f13df8388
Merge pull request #45603 from nmshelke/feature-54472
mgr/volumes: set, get, list and remove metadata of subvolume

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-04-19 16:52:13 +05:30
Soumya Koduri
53667dd5eb
Merge pull request #45909 from soumyakoduri/wip-skoduri-dbstore-fixes
rgw/dbstore: Handle prefix/delim while listing objects
2022-04-19 16:34:32 +05:30
Milind Changire
24c13e53de mgr/snap_schedule: add time zone suffix to snapshot dir name
Fixes: https://tracker.ceph.com/issues/54374
Signed-off-by: Milind Changire <mchangir@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2022-04-19 06:49:18 -04:00
Ilya Dryomov
0f1634a21f run-make-check.sh: enable RBD persistent caches
This was attempted in commit 69a7ed4eab ("run-make-check: enable
WITH_RBD_RWL when WITH_PMEM is true") but never completed.  We soon
bumped the requirement on libpmem, so WITH_SYSTEM_PMDK=ON wouldn't
have worked anyway.

Enable the RWL mode conditionally based on WITH_RBD_RWL variable.
Enable the SSD mode unconditionally as it has no special dependencies
and can be built on any architecture.

Fixes: https://tracker.ceph.com/issues/55285
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-04-19 11:21:06 +02:00
Ilya Dryomov
59d928a06c test/encoding/check-generated.sh: show diff if binary reencode check fails
Take bf0b161115 ("test/encoding/check-generated.sh: show diff if cmp
fails") a bit further.  Suggesting "cmp $tmp1 $tmp2" isn't very helpful
since cmp would report just the mismatch offset.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-04-19 11:21:06 +02:00
Ilya Dryomov
91d270b210 librbd/cache/pwl: WriteLogCacheEntry constructor must initialize flags
Initializing the individual bit field members leaves the remaining two
bits uninitialized and that garbage state gets persisted.

In general, using bit fields in a structure where the layout actually
matters is not desirable.  Even with a few single bits, such as here,
their order, strictly speaking, is not guaranteed:

    An implementation may allocate any addressable storage unit large
    enough to hold a bit-field. If enough space remains, a bit-field
    that immediately follows another bit-field in a structure shall be
    packed into adjacent bits of the same unit. If insufficient space
    remains, whether a bit-field that does not fit is put into the next
    unit or overlaps adjacent units is implementation-defined. The
    order of allocation of bit-fields within a unit (high-order to
    low-order or low-order to high-order) is implementation-defined.
    The alignment of the addressable storage unit is unspecified.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-04-19 11:21:05 +02:00
Ilya Dryomov
2c131f57d6 librbd/cache/pwl: initialize generate_test_instances() objects
... to prevent check-generated.sh failures such as:

**** librbd::cache::pwl::WriteLogPoolRoot test 1 dump_json check failed ****
   ceph-dencoder type librbd::cache::pwl::WriteLogPoolRoot select_test 1 dump_json > /tmp/typ-cAoWrqlHC
   ceph-dencoder type librbd::cache::pwl::WriteLogPoolRoot select_test 1 encode decode dump_json > /tmp/typ-ES5yHpfGL
5c5
<     "flushed_sync_gen": 0,
---
>     "flushed_sync_gen": 255,

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-04-19 11:21:05 +02:00
Ilya Dryomov
753aa038fd librbd/cache/pwl: fix -Wunused-lambda-capture warnings
Reported by clang on "make check" and "make check arm64" builds.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-04-19 11:21:05 +02:00
Soumya Koduri
e51de26939 rgw/dbstore: Handle prefix/delim in Bucket::List op
Given a prefix, fetch only those objects matching the prefix.
In addition, skip the entries with "delim" and instead include
those entries in common_prefixes

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2022-04-19 13:23:09 +05:30
Soumya Koduri
61ede70869 rgw/dbstore: DBObject state initialization
Initialize & store 'state' part of DBObject to be
referenced by callers of 'get_obj_state'.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2022-04-19 13:23:09 +05:30
Ziye Yang
86cb8c75c3 Add the support to use DML library for PMEM device.
The purpose of this patch is to add the initial support to
offload memory/pmem operations by sync usage through hardware path
in DML library.

Signed-off-by: Ziye Yang <ziye.yang@intel.com>
2022-04-19 14:51:12 +08:00
Liu-Chunmei
453f53ad47
Merge pull request #45866 from liu-chunmei/crimson-longxattr
crimson: check long attr name

Reviewed-by: Samuel Just <sjust@redhat.com>
Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-04-18 20:09:07 -07:00