Commit Graph

76476 Commits

Author SHA1 Message Date
Kefu Chai
c4b25b114d Merge pull request #16677 from tchaikov/wip-20785
osd: do not send pg_created unless luminous

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-08-01 13:12:53 +08:00
Yanhu Cao
ce7fed2926 ceph-osd: fix auto detect which objectstore is currently running
Fixes: http://tracker.ceph.com/issues/20865

Signed-off-by: Yanhu Cao <gmayyyha@gmail.com>
2017-08-01 10:44:57 +08:00
Josh Durgin
886971b58b mon/OSDMonitor: make setting require-osd-release idempotent
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2017-07-31 21:51:47 -04:00
Josh Durgin
966513908c osd: do not try to set device class before luminous
This avoids crashing when older monitors do not support it.

Fixes: http://tracker.ceph.com/issues/20850
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2017-07-31 21:50:48 -04:00
David Zafman
901f14aa7c Merge pull request #16663 from dzafman/wip-ec-enoent
osd: EC read handling: don't grab an objectstore error to use as the read error

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 18:19:02 -07:00
Jos Collin
7e9d87fa2e Merge pull request #16681 from shun-s/wip-doc-config
doc: fix typos in config.rst

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-01 00:59:06 +00:00
Patrick Donnelly
8db2c43e79
qa: test export_pin is correct in dumped subtree
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2017-07-31 15:33:49 -07:00
Gregory Farnum
b16b973e39 Merge pull request #16695 from tchaikov/wip-cmake-disable-vta
cmake: disable -fvar-tracking-assignments for config.cc

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 15:05:23 -07:00
Patrick Donnelly
e52fdc0c4f
mds: print export_pin for dumped subtree
Fixes: http://tracker.ceph.com/issues/20595

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2017-07-31 15:00:18 -07:00
Gregory Farnum
861225339d Merge pull request #16697 from wjwithagen/wip-wjw-ENODATA-HashIndex.cc
HashIndex.cc: add compat.h for ENODATA

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 14:59:43 -07:00
Patrick Donnelly
5e5ff5c086
qa: ignore failed MDS message during upgrade
The cluster is expected to become degraded during reboot.

Fixes: http://tracker.ceph.com/issues/20731
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2017-07-31 14:45:07 -07:00
Adam C. Emerson
d02db19cf8 Merge pull request #16689 from pritha-srivastava:wip-rgw-policy-parse-error
rgw: Fix for Policy Parse exception in case of multiple statements.

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2017-07-31 14:43:58 -04:00
Adam C. Emerson
bf223bab68 Merge pull request #16661 from adamemerson/wip-throttle-minimal
throttle: Minimal destructor fix for Luminous

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 14:08:20 -04:00
J. Eric Ivancich
81d3def3c2 doc: Describe mClock's use within Ceph in great detail.
It seems many are initially unclear as to how the current
implementations of mclock op queues work, so we need to document it to
avoid confusion.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2017-07-31 13:20:31 -04:00
Adam C. Emerson
0f52f486ef throttle: Minimal destructor fix for Luminous
Get rid of the undefined behavior of destroying condition variables
while they're being waited on.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2017-07-31 13:17:46 -04:00
Douglas Fuller
58073cfcd1 cephfs: Resend discover when joining from starting state
From: Zheng Yan <zyan@redhat.com>

Kick discover messages when transitioning from STATE_STARTING
to STATE_ACTIVE.

Fixes: http://tracker.ceph.com/issues/20799
Signed-off-by: Douglas Fuller <dfuller@redhat.com>
2017-07-31 10:51:38 -04:00
Douglas Fuller
bffa375975 cephfs: Wait for MDCache to be ready before starting log segment
These can race as the MDS starts.

Fixes: http://tracker.ceph.com/issues/20799
Signed-off-by: Douglas Fuller <dfuller@redhat.com>
2017-07-31 10:51:24 -04:00
Jason Dillaman
05b182c1c2 Merge pull request #16547 from dillaman/wip-dashboard-iscsi
mgr/dashboard: RBD iSCSI daemon status page

Reviewed-by: John Spray <john.spray@redhat.com>
2017-07-31 10:22:21 -04:00
Song Shun
2556605b79 doc: fix sevral typos
fix sevral typos

Signed-off-by: Song Shun <song.shun3@zte.com.cn>
2017-07-31 22:10:51 +08:00
Jason Dillaman
41c251c243 Merge pull request #16670 from Yan-waller/wip-walle-0729rbdcompile
cls/rbd: silence warning from -Wunused-variable

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-07-31 10:07:45 -04:00
Jason Dillaman
9b3fe6f03b Merge pull request #16583 from lxbsz/ws_macro
librbd: add LIBRBD_SUPPORTS_WRITESAME support

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-07-31 09:49:13 -04:00
John Spray
f8068cd438 mon: extensible output format for health checks
The summary field can be extended with the fields
used to construct the message (e.g. including
the down osd count in the message about osds
being down).

The detail entries, similarly, can be extended
with machine-readable fields like the PG ID
for a damaged PG.

For the moment all the internal stuff is just
strings still, but we change the output format
so that we don't break it later when we
add things.

Signed-off-by: John Spray <john.spray@redhat.com>
2017-07-31 09:33:12 -04:00
John Spray
ac01dff6a9 osd/mon/mds: fix config set tell command
This was working for setting values, but failing to call
the config observers, so some values didn't take effect.

Fixes: http://tracker.ceph.com/issues/20803
Signed-off-by: John Spray <john.spray@redhat.com>
2017-07-31 09:28:21 -04:00
Yan Jun
b3b1f2cfb2 cls/rbd: silence warning from -Wunused-variable
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
2017-07-31 21:26:13 +08:00
Jason Dillaman
51c7cec7bb Merge pull request #16694 from Songweibin/wip-doc-rbd
rbd: modified some commands' description into imperative sentence

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-07-31 09:12:27 -04:00
Willem Jan Withagen
9667222d98 HashIndex.cc: add compat.h for ENODATA
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2017-07-31 15:02:53 +02:00
Kefu Chai
8bc029b6af mon/OSDMonitor: assert(pg in creating_pgs.pg) in send_pg_creates()
and mark OSDMonitor::send_pg_creates() a const method.

See-also: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-07-31 20:58:58 +08:00
Jason Dillaman
a2857c8181 Merge pull request #16686 from amitkumar50/cov-1351525-1
rbd: fixed coverity 'Argument cannot be negative' warning

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-07-31 08:53:40 -04:00
Kefu Chai
9dc53c276f cmake: disable -fvar-tracking-assignments for config.cc
there are too many variables involved in config.cc, but
-fvar-tracking-assignments is enabled by default, when the compiler
finds that the number of variables exceeds the limit
"max-vartrack-size", it gives up, and tries again disabling this
option.

this change avoids the recompilation of config.cc and also
silences the warning of

src/common/config.cc:77:1: note: variable tracking size limit exceeded
with -fvar-tracking-assignments, retrying without
 md_config_t::md_config_t(bool is_daemon)
 ^

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-07-31 20:34:26 +08:00
amitkuma
01fe317d02 rbd: 1351525 Argument cannot be negative
Fixed:

** CID 1351525 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
7. negative_returns: sd is passed to a parameter that cannot be negative.

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-07-31 17:58:32 +05:30
songweibin
f9a94641e5 rbd: modified some commands' description into imperative sentence
Signed-off-by: songweibin <song.weibin@zte.com.cn>
2017-07-31 20:25:30 +08:00
Orit Wasserman
25cef9a097 rgw: Fix up to 1000 entries at a time in check_bad_index_multipart
Fixes: http://tracker.ceph.com/issues/20772
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
2017-07-31 14:51:27 +03:00
Luo Kexue
e22a91290d rgw: remove some unused variable
Signed-off-by: Luo Kexue <luo.kexue@zte.com.cn>
2017-07-31 19:40:12 +08:00
John Spray
cbd2e303e9 doc: update client.admin key refs to "mds 'allow'"
This is more correctly "mds 'allow *'".

In the RADOS user management page, refer the user
to the cephfs client auth docs, rather than attempting
to explain MDS cap syntax inline.

Signed-off-by: John Spray <john.spray@redhat.com>
2017-07-31 11:58:29 +01:00
John Spray
fa70335db2 Merge pull request #16660 from nrdmn/patch-2
doc: added mgr caps to manual deployment documentation

Reviewed-by: John Spray <john.spray@redhat.com>
2017-07-31 11:53:53 +01:00
Pritha Srivastava
358045a032 rgw: Fix for Policy Parse exception in case of multiple statements.
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
2017-07-31 12:18:38 +05:30
liuchang0812
3f5d51ac3c os/bluestore: clear result in BlueRocksEnv::getChildren
see https://github.com/facebook/rocksdb/blob/master/env/env_posix.cc#L492. in
rocksdb::env_posix implementation, it will always clear result at first. We will
get a core dump when we use rocksdb::RepairDB if we do not clear result.

Fixes: http://tracker.ceph.com/issues/20857

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
2017-07-31 13:20:45 +08:00
Kefu Chai
7df9ab607f pybind/rados: use new APIs instead of deprecated ones
s/rados_read_op_omap_get_vals/rados_read_op_omap_get_vals2/
s/rados_read_op_omap_get_keys/rados_read_op_omap_get_keys2/

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-07-31 12:31:59 +08:00
Luo Kexue
e8cf00e8e5 auth: Remove unused function in AuthSessionHandler
Signed-off-by: Luo Kexue <luo.kexue@zte.com.cn>
2017-07-31 08:16:08 +08:00
Kefu Chai
729cf44679 Merge pull request #16627 from liewegas/wip-objecter-eagain
osdc/Objecter: unify disparate EAGAIN handling paths into one

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-30 15:33:52 +08:00
Kefu Chai
4357837c7e Merge pull request #16668 from Yan-waller/wip-walle-0729configoption
common: fix Option set_long_description

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-07-30 13:18:10 +08:00
mychoxin
ba26907d71 print more information when run ceph-osd with 'chech options'
Signed-off-by: mychoxin <mychoxin@gmail.com>
2017-07-30 12:28:41 +08:00
Kefu Chai
0b54fd90df mon/OSDMonitor: more verbose message for pg creation
See-also: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-07-30 11:17:15 +08:00
Kefu Chai
4584bff33f osd: do not send pg_created unless luminous
See-also: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-07-30 11:17:06 +08:00
xie xingguo
4736037394 crush: clean up get_immediate_parent_id()
This is a follow-up cleanup of 9d908c14f6

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-07-29 19:46:28 +08:00
xie xingguo
0f23574234 crush: avoid implicitly cast
pool-id may overflow(though actually can not happen...)

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-07-29 16:58:50 +08:00
xie xingguo
7974a0fd95 mon/OSDMonitor: make error output more human-readable
Was:

./bin/ceph osd crush weight-set reweight rbd osd.0  1 2 3 4 5
Error ENOENT: weight_set_size != 5 for bucket -1weight_set_size != 5 for bucket -2weight_set_size != 5 for bucket -3weight_set_size != 5 for bucket -4item 0 not found in crush map

Now:
./bin/ceph osd crush weight-set reweight rbd osd.0  1 2 3 4 5
Error EINVAL: must specify exact 3 weight values

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-07-29 16:58:50 +08:00
Xie Xingguo
a977599cae Merge pull request #16669 from Yan-waller/wip-walle-0729testpglogcompile
test/osd: kill compile warning

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-07-29 13:44:31 +08:00
Yan Jun
7e45879640 test/osd: kill compile warning
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
2017-07-29 11:23:11 +08:00
Kefu Chai
4694cf402f Merge pull request #16667 from tchaikov/wip-objclass-omap
objclass: modify omap_get_{keys,vals} api

Reviewed-by: Sage Weil <sage@redhat.com>
2017-07-29 11:10:38 +08:00