crimson/net: refactors to encapsulate ProtocolV2 message read and write paths and event dispatching
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Refine the syntax (and in some cases, the semantics) of the English in
"Multi-site Configuration Reference" in doc/radosgw/multisite.rst. This
is a long section, so more PRs are likely.
https://tracker.ceph.com/issues/58632
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
This is also effectively full coverage of `check_units` as well
as check_time_sync is the only consumer.
Signed-off-by: John Mulligan <jmulligan@redhat.com>
when you create/edit an nfs export from dashboard it leaves this traceback and error
```
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard ERROR taskexec] Error while calling Task(ns=nfs/create, md={'path': 'e2e.nfs.bucket', 'fsal': 'RGW', 'cluster_id': 'testnfs'})
Traceback (most recent call last):
File "/usr/share/ceph/mgr/dashboard/tools.py", line 550, in _run
val = self.task.fn(*self.task.fn_args, **self.task.fn_kwargs) # type: ignore
File "/usr/share/ceph/mgr/dashboard/controllers/nfs.py", line 148, in create
ret, _, err = export_mgr.apply_export(cluster_id, json.dumps(raw_ex))
TypeError: 'AppliedExportResults' object is not iterable
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard INFO taskmgr] finished Task(ns=nfs/create, md={'path': 'e2e.nfs.bucket', 'fsal': 'RGW', 'cluster_id': 'testnfs'})
Feb 09 14:15:54 ceph-node-00 ceph-mgr[3235]: [dashboard INFO request] [::ffff:192.168.100.1:43896] [POST] [500] [0.767s] [admin] [172.0B] /api/nfs-ganesha/export
```
This started after https://github.com/ceph/ceph/pull/46209, so dashboard code needs to be adapted
Fixes: https://tracker.ceph.com/issues/58681
Signed-off-by: Nizamudeen A <nia@redhat.com>
for replicated pools.
osd: Added workload balance score to the command
ceph osd pool ls detail
(different flavors for console output and json/xml output)
mon: Added command 'osd rm-primary-temp'
(developers only) rm was not working
vstart: Added osd debug messages into mon log with -d flag
For commands that execute methonds in OSD module
Signed-off-by: Josh Salomon <jsalomon@redhat.com>
Listing is performed using the radosgw-admin command api we have with
the mgr for now until the S3 api is fixed: https://tracker.ceph.com/issues/58547.
This commit fixes and issue with regards to the _crud.py controller
where redefining `CRUDClassMetadata` caused the users table and the
roles table to share columns. We fixed this by creating
CRUDClassMetadata dynamically for each endpoint.
The issue described above is linked to an issue with NamedTuple were
default nested lists are not a great move because it can cause
unexpected issues when 2 or more classes are created. Moreover,
NamedTuples are read-only making initialization even harder without
factory methods as with dataclasses. Therefore, let's move to the good
old __init__ :).
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com>
Fixes: https://tracker.ceph.com/issues/58699
crimson/osd: make the ObjectContextRegistry per-PG
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Using the existing common default chunk size for scrubs that are
not deep scrubs is wasteful: a high ratio of inter-OSD messages
per chunk, while the actual OSD work per chunk is minimal.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
crimson/osd/pg: synchronize processing of peering events and backfill
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
This happens because core and rbd ownership is defined after
doc-writers: a later match takes precedence.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
compiling main branch on Fedora 38 and 39/rawhide with gcc-c++-13.0.1
fails with the error:
/builddir/build/BUILD/ceph-18.0.0-2148-g9754cafc/src/rgw/rgw_token.cc:
In function 'int main(int, char**)':
/builddir/build/BUILD/ceph-18.0.0-2148-g9754cafc/src/rgw/rgw_token.cc:125:3:
error: reference to 'formatter' is ambiguous
125 | formatter = new JSONFormatter(true /* pretty */);
| ^~~~~~~~~
Similar error for src/test/test_rgw_token.cc
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
This was failing for me on new tox versions with
fix: commands[1]> autopep8 --max-line-length 100
incorrect number of argumentsfix: exit 99 (0.06 seconds) /home/adking/ceph/src/cephadm> autopep8 --max-line-length 100 pid=309039
fix: FAIL ✖ in 0.08 seconds
As it was considering our list of args for autopep8 to each be
one separate command. Fixed by just adding slashes to the ends
of the lines (as has already been done in the tox.ini in src/pybind/mgr
for some of the tests there)
Signed-off-by: Adam King <adking@redhat.com>
English grammar and syntax pass for "Failover and Disaster Recovery" in
doc/radosgw/multisite.rst.
https://tracker.ceph.com/issues/58632
Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
The existing
xmlstarlet sel -t -v '//mirror/peers/peer[1]/uuid')" = ""
test is bogus since a tx-only peer gets added after the remote
rbd-mirror daemon pings the local cluster. It happened to pass most
of the time because xmlstarlet filter just failed on an empty peers
array, producing the wrongly expected empty string by accident.
Fixes: https://tracker.ceph.com/issues/58688
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
