Commit Graph

44764 Commits

Author SHA1 Message Date
Danny Al-Gaaf
99ea120ba9 objectstore/store_test.cc: fix -Wsign-compare
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
d9d4989046 Transaction.c: replace deprecated function call
Replace deprecated use of collection_move() with collection_move_rename().

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
6e97b0fa85 rbd.cc: fix -Wreturn-type, return result from do_metadata_remove()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
2767736a91 osdc/Objecter.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
0297ce191a osd/ReplicatedPG.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
120071bcc6 osd/OSD.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
a1be9ef4fe NewStore.cc: prefer --/++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
534fdd5c8f ErasureCodeShecTableCache.cc: prefer --operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
4a2377c40b rgw_object_expirer_core.cc: remove left over unused variable
Remove unused variable is_next_available and while loop. These
are leftovers from commit #a69a989f.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
b229162e36 client/Client.cc: fix memory leak, free sgids in error case
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:21 +02:00
Danny Al-Gaaf
e243aa84c0 mds/MDSDaemon.cc: fix resource leak in MDSDaemon
Delete mdsmap in descructor. Remove not needed checks for
mds_rank and objecter before call delete since the C++ standard
allows the deletion of pointer with NULL-value. The check is
redundant.

Fix for:
CID 1316224 (#1 of 1): Resource leak in object (CTOR_DTOR_LEAK)
1. alloc_new: Allocating memory by calling new MDSMap.
2. var_assign: Assigning: this->mdsmap = new MDSMap.
3. ctor_dtor_leak: The constructor allocates field mdsmap of MDSDaemon
   but the destructor and whatever functions it calls do not free it.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Danny Al-Gaaf
a29dd45dd8 client/Client.cc: remove only once used variable
Fix for:
[src/client/Client.cc:4555]: (style) The scope of the variable
 'initial_group_count' can be reduced.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Danny Al-Gaaf
7a7248d952 ConfigKeyService.cc: move assert before first deref
Fix for:

[src/mon/ConfigKeyService.cc:94] -> [src/mon/ConfigKeyService.cc:100]:
 (warning) Possible null pointer dereference: m - otherwise it is redundant
 to check it against null.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Danny Al-Gaaf
742feec7bc mds/MDCache.cc: fix unitialized variable
Fix for:

[src/mds/MDCache.cc:8172]: (error) Uninitialized variable: checked_rank

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-10 19:29:20 +02:00
Jason Dillaman
8e07c8c8af rbd: missing return statement within do_metadata_remove
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-09-10 12:21:57 -04:00
Sage Weil
e7c509ab75 Merge pull request #5780 from dzafman/wip-12387
osd: When generating past intervals due to an import end at pg epoch

Reviewed-by: Sage Weil <sage@redhat.com>
2015-09-10 10:56:45 -04:00
Sage Weil
82ba048d2c common: add debug option to deliberately leak some memory
This will be used to verify leak detection tests are working.

Signed-off-by: Sage Weil <sage@redhat.com>
2015-09-10 10:35:11 -04:00
Sage Weil
c4401ad60e test/Makefile-client: ship LibradosTestStub.h in tarball
Signed-off-by: Sage Weil <sage@redhat.com>
2015-09-10 07:51:52 -04:00
xiexingguo
90f1d25cd8 msg/simple: start over after fails to bind a port in specified range
Fixes: #13002
Signed-off-by: xie.xiexingguo@zte.com.cn
2015-09-10 18:52:50 +08:00
Loic Dachary
3d73e5b172 Merge pull request #5868 from jmunhoz/wip-x-amz-request-id-doc
doc: rgw: update x-amz-request-id status

Reviewed-by: Abhishek Lekshmanan <abhishek.lekshmanan@ril.com>
2015-09-10 12:50:34 +02:00
Orit Wasserman
f00c243de9 Merge pull request #5863 from ceph/wip-13015
rgw: preserve all attrs if intra-zone copy
2015-09-10 12:16:03 +02:00
Javier M. Mellid
71909b64b8 doc: rgw: update x-amz-request-id status
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2015-09-10 11:25:17 +02:00
Javier M. Mellid
c503e97b7f rgw: include RequestId as part of the Error response
The RGW error responses must contain a RequestId to be compliant with
the Amazon S3 errors. This RequestId is the ID of the request associated
with the error.

Fixes: #13020

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2015-09-10 10:58:02 +02:00
Joao Eduardo Luis
94d84ccd95 test: mon/mon-ping.sh: make sure 'ceph mon ping' works as expected
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
2015-09-10 09:53:59 +01:00
Joao Eduardo Luis
b7aaecc903 Merge pull request #5343 from hjwsm1989/wip-12442
mon/MonClient: fix error in 'ceph ping mon.id'

Reviewed-by: Joao Eduardo Luis <joao@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-10 09:46:58 +01:00
Mykola Golub
6907778d76 ceph-objectstore-tool: add mark-complete operation
It is supposed to be used as a last resort to fix a cluster that has
PGs in 'incomplete' state, using the following procedure:

1) stop the osd that is primary for the incomplete PG;
2) run:
  ceph-objectstore-tool --data-path ... --journal-path ... --pgid $PGID --op mark-complete
3) start the osd.

Fixes: #10098
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
2015-09-10 09:01:30 +03:00
Josh Durgin
903983a11a Merge pull request #5816 from dillaman/wip-librbd-gmock
Initial support for gmock-based unit tests in librbd

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-09-10 01:47:07 -04:00
Sage Weil
a1941026f0 Merge pull request #5557 from guangyy/wip-12666
rgw: expose the number of unhealthy workers through admin socket

Reviewed-by: Sage Weil <sage@redhat.com>
2015-09-09 22:16:09 -04:00
Josh Durgin
8218fd1485 Merge pull request #5786 from ceph/wip-12911
rbd export-diff should export data chunks in-order

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-09-09 21:18:07 -04:00
Loic Dachary
6e0d93cc6d Merge pull request #5858 from jecluis/wip-test-mon-scrub
test: mon/mon-scrub.sh: have test running on make check

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-09-10 02:55:55 +02:00
Yehuda Sadeh
06147dda2c rgw: preserve all attrs if intra-zone copy
Fixes: #13015
Intra zone copy requires that all objects' attributes are preserved.
This was broken at commit: e41d97c8e3

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
2015-09-09 15:43:55 -07:00
Sage Weil
f74c60f429 Merge pull request #5442 from ceph/wip-12551
ReplicatedPG,Objecter: copy_get should include truncate_seq and size

Reviewed-by: Sage Weil <sage@redhat.com>
2015-09-09 16:21:07 -04:00
Yehuda Sadeh
6c7265a67c Merge pull request #5490 from dwj192/master
rgw:add --reset-regions for regionmap update

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
2015-09-09 11:38:24 -07:00
Joao Eduardo Luis
293d12a2bc test/Makefile.am: run mon/mon-scrub.sh as part of checks
Signed-off-by: Joao Eduardo Luis <joao@suse.de>
2015-09-09 18:17:48 +01:00
Joao Eduardo Luis
6ceb37d4ba test: mon/mon-scrub.sh: port clashed with other tests
This will allow the test to be run during make check.

Signed-off-by: Joao Eduardo Luis <joao@suse.de>
2015-09-09 18:17:48 +01:00
Yehuda Sadeh
dbf8f67e69 Merge pull request #5828 from lebauce/fix-swift-prefix
rgw: add delimiter to prefix only when path is specified

Reviewed-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
2015-09-09 08:33:59 -07:00
Danny Al-Gaaf
897f074969 test_async_compressor.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00
Danny Al-Gaaf
9d9b305981 os/KeyValueStore.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00
Danny Al-Gaaf
8810f8f2b8 SnappyCompressor.h: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00
Danny Al-Gaaf
4f98dab99c client/Client.cc: fix realloc memory leak
Fix handling of realloc. If realloc() fails it returns NULL, assigning
the return value of realloc() directly to the pointer without checking
for the result will lead to a memory leak.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2015-09-09 15:36:44 +02:00
Samuel Just
6f9ee7961e ReplicatedPG,Objecter: copy_get should include truncate_seq and size
Otherwise, we break CephFS over cache tiers.

Fixes: #12551
Signed-off-by: Samuel Just <sjust@redhat.com>
2015-09-09 08:01:59 -04:00
Loic Dachary
384d7f4c3c Merge pull request #5837 from tchaikov/wip-12968
mon: disable gmt_hitset if not supported

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-09-09 13:06:47 +02:00
Kefu Chai
cdca05feb0 Merge pull request #5842 from dzafman/wip-cot-failure
test: Fix failure test to find message anywhere in stderr

Reviewed-by: Loic Dachary <ldachary@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2015-09-09 18:12:30 +08:00
Jianpeng Ma
797caae1f4 test/librados: add test case for read object (off=0,len=0).
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2015-09-09 16:26:14 +08:00
Jianpeng Ma
19a210a0e7 osd: make read(off=0,len=0) ec-object work.
When len=0, it mean read the whole object. It can work when reading
no-ec object off=0 & len=0. But for ec-object, it can't work.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2015-09-09 16:26:14 +08:00
Haomai Wang
ae5e961e9d Merge pull request #5845 from wonzhq/async-rx
AsyncMessenger: add instance name in debug log when processing msg

Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
2015-09-09 15:20:01 +08:00
Loic Dachary
ddb5301e7e Merge pull request #5779 from dzafman/wip-misc-fix-guangyy
osd: check the length of the map before accessing the first element

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-09-09 09:00:41 +02:00
Josh Durgin
f95174260d Merge pull request #5843 from dillaman/wip-12885
librbd: diff_iterate needs to handle holes in parent images

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-09-09 02:55:44 -04:00
Josh Durgin
714a091e1a Merge pull request #5592 from xinxinsh/wip-fix-rbd-metadata
fix bugs of rbd metadata operation

Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-09-09 02:54:45 -04:00
David Zafman
95bd3c2c54 test: Fix failure test to find message anywhere in stderr
Consolidate test_failure() and test_failure_tty()

Signed-off-by: David Zafman <dzafman@redhat.com>
2015-09-08 23:44:39 -07:00